ASoC: rt5616: Return error if device ID mismatch

PATCH In review Axel Lin 3 participants 3 messages Dec 22, 2015 – Dec 23, 2015

Subsystems (3)

Sound ASoC Realtek audio codecs

lore

Share & tools

lore

Axel Lin

author

2015-12-22 02:16 UTC #0 lore raw

PATCH 1/1 ASoC: rt5616: Return error if device ID mismatch

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/codecs/rt5616.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/codecs/rt5616.c +1 -1

index f4005cb..0e9414a 100644
@@ -1314,7 +1314,7 @@ static int rt5616_i2c_probe(struct i2c_client *i2c,
 		dev_err(&i2c->dev,
 			"Device with ID register %#x is not rt5616\n",
 			val);
-		ret = -ENODEV;
+		return -ENODEV;
 	}
 	regmap_write(rt5616->regmap, RT5616_RESET, 0);
 	regmap_update_bits(rt5616->regmap, RT5616_PWR_ANLG1,

Signature · 1 line

2.1.4

Bard Liao

Acked-by on v1 1/1

2015-12-22 03:00 UTC #1 lore raw

Quoted 8 lines

-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Tuesday, December 22, 2015 10:17 AM
To: Mark Brown
Cc: Bard Liao; Oder Chiou; Liam Girdwood; [email protected]
Subject: [PATCH] ASoC: rt5616: Return error if device ID mismatch
Signed-off-by Axel Lin <[email protected]>

Acked-by Bard Liao <[email protected]>

Mark Brown

maintainer

2015-12-23 00:09 UTC #2 lore raw

Applied "ASoC: rt5616: Return error if device ID mismatch" to the asoc tree

In reply to Axel Lin

The patch

ASoC: rt5616: Return error if device ID mismatch

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 36ddd489b0669f8913c8eda192507f8267749917 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Tue, 22 Dec 2015 10:16:35 +0800
Subject: [PATCH] ASoC: rt5616: Return error if device ID mismatch

Signed-off-by Axel Lin <[email protected]>

Acked-by Bard Liao <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/codecs/rt5616.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/soc/codecs/rt5616.c +1 -1

index f4005cbaa99d..0e9414abab65 100644
@@ -1314,7 +1314,7 @@ static int rt5616_i2c_probe(struct i2c_client *i2c,
 		dev_err(&i2c->dev,
 			"Device with ID register %#x is not rt5616\n",
 			val);
-		ret = -ENODEV;
+		return -ENODEV;
 	}
 	regmap_write(rt5616->regmap, RT5616_RESET, 0);
 	regmap_update_bits(rt5616->regmap, RT5616_PWR_ANLG1,

Signature · 1 line

2.6.2