Skip to contentSkip to conversation

thrift: Add recipe for Apache Thrift.

PATCH Superseded Philip Balister 3 participants 4 messages Dec 22, 2015 – Jan 4, 2016

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thrift: Add recipe for Apache Thrift.

* Run tested cpp bindings with GNU Radio Control Port.

---
 .../recipes-connectivity/thrift/thrift_0.9.3.bb    | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +30 -0
new file mode 100644
index 0000000..43b93cd
@@ -0,0 +1,30 @@
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=e4ed21f679b2aafef26eac82ab0c2cbf"
+
+SRC_URI = "git://git-wip-us.apache.org/repos/asf/thrift.git;protocol=https \
+"
+SRCREV = "61b8a29b0704ccd81b520f2300f5d1bb261fea3e"
+S = "${WORKDIR}/git"
+
+DEPENDS = "thrift-native boost python libevent flex-native bison-native openssl"
+
+BBCLASSEXTEND = "native nativesdk"
+
+inherit pkgconfig cmake pythonnative
+
+export STAGING_INCDIR
+export STAGING_LIBDIR
+export BUILD_SYS
+export HOST_SYS
+
+EXTRA_OECMAKE = "-DWITH_QT4=OFF"
+EXTRA_OECMAKE_append_class-native = "-DWITH_QT4=OFF -DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_CPP=OFF"
+EXTRA_OECMAKE_append_class-nativesdk = "-DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_PYTHON=OFF"
+
+do_install_append () {
+	cd ${D}/${bindir}
+	ln -sf thrift thrift-compiler
+}
+
Signature · 1 line
2.1.0
#1 lore raw

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb

Quoted 14 lines · Philip Balister

* Run tested cpp bindings with GNU Radio Control Port.

---
 .../recipes-connectivity/thrift/thrift_0.9.3.bb    | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +0 -0
new file mode 100644
index 0000000..43b93cd
@@ -0,0 +1,30 @@

Maybe add SUMMARY, DESCRIPTION and HOMEPAGE ?

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 9

Quoted 9 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +9 -0
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=e4ed21f679b2aafef26eac82ab0c2cbf"
+
+SRC_URI = "git://git-wip-us.apache.org/repos/asf/thrift.git;protocol=https \
+"
+SRCREV = "61b8a29b0704ccd81b520f2300f5d1bb261fea3e"
+S = "${WORKDIR}/git"
+
+DEPENDS = "thrift-native boost python libevent flex-native bison-native openssl"

Move DEPENDS above SRC_URI.

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 22

Quoted 12 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +12 -0
+BBCLASSEXTEND = "native nativesdk"
+
+inherit pkgconfig cmake pythonnative
+
+export STAGING_INCDIR
+export STAGING_LIBDIR
+export BUILD_SYS
+export HOST_SYS
+
+EXTRA_OECMAKE = "-DWITH_QT4=OFF"
+EXTRA_OECMAKE_append_class-native = "-DWITH_QT4=OFF -DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_CPP=OFF"

-DWITH_QT4=OFF is duplicated and _append without a leading space looks dubious.

Maybe better for the native and nativesdk classes to just over-ride EXTRA_OECMAKE rather than try to append?

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 28

Quoted 6 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +6 -0
+EXTRA_OECMAKE_append_class-nativesdk = "-DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_PYTHON=OFF"
+
+do_install_append () {
+       cd ${D}/${bindir}
+       ln -sf thrift thrift-compiler

Perhaps drop the unnecessary cd, ie:

  ln -sf thrift ${D}/${bindir}/thrift-compiler
Quoted 10 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +2 -1
+}
+
--

2.1.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

Thanks. Too much excitement over the output doing something useful. I need to get this off my local tree since I know of at least one other person working with thrift.

I'll update and resend.

Philip

Quoted 69 lines · Andre McCurdy

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb

Quoted 14 lines · Philip Balister

* Run tested cpp bindings with GNU Radio Control Port.

---
 .../recipes-connectivity/thrift/thrift_0.9.3.bb    | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +0 -0
new file mode 100644
index 0000000..43b93cd
@@ -0,0 +1,30 @@

Maybe add SUMMARY, DESCRIPTION and HOMEPAGE ?

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 9

Quoted 9 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +9 -0
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=e4ed21f679b2aafef26eac82ab0c2cbf"
+
+SRC_URI = "git://git-wip-us.apache.org/repos/asf/thrift.git;protocol=https \
+"
+SRCREV = "61b8a29b0704ccd81b520f2300f5d1bb261fea3e"
+S = "${WORKDIR}/git"
+
+DEPENDS = "thrift-native boost python libevent flex-native bison-native openssl"

Move DEPENDS above SRC_URI.

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 22

Quoted 12 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +12 -0
+BBCLASSEXTEND = "native nativesdk"
+
+inherit pkgconfig cmake pythonnative
+
+export STAGING_INCDIR
+export STAGING_LIBDIR
+export BUILD_SYS
+export HOST_SYS
+
+EXTRA_OECMAKE = "-DWITH_QT4=OFF"
+EXTRA_OECMAKE_append_class-native = "-DWITH_QT4=OFF -DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_CPP=OFF"

-DWITH_QT4=OFF is duplicated and _append without a leading space looks dubious.

Maybe better for the native and nativesdk classes to just over-ride EXTRA_OECMAKE rather than try to append?

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 28

Quoted 6 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +6 -0
+EXTRA_OECMAKE_append_class-nativesdk = "-DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_PYTHON=OFF"
+
+do_install_append () {
+       cd ${D}/${bindir}
+       ln -sf thrift thrift-compiler

Perhaps drop the unnecessary cd, ie:

  ln -sf thrift ${D}/${bindir}/thrift-compiler
Quoted 10 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +2 -1
+}
+
--

2.1.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
In reply to Philip Balister
Quoted 14 lines · Philip Balister

* Run tested cpp bindings with GNU Radio Control Port.

---
 .../recipes-connectivity/thrift/thrift_0.9.3.bb    | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +0 -0
new file mode 100644
index 0000000..43b93cd

meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb line 9

Quoted 9 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +9 -0
@@ -0,0 +1,30 @@
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=e4ed21f679b2aafef26eac82ab0c2cbf"
+
+SRC_URI = "git://git-wip-us.apache.org/repos/asf/thrift.git;protocol=https \
+"
+SRCREV = "61b8a29b0704ccd81b520f2300f5d1bb261fea3e"
+S = "${WORKDIR}/git"
+
+DEPENDS = "thrift-native boost python libevent flex-native bison-native openssl"

Autodetects qt5 qmake and fails to use it, please disable it explicitly

| -- Parsed Thrift version: 1.0.0 (1.0.0)
| CMake Error at /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/qemux86/usr/lib/cmake/Qt5Core/Qt5CoreConfig.cmake:27 (message):

|   The imported target "Qt5::Core" references the file
| 
|      "/qmake"
| 
Quoted 29 lines
meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb new file +21 -0
+
+BBCLASSEXTEND = "native nativesdk"
+
+inherit pkgconfig cmake pythonnative
+
+export STAGING_INCDIR
+export STAGING_LIBDIR
+export BUILD_SYS
+export HOST_SYS
+
+EXTRA_OECMAKE = "-DWITH_QT4=OFF"
+EXTRA_OECMAKE_append_class-native = "-DWITH_QT4=OFF -DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_CPP=OFF"
+EXTRA_OECMAKE_append_class-nativesdk = "-DBUILD_TESTING=OFF \
+             -DBUILD_EXAMPLES=OFF -DWITH_PYTHON=OFF"
+
+do_install_append () {
+	cd ${D}/${bindir}
+	ln -sf thrift thrift-compiler
+}
+
Signature · 7 lines
2.1.0

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]