Skip to contentSkip to conversation

Fixing xdriver_xf86-video-ati building

PATCH Superseded Lada Trimasova 3 participants 7 messages Dec 23, 2015 – Dec 24, 2015

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Fixing xdriver_xf86-video-ati building

xdriver_xf86-video-ati depends on the radeon driver from libdrm and DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver which needs to be enabled for all architectures.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Lada Trimasova (2):
Enabling mesa3d radeon driver for all architectures Fixing xdriver_xf86-video-ati dependencies

 package/mesa3d/Config.in                       | 1 -
 package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.5.0
#1 lore raw

PATCH v2 1/2 Enabling mesa3d radeon driver for all architectures

Mesa32 radeon driver doesn't depend on x86 and can be built for all architectures.

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/mesa3d/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/mesa3d/Config.in +0 -1
index 40af2ef..fcfd3c3 100644
@@ -122,7 +122,6 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 	bool "DRI radeon driver"
-	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
Signature · 1 line
2.5.0
#2 lore raw

PATCH v2 1/2 Enabling mesa3d radeon driver for all architectures

Lada, All,

On 2015-12-23 15:49 +0300, Lada Trimasova spake thusly:

Quoted 6 lines

Mesa32 radeon driver doesn't depend on x86 and can be built for all architectures.

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 package/mesa3d/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/mesa3d/Config.in +0 -1
index 40af2ef..fcfd3c3 100644
@@ -122,7 +122,6 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 	bool "DRI radeon driver"
-	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
Signature · 6 lines
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH v2 1/2 Enabling mesa3d radeon driver for all architectures

In reply to Lada Trimasova

Dear Lada Trimasova,

Quoted 9 lines · Lada Trimasova

Mesa32 radeon driver doesn't depend on x86 and can be built for all architectures.

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/mesa3d/Config.in | 1 -
 1 file changed, 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH v2 2/2 Fixing xdriver_xf86-video-ati dependencies

In reply to Lada Trimasova

This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/x11r7/xdriver_xf86-video-ati/Config.in +3 -2
index 191c20f..00d91bd 100644
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
 	bool "xf86-video-ati"
 	depends on BR2_PACKAGE_MESA3D
-	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_LIBDRM_RADEON
+	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_GLPROTO
Signature · 1 line
2.5.0
#5 lore raw

PATCH v2 2/2 Fixing xdriver_xf86-video-ati dependencies

Lada, All,

On 2015-12-23 15:49 +0300, Lada Trimasova spake thusly:

Quoted 20 lines

This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Cc Alexey Brodkin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/x11r7/xdriver_xf86-video-ati/Config.in +0 -0
index 191c20f..00d91bd 100644

package/x11r7/xdriver_xf86-video-ati/Config.in line 6

Quoted 8 lines
package/x11r7/xdriver_xf86-video-ati/Config.in +3 -2
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
 	bool "xf86-video-ati"
 	depends on BR2_PACKAGE_MESA3D
-	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_LIBDRM_RADEON
+	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON

Sorry that I missed it in my previous reply, but you select libdrm, so you need to propagate its dependencies, too:

    depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm -> libpthread-stubs

This dependency is currently not a problem, because mesa3d hasa stricter dependency on NPTL, but you still have to propagate the dependencies of the packages you select.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/x11r7/xdriver_xf86-video-ati/Config.in +0 -0
 	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_GLPROTO
Signature · 6 lines
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH v2 2/2 Fixing xdriver_xf86-video-ati dependencies

Yes, sorry, I've missed this completely.

Regards,
Lada Trimasova
On Wed, 2015-12-23 at 19:31 +0100, Yann E. MORIN wrote:

Lada, All,

On 2015-12-23 15:49 +0300, Lada Trimasova spake thusly:

This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver.

Fixes:
http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035

Signed-off-by Lada Trimasova <ltrimas at synopsys.com<mailto:[email protected]>>
Cc Alexey Brodkin <abrodkin at synopsys.com<mailto:[email protected]>>
Cc Thomas Petazzoni <thomas.petazzoni at free-electrons.com<mailto:[email protected]>>
Cc Peter Korsgaard <peter at korsgaard.com<mailto:[email protected]>>
---
 package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/x11r7/xdriver_xf86-video-ati/Config.in +3 -2
index 191c20f..00d91bd 100644
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
        bool "xf86-video-ati"
        depends on BR2_PACKAGE_MESA3D
-       select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-       select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
+       select BR2_PACKAGE_LIBDRM
+       select BR2_PACKAGE_LIBDRM_RADEON
+       select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
 
 
 

Sorry that I missed it in my previous reply, but you select libdrm, so you need to propagate its dependencies, too:

    depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm -> libpthread-stubs

This dependency is currently not a problem, because mesa3d hasa stricter dependency on NPTL, but you still have to propagate the dependencies of the packages you select.

Regards,
Yann E. MORIN.

select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
select BR2_PACKAGE_XPROTO_FONTSPROTO
select BR2_PACKAGE_XPROTO_GLPROTO
--
2.5.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net<mailto:[email protected]>
http://lists.busybox.net/mailman/listinfo/buildroot