allow strictatime to be set as a global default
Raymond Jennings
Reviewed-by Mandeep SandhuI've been cooking a very simple patch that hopefully gives both sides of the "great strictatime war" what they want with minimal pain. I sent it through kernelnewbies for a basic review and got some polish on irc.
----
fs/Kconfig +7 -0
@@ -4,6 +4,20 @@ menu "File systems" +config DEFAULT_STRICTATIME + bool "Use strictatime by default" + default n + help + Use strictatime as a default mount option. + + Relatime became the default in 2007 to reduce I/O load on block
devices.
+
+ Enabling this option will restore historic behavior and provide
perfectly
+ accurate atimes, but the increase in write load may reduce
performance
+ and shorten the life of the block device.
+
+ If unsure, say N.
+
# Use unaligned word dcache accesses
config DCACHE_WORD_ACCESS
bool
fs/namespace.c +0 -0
@@ -2680,9 +2680,15 @@ long do_mount(const char *dev_name, const char
__user *dir_name,
if (retval)
goto dput_out;
- /* Default to relatime unless overriden */
+#ifdef CONFIG_DEFAULT_STRICTATIME
+ /* Default to strictatime unless overridden */
+ if (flags & MS_RELATIME)
+ mnt_flags |= MNT_RELATIME;
+#else
+ /* Default to relatime unless overridden */
if (!(flags & MS_NOATIME))
mnt_flags |= MNT_RELATIME;
+#endif
/* Separate the per-mountpoint flags */
if (flags & MS_NOSUID)
---------- Forwarded message ----------
From: Mandeep Sandhu <[email protected]>
Subject: Re: [PATCH] allow strictatime to be set as a global default
Date: Sat, 19 Dec 2015 17:25:37 -0800
To: Raymond Jennings <[email protected]>
Cc: kernelnewbies <[email protected]>
Looks good to me.
To test the real waters....you should send it to the lists you mentioned (or whatever the maintainers script tells you).
Good luck,
-mandeep
Quoted 129 lines · Raymond Jennings
How does this version look?
(the other delta for the other file was untouched)
Any chance it is ready to post to the big list (presumably fs with a
cc to
lkml)?diff --git a/fs/Kconfig b/fs/Kconfig
index 6ce72d8..122a993 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -4,6 +4,20 @@menu "File systems"
+config
DEFAULT_STRICTATIME
+ bool "Use strictatime by default"
+ default n
+ help
+ Use strictatime as a default mount option.
+
+ Relatime became the default in 2007 to reduce I/O load on block
devices.
+
+ Enabling this option will restore historic behavior and provide
perfectly
+ accurate atimes, but the increase in write load may reduce
performance
+ and shorten the life of the block device.
+
+ If unsure, say N.
+
# Use unaligned word dcache accesses
configDCACHE_WORD_ACCESS
boolQuoted 88 lines · Mandeep Sandhu
Ah yes...now it makes sense! :)
The current 'word of caution' (about increased I/O load on block devices), seems mild IMHO. Maybe we should we have a stricter warning...something like enabling this option might be harmful to
the
life of your block device (due to excessive writes) and will also
lead
to reduced performance?HTH,
-mandeepQuoted 4 lines · Raymond Jennings
Quoted 2 lines · Mandeep Sandhu
You've removed the strictatime option altogether. So how does
that
Quoted 4 lines
Quoted 1 line
satisfy people who _do_ want it?
...actually it looks like I was an idiot and got my diff
backwards when
Quoted 13 lines
I
pulled it out of git :PHere's the correct version.
fs/Kconfig +0
-0@@ -4,6 +4,17 @@menu "File systems"
fs/Kconfig
Quoted 7 lines
fs/Kconfig +7
-0+config DEFAULT_STRICTATIME + bool "Use strictatime by default" + default n + help + Use strictatime as a default mount option. + + Strictatime preserves ancient historic behavior ofkeeping the
Quoted 2 lines
atime field always up to date.
+ However, it was changed in 2007 to relatime to reduceI/O load
fs/namespace.c long do_mount(const char *dev_name, const
Quoted 13 lines
on
block devices.fs/Kconfig +3
-0+ + If unsure, say N. +# Use unaligned word dcache accesses
configDCACHE_WORD_ACCESS
boolfs/namespace.c +0
-0@@ -2680,9 +2680,15 @@ long do_mount(const char *dev_name, constchar
Quoted 22 lines
__user*dir_name,if (retval) goto dput_out;fs/namespace.c +7
-1-/* Default to relatime unless overriden */ +#ifdef CONFIG_DEFAULT_STRICTATIME +/* Default to strictatime unless overridden */ +if (flags &MS_RELATIME ) + mnt_flags |=MNT_RELATIME ; +#else +/* Default to relatime unless overridden */ if (!(flags &MS_NOATIME )) mnt_flags |=MNT_RELATIME ; +#endif /* Separate the per-mountpoint flags */ if (flags &MS_NOSUID )