Skip to contentSkip to conversation

ARM: multi_v7_defconfig: MFD_DA9063 is boolean, not tristate

PATCH New Thierry Reding 2 participants 2 messages Dec 29, 2015 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: MFD_DA9063 is boolean, not tristate

From: Thierry Reding <[email protected]>

The MFD_DA9063 Kconfig symbol is a boolean, not tristate, and therefore m is not a valid value.

Cc Geert Uytterhoeven <[email protected]>

---
Note that the driver builds fine as a module, but I suspect that there was some other reason for making it boolean only.

 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/multi_v7_defconfig +1 -1
index 3a4dafdf3b60..96c8a4c2ebcd 100644
@@ -430,7 +430,7 @@ CONFIG_MFD_AXP20X_RSB=m
 CONFIG_MFD_CROS_EC=m
 CONFIG_MFD_CROS_EC_I2C=m
 CONFIG_MFD_CROS_EC_SPI=m
-CONFIG_MFD_DA9063=m
+CONFIG_MFD_DA9063=y
 CONFIG_MFD_MAX14577=y
 CONFIG_MFD_MAX77686=y
 CONFIG_MFD_MAX77693=y
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: MFD_DA9063 is boolean, not tristate

Hi Thierry,

Quoted 10 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The MFD_DA9063 Kconfig symbol is a boolean, not tristate, and therefore m is not a valid value.

Cc Geert Uytterhoeven <[email protected]>

---
Note that the driver builds fine as a module, but I suspect that there was some other reason for making it boolean only.

The change to make it tristate is expected to go in through a different tree, cfr. "[PATCH] mfd: da9063: Allow modular build"
(https://lkml.org/lkml/2015/12/7/759).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds