Skip to contentSkip to conversation

mmc: tegra: don't enable UHS modes on Tegra210

PATCH In review Lucas Stach 3 participants 3 messages Dec 30, 2015 – Jan 5, 2016 1 message not in the archive

Subsystems (3)
MMC, SD and SDIO Tegra architecture support Secure digital host controller interface (SDHCI) driver
lore
Share & tools
lore

Lucas Stach

author
#0 lore raw

PATCH 1/1 mmc: tegra: don't enable UHS modes on Tegra210

Tegra210 needs a different tuning sequence than Tegra30+. Disable UHS modes until support for this is properly added.

Signed-off-by Lucas Stach <[email protected]>

---
Ulf,
this is a follow on patch to my Tegra UHS-I series. After reading the Tegra210 TRM I realized that the currently implemented tuning sequence will only work on Tegra30..Tegra124. If you don't keep your tree stable you might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes, otherwise please pick this up as a fix on top.

---
 drivers/mmc/host/sdhci-tegra.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/mmc/host/sdhci-tegra.c +0 -3
index b5abbe2..83c4bf7 100644
@@ -353,9 +353,6 @@ static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
 
 static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
 	.pdata = &sdhci_tegra210_pdata,
-	.nvquirks = NVQUIRK_ENABLE_SDR50 |
-		    NVQUIRK_ENABLE_DDR50 |
-		    NVQUIRK_ENABLE_SDR104,
 };
 
 static const struct of_device_id sdhci_tegra_dt_match[] = {
Signature · 1 line
2.5.0

A message that is not in the archive (sent off-list or not yet received): 1451490549-21430-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org

Acked-by
#2 lore raw
Quoted 11 lines · Lucas Stach

Tegra210 needs a different tuning sequence than Tegra30+. Disable UHS modes until support for this is properly added.

Signed-off-by Lucas Stach <[email protected]>

---
Ulf,
this is a follow on patch to my Tegra UHS-I series. After reading the Tegra210 TRM I realized that the currently implemented tuning sequence will only work on Tegra30..Tegra124. If you don't keep your tree stable you might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes, otherwise please pick this up as a fix on top.

Quoted 3 lines
---
 drivers/mmc/host/sdhci-tegra.c | 3 ---
 1 file changed, 3 deletions(-)
Acked-by Thierry Reding <[email protected]>
#3 lore raw
In reply to Lucas Stach
Quoted 11 lines · Lucas Stach

Tegra210 needs a different tuning sequence than Tegra30+. Disable UHS modes until support for this is properly added.

Signed-off-by Lucas Stach <[email protected]>

---
Ulf,
this is a follow on patch to my Tegra UHS-I series. After reading the Tegra210 TRM I realized that the currently implemented tuning sequence will only work on Tegra30..Tegra124. If you don't keep your tree stable you might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes, otherwise please pick this up as a fix on top.

Thanks, I have squashed the change into patch4.

Kind regards
Uffe

Quoted 25 lines
---
 drivers/mmc/host/sdhci-tegra.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/mmc/host/sdhci-tegra.c +0 -4
index b5abbe2..83c4bf7 100644
@@ -353,9 +353,6 @@ static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
 
 static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
        .pdata = &sdhci_tegra210_pdata,
-       .nvquirks = NVQUIRK_ENABLE_SDR50 |
-                   NVQUIRK_ENABLE_DDR50 |
-                   NVQUIRK_ENABLE_SDR104,
 };
 
 static const struct of_device_id sdhci_tegra_dt_match[] = {
--

2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html