kvm: x86: fix comment about {mmu,nested_mmu}.gva_to_gpa
PATCH 1/1 kvm: x86: fix comment about {mmu,nested_mmu}.gva_to_gpa
The comment had the meaning of mmu.gva_to_gpa and nested_mmu.gva_to_gpa swapped. Fix that, and also add some details describing how each translation works.
Signed-off-by David Matlack <[email protected]>
--- arch/x86/kvm/mmu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
arch/x86/kvm/mmu.c +6 -4
@@ -4058,10 +4058,12 @@ static void init_kvm_nested_mmu(struct kvm_vcpu *vcpu) g_context->inject_page_fault = kvm_inject_page_fault;/* -* Note that arch.mmu.gva_to_gpa translates l2_gva to l1_gpa. The -* translation of l2_gpa to l1_gpa addresses is done using the -* arch.nested_mmu.gva_to_gpa function. Basically the gva_to_gpa -* functions between mmu and nested_mmu are swapped. +* Note that arch.mmu.gva_to_gpa translates l2_gpa to l1_gpa using +* L1's nested page tables (e.g. EPT12). The nested translation +* of l2_gva to l1_gpa is done by arch.nested_mmu.gva_to_gpa using +* L2's page tables as the first level of translation and L1's +* nested page tables as the second level of translation. Basically +* the gva_to_gpa functions between mmu and nested_mmu are swapped. */ if (!is_paging (vcpu)) { g_context->nx = false;
Signature · 1 line
2.6.0.rc2.230.g3dd15c0
Quoted 21 lines · David Matlack
The comment had the meaning of mmu.gva_to_gpa and nested_mmu.gva_to_gpa swapped. Fix that, and also add some details describing how each translation works.
Signed-off-by David Matlack <[email protected]>--- arch/x86/kvm/mmu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)arch/x86/kvm/mmu.c +0
-3@@ -4058,10 +4058,12 @@ static void init_kvm_nested_mmu(struct kvm_vcpu *vcpu) g_context->inject_page_fault = kvm_inject_page_fault;/* -* Note that arch.mmu.gva_to_gpa translates l2_gva to l1_gpa. The -* translation of l2_gpa to l1_gpa addresses is done using the -* arch.nested_mmu.gva_to_gpa function. Basically the gva_to_gpa
arch/x86/kvm/mmu.c static void init_kvm_nested_mmu(struct kvm_vcpu *vcpu) · line 4069
Quoted 10 lines
arch/x86/kvm/mmu.c +6
-1-* functions between mmu and nested_mmu are swapped. +* Note that arch.mmu.gva_to_gpa translates l2_gpa to l1_gpa using +* L1's nested page tables (e.g. EPT12). The nested translation +* of l2_gva to l1_gpa is done by arch.nested_mmu.gva_to_gpa using +* L2's page tables as the first level of translation and L1's +* nested page tables as the second level of translation. Basically +* the gva_to_gpa functions between mmu and nested_mmu are swapped. */ if (!is_paging (vcpu)) { g_context->nx = false;
Applied, thanks.
Paolo