doc: scheduler API deprecation notice
PATCH 1/1 doc: scheduler API deprecation notice
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
--- doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+)
doc/guides/rel_notes/deprecation.rst +7 -0
@@ -142,3 +142,10 @@ Deprecation Notices Python 2 support will be completely removed in 20.11. In 20.08, explicit deprecation warnings will be displayed when running scripts with Python 2. + +* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.
Signature · 1 line
2.25.1
27/07/2020 11:41, Adam Dybkowski:
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 151
Quoted 12 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
doc/guides/rel_notes/deprecation.rst +6
-0+* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.
Akhil Goyal
Acked-byQuoted 14 lines
27/07/2020 11:41, Adam Dybkowski:
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 151
Quoted 12 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
doc/guides/rel_notes/deprecation.rst +6
-0+* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.
Quoted 2 lines
Acked-by Thomas Monjalon <[email protected]>
I wonder how this patch got missed.
06/08/2020 19:18, Akhil Goyal:
Quoted 14 lines
Quoted 14 lines
27/07/2020 11:41, Adam Dybkowski:
Quoted 12 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
doc/guides/rel_notes/deprecation.rst +6
-0+* scheduler: The functions ``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in 20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.
Quoted 5 lines
Quoted 2 lines
Acked-by Thomas Monjalon <[email protected]>I wonder how this patch got missed.
Acked-by Akhil Goyal <[email protected]>
Sorry it is missing an ack.
I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil. This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
also shows it has 3 ACKs.
Can I ask why it didn't go into 20.08 then?
Adam
Quoted 36 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Saturday, 8 August, 2020 00:05
To: Dybkowski, AdamX <[email protected]>
Cc: [email protected]; Trahe, Fiona <[email protected]>; Zhang, Roy Fan <[email protected]>; [email protected]; Burakov, Anatoly <[email protected]>; [email protected]; Akhil Goyal <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice06/08/2020 19:18, Akhil Goyal:
Quoted 16 lines
Quoted 16 lines
27/07/2020 11:41, Adam Dybkowski:
Quoted 14 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
doc/guides/rel_notes/deprecation.rst +8
-0+* scheduler: The functions +``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in +20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.Quoted 5 lines
Quoted 2 lines
Acked-by Thomas Monjalon <[email protected]>I wonder how this patch got missed.
Acked-by Akhil Goyal <[email protected]>Sorry it is missing an ack.
10/08/2020 11:47, Dybkowski, AdamX:
Quoted 3 lines
I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil. This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
also shows it has 3 ACKs.
Sorry I missed initial ack.
Quoted 1 line
Can I ask why it didn't go into 20.08 then?
Because it was completed late, I missed and nobody replied.
In general, I would like more support in last days of release, to avoid such miss.
Quoted 25 lines
From: Thomas Monjalon <[email protected]>
Quoted 24 lines
06/08/2020 19:18, Akhil Goyal:
Quoted 16 lines
Quoted 16 lines
27/07/2020 11:41, Adam Dybkowski:
Quoted 14 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
doc/guides/rel_notes/deprecation.rst +8
-0+* scheduler: The functions +``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in +20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.Quoted 5 lines
Quoted 2 lines
Acked-by Thomas Monjalon <[email protected]>I wonder how this patch got missed.
Acked-by Akhil Goyal <[email protected]>Sorry it is missing an ack.
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even without the deprecation notice being in 20.08?
Quoted 52 lines
-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Monday, August 10, 2020 11:19 AM
To: Dybkowski, AdamX <[email protected]>
Cc: [email protected]; Trahe, Fiona <[email protected]>; Zhang, Roy Fan <[email protected]>; [email protected]; Burakov, Anatoly <[email protected]>; [email protected]; Akhil Goyal <[email protected]>; Richardson, Bruce <[email protected]>; Mcnamara, John <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice10/08/2020 11:47, Dybkowski, AdamX:
Quoted 3 lines
I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil. This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
also shows it has 3 ACKs.Sorry I missed initial ack.
Quoted 1 line
Can I ask why it didn't go into 20.08 then?
Because it was completed late, I missed and nobody replied.
In general, I would like more support in last days of release, to avoid such miss.
Quoted 25 lines
From: Thomas Monjalon <[email protected]>
Quoted 24 lines
06/08/2020 19:18, Akhil Goyal:
Quoted 16 lines
Quoted 16 lines
27/07/2020 11:41, Adam Dybkowski:
Quoted 14 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
doc/guides/rel_notes/deprecation.rst +8
-0+* scheduler: The functions +``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in +20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.Quoted 5 lines
Quoted 2 lines
Acked-by Thomas Monjalon <[email protected]>I wonder how this patch got missed.
Acked-by Akhil Goyal <[email protected]>Sorry it is missing an ack.
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even without the deprecation notice being in 20.08?
That's a question for techboard.
PS: please avoid top-posting
Quoted 45 lines
From: Thomas Monjalon <[email protected]>
Quoted 42 lines
10/08/2020 11:47, Dybkowski, AdamX:
Quoted 3 lines
I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil. This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
also shows it has 3 ACKs.Sorry I missed initial ack.
Quoted 1 line
Can I ask why it didn't go into 20.08 then?
Because it was completed late, I missed and nobody replied.
In general, I would like more support in last days of release, to avoid such miss.
Quoted 25 lines
From: Thomas Monjalon <[email protected]>
Quoted 24 lines
06/08/2020 19:18, Akhil Goyal:
Quoted 16 lines
Quoted 16 lines
27/07/2020 11:41, Adam Dybkowski:
Quoted 14 lines
This patch adds a deprecation notice about upcoming changes in public API of the Scheduler PMD.
Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fan Zhang <[email protected]>---
(quoted diff) +8
-0+* scheduler: The functions +``rte_cryptodev_scheduler_slave_attach``, + ``rte_cryptodev_scheduler_slave_detach`` and + ``rte_cryptodev_scheduler_slaves_get`` will be replaced in +20.11 by + ``rte_cryptodev_scheduler_worker_attach``, + ``rte_cryptodev_scheduler_worker_detach`` and + ``rte_cryptodev_scheduler_workers_get`` accordingly.Quoted 5 lines
Quoted 2 lines
Acked-by Thomas Monjalon <[email protected]>I wonder how this patch got missed.
Acked-by Akhil Goyal <[email protected]>Sorry it is missing an ack.
Quoted 11 lines · Thomas Monjalon
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even without the deprecation notice being in 20.08?
That's a question for techboard.
PS: please avoid top-posting
My initial 2c is that we should allow this, and add the required deprecation notice to the online docs immediately. I would assume most people use the online docs rather than building their own from the package, therefore adding in a deprecation notice to the online versions a few days after a release should not be a major problem IMHO.
Also, given the fact that we have once-a-year at most to apply ABI changes, and this is the first time we are going this, so I think a little latitude should be given! :-)
12/08/2020 11:52, Bruce Richardson:
Quoted 18 lines · Thomas Monjalon
Quoted 11 lines
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even without the deprecation notice being in 20.08?
That's a question for techboard.
PS: please avoid top-posting
My initial 2c is that we should allow this, and add the required deprecation notice to the online docs immediately. I would assume most people use the online docs rather than building their own from the package, therefore adding in a deprecation notice to the online versions a few days after a release should not be a major problem IMHO.
Quoted 3 lines
Also, given the fact that we have once-a-year at most to apply ABI changes, and this is the first time we are going this, so I think a little latitude should be given! :-)
I agree
We need more opinions from other techboard members to make it a decision.
Quoted 19 lines · Thomas Monjalon
12/08/2020 11:52, Bruce Richardson:
Quoted 18 lines · Thomas Monjalon
Quoted 11 lines
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even without the deprecation notice being in 20.08?
That's a question for techboard.
PS: please avoid top-posting
My initial 2c is that we should allow this, and add the required deprecation notice to the online docs immediately. I would assume most people use the online docs rather than building their own from the package, therefore adding in a deprecation notice to the online versions a few days after a release should not be a major problem IMHO.
Quoted 9 lines
Quoted 3 lines
Also, given the fact that we have once-a-year at most to apply ABI changes, and this is the first time we are going this, so I think a little latitude should be given! :-)
I agree
We need more opinions from other techboard members to make it a decision.
I agree too, let's give a bit more flexibility for the deprecation notice.
Maxime
Quoted 31 lines
-----Original Message-----
From: techboard <[email protected]> On Behalf Of Maxime CoquelinQuoted 8 lines · Thomas Monjalon
12/08/2020 11:52, Bruce Richardson:
Quoted 7 lines · Thomas Monjalon
Quoted 6 lines
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
without the deprecation notice being in 20.08?
Quoted 17 lines
Quoted 11 lines
Quoted 5 lines
That's a question for techboard.
PS: please avoid top-posting
My initial 2c is that we should allow this, and add the required deprecation notice to the online docs immediately. I would assume most people use the online docs rather than building their own from the package, therefore adding in a deprecation notice to the online versions a few days after a release should not be a major problem IMHO.
Quoted 3 lines
Also, given the fact that we have once-a-year at most to apply ABI changes, and this is the first time we are going this, so I think a little latitude should be given! :-)
I agree
Quoted 8 lines
Quoted 1 line
We need more opinions from other techboard members to make it a
decision.
Quoted 2 lines
I agree too, let's give a bit more flexibility for the deprecation notice.
Maxime
+1
Hemant
12/08/2020 12:57, Hemant Agrawal:
Quoted 36 lines
Quoted 36 lines
-----Original Message-----
From: techboard <[email protected]> On Behalf Of Maxime CoquelinQuoted 8 lines · Thomas Monjalon
12/08/2020 11:52, Bruce Richardson:
Quoted 7 lines · Thomas Monjalon
Quoted 6 lines
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
without the deprecation notice being in 20.08?
Quoted 11 lines
Quoted 11 lines
Quoted 5 lines
That's a question for techboard.
PS: please avoid top-posting
My initial 2c is that we should allow this, and add the required deprecation notice to the online docs immediately. I would assume most people use the online docs rather than building their own from the package, therefore adding in a deprecation notice to the online versions a few days after a release should not be a major problem IMHO.
Quoted 7 lines
Quoted 3 lines
Also, given the fact that we have once-a-year at most to apply ABI changes, and this is the first time we are going this, so I think a little latitude should be given! :-)
I agree
We need more opinions from other techboard members to make it a
decision.
Quoted 2 lines
Quoted 6 lines
Quoted 3 lines
I agree too, let's give a bit more flexibility for the deprecation notice.
Maxime
+1
Hemant
I've applied the patch after 20.11-rc0.
Quoted 37 lines · On Wed, 12 Aug 2020 14:23:51 +0200 Thomas Monjalon <[email protected]> wrote:
12/08/2020 12:57, Hemant Agrawal:
Quoted 36 lines
Quoted 36 lines
-----Original Message-----
From: techboard <[email protected]> On Behalf Of Maxime CoquelinQuoted 8 lines · Thomas Monjalon
12/08/2020 11:52, Bruce Richardson:
Quoted 7 lines · Thomas Monjalon
Quoted 6 lines
10/08/2020 13:49, Trahe, Fiona:
Quoted 5 lines
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are recommended and agreed throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
without the deprecation notice being in 20.08?
Quoted 11 lines
Quoted 11 lines
Quoted 5 lines
That's a question for techboard.
PS: please avoid top-posting
My initial 2c is that we should allow this, and add the required deprecation notice to the online docs immediately. I would assume most people use the online docs rather than building their own from the package, therefore adding in a deprecation notice to the online versions a few days after a release should not be a major problem IMHO.
Quoted 7 lines
Quoted 3 lines
Also, given the fact that we have once-a-year at most to apply ABI changes, and this is the first time we are going this, so I think a little latitude should be given! :-)
I agree
We need more opinions from other techboard members to make it a
decision.
Quoted 2 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
I agree too, let's give a bit more flexibility for the deprecation notice.
Maxime
+1
HemantI've applied the patch after 20.11-rc0.
I am ok with changing this for 20.11 since there aren't a lot of users of this subsystem and the change should be API compatiable