Skip to contentSkip to conversation

drm/i915/guc: Enable GuC submission, where supported

PATCH In review [email protected] 5 participants 11 messages Jan 5, 2016 – Feb 19, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/guc: Enable GuC submission, where supported

From: Alex Dai <[email protected]>

This is to enable command submission via GuC.

---
 drivers/gpu/drm/i915/i915_params.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_params.c +2 -2
index 8d90c25..2ca4690 100644
@@ -55,7 +55,7 @@ struct i915_params i915 __read_mostly = {
 	.verbose_state_checks = 1,
 	.nuclear_pageflip = 0,
 	.edp_vswing = 0,
-	.enable_guc_submission = false,
+	.enable_guc_submission = true,
 	.guc_log_level = -1,
 };
 
@@ -198,7 +198,7 @@ MODULE_PARM_DESC(edp_vswing,
 		 "2=default swing(400mV))");
 
 module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, bool, 0400);
-MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:false)");
+MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:true)");
 
 module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
 MODULE_PARM_DESC(guc_log_level,
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ failure: Fi.CI.BAT

== Summary ==

== Summary ==

Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly: 2016y-01m-06d-08h-16m-11s UTC integration manifest

Test drv_getparams_basic:

        Subgroup basic-eu-total:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-subslice-total:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test drv_hangman:
        Subgroup error-state-basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_basic:
        Subgroup bad-close:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup create-close:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup create-fd-close:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_cpu_reloc:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_ctx_create:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_ctx_exec:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_ctx_param_basic:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-default:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup invalid-ctx-get:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup invalid-ctx-set:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup invalid-param-get:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup invalid-param-set:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup invalid-size-get:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup invalid-size-set:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup non-root-set:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup non-root-set-no-zeromap:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup root-set:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup root-set-no-zeromap-disabled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup root-set-no-zeromap-enabled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_exec_parse:
        Subgroup basic-allowed:
                skip       -> DMESG-FAIL (skl-i5k-2)
                skip       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-rejected:
                skip       -> DMESG-FAIL (skl-i5k-2)
                skip       -> DMESG-FAIL (skl-i7k-2)
Test gem_flink_basic:
        Subgroup bad-flink:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-open:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup double-flink:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup flink-lifetime:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_linear_blits:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_mmap:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-small-bo:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_mmap_gtt:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-copy:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-read:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-read-no-prefault:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-read-write:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-read-write-distinct:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-short:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-small-bo:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-small-bo-tiledx:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-small-bo-tiledy:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-small-copy:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-small-copy-xy:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write-cpu-read-gtt:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write-gtt:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write-gtt-no-prefault:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write-no-prefault:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write-read:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-write-read-distinct:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_pread:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_pwrite:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_render_linear_blits:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_render_tiled_blits:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_storedw_loop:
        Subgroup basic-blt:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-bsd:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-render:
                dmesg-warn -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                pass       -> DMESG-WARN (bdw-nuci7) UNSTABLE
                pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
                dmesg-warn -> PASS       (bdw-ultra) UNSTABLE
        Subgroup basic-vebox:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_tiled_blits:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_tiled_fence_blits:
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_addfb_basic:
        Subgroup addfb25-bad-modifier:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-framebuffer-vs-set-tiling:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-modifier-no-flag:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-x-tiled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-x-tiled-mismatch:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-y-tiled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-y-tiled-small:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup addfb25-yf-tiled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-0:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-1024:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-128:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-256:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-32:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-63:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-65536:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pitch-999:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-x-tiled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-y-tiled:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bo-too-small:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bo-too-small-due-to-tiling:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup clobberred-modifier:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup framebuffer-vs-set-tiling:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup no-handle:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup size-max:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup small-bo:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup tile-pitch-mismatch:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup too-high:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup too-wide:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup unused-handle:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup unused-modifier:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup unused-offsets:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup unused-pitches:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-flip-vs-modeset:
                pass       -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
        Subgroup basic-plain-flip:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_force_connector_basic:
        Subgroup force-connector-state:
                skip       -> DMESG-FAIL (skl-i5k-2)
                skip       -> DMESG-FAIL (skl-i7k-2)
        Subgroup force-edid:
                skip       -> DMESG-FAIL (skl-i5k-2)
                skip       -> DMESG-FAIL (skl-i7k-2)
        Subgroup prune-stale-modes:
                skip       -> DMESG-FAIL (skl-i5k-2)
                skip       -> DMESG-FAIL (skl-i7k-2)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-1:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-nb-words-3:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-pipe:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup bad-source:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup hang-read-crc-pipe-a:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup hang-read-crc-pipe-b:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup hang-read-crc-pipe-c:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup read-crc-pipe-a:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
        Subgroup read-crc-pipe-a-frame-sequence:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup read-crc-pipe-b:
                pass       -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup read-crc-pipe-b-frame-sequence:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup read-crc-pipe-c:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup read-crc-pipe-c-frame-sequence:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> DMESG-FAIL (skl-i5k-2)
                dmesg-warn -> DMESG-FAIL (skl-i7k-2)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                skip       -> DMESG-FAIL (skl-i5k-2)
                skip       -> DMESG-FAIL (skl-i7k-2)
Test kms_setmode:
        Subgroup basic-clone-single-crtc:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-rte:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test pm_rps:
        Subgroup basic-api:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
Test prime_self_import:
        Subgroup basic-llseek-bad:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-llseek-size:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-with_fd_dup:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-with_one_bo:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-with_one_bo_two_files:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
        Subgroup basic-with_two_bos:
                pass       -> DMESG-FAIL (skl-i5k-2)
                pass       -> DMESG-FAIL (skl-i7k-2)
bdw-nuci7        total:132  pass:122  dwarn:1   dfail:0   fail:0   skip:9  
bdw-ultra        total:132  pass:126  dwarn:0   dfail:0   fail:0   skip:6  
bsw-nuc-2        total:135  pass:115  dwarn:0   dfail:0   fail:0   skip:20 
byt-nuc          total:135  pass:121  dwarn:1   dfail:0   fail:0   skip:13 
hsw-brixbox      total:135  pass:128  dwarn:0   dfail:0   fail:0   skip:7  
hsw-gt2          total:135  pass:131  dwarn:0   dfail:0   fail:0   skip:4  
ilk-hp8440p      total:135  pass:100  dwarn:0   dfail:0   fail:0   skip:35 
ivb-t430s        total:135  pass:129  dwarn:0   dfail:0   fail:0   skip:6  
skl-i5k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1  
skl-i7k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1  
snb-dellxps      total:135  pass:123  dwarn:0   dfail:0   fail:0   skip:12 
snb-x220t        total:135  pass:123  dwarn:0   dfail:0   fail:1   skip:11 

Results at /archive/results/CI_IGT_test/Patchwork_1094/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Re: ✗ failure: Fi.CI.BAT

Quoted 432 lines · Patchwork

== Summary ==

Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly: 2016y-01m-06d-08h-16m-11s UTC integration manifest

Test drv_getparams_basic:

         Subgroup basic-eu-total:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-subslice-total:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test drv_hangman:
         Subgroup error-state-basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_basic:
         Subgroup bad-close:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup create-close:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup create-fd-close:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_cpu_reloc:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_ctx_create:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_ctx_exec:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_ctx_param_basic:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-default:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup invalid-ctx-get:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup invalid-ctx-set:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup invalid-param-get:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup invalid-param-set:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup invalid-size-get:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup invalid-size-set:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup non-root-set:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup non-root-set-no-zeromap:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup root-set:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup root-set-no-zeromap-disabled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup root-set-no-zeromap-enabled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_exec_parse:
         Subgroup basic-allowed:
                 skip       -> DMESG-FAIL (skl-i5k-2)
                 skip       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-rejected:
                 skip       -> DMESG-FAIL (skl-i5k-2)
                 skip       -> DMESG-FAIL (skl-i7k-2)
Test gem_flink_basic:
         Subgroup bad-flink:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-open:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup double-flink:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup flink-lifetime:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_linear_blits:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_mmap:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-small-bo:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_mmap_gtt:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-copy:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-read:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-read-no-prefault:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-read-write:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-read-write-distinct:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-short:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-small-bo:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-small-bo-tiledx:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-small-bo-tiledy:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-small-copy:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-small-copy-xy:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write-cpu-read-gtt:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write-gtt:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write-gtt-no-prefault:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write-no-prefault:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write-read:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-write-read-distinct:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_pread:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_pwrite:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_render_linear_blits:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_render_tiled_blits:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_storedw_loop:
         Subgroup basic-blt:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-bsd:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-render:
                 dmesg-warn -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                 pass       -> DMESG-WARN (bdw-nuci7) UNSTABLE
                 pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
                 dmesg-warn -> PASS       (bdw-ultra) UNSTABLE
         Subgroup basic-vebox:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_tiled_blits:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test gem_tiled_fence_blits:
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_addfb_basic:
         Subgroup addfb25-bad-modifier:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-framebuffer-vs-set-tiling:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-modifier-no-flag:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-x-tiled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-x-tiled-mismatch:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-y-tiled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-y-tiled-small:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup addfb25-yf-tiled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-0:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-1024:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-128:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-256:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-32:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-63:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-65536:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pitch-999:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-x-tiled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-y-tiled:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bo-too-small:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bo-too-small-due-to-tiling:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup clobberred-modifier:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup framebuffer-vs-set-tiling:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup no-handle:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup size-max:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup small-bo:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup tile-pitch-mismatch:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup too-high:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup too-wide:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup unused-handle:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup unused-modifier:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup unused-offsets:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup unused-pitches:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_flip:
         Subgroup basic-flip-vs-dpms:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-flip-vs-modeset:
                 pass       -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                 pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
         Subgroup basic-flip-vs-wf_vblank:
                 pass       -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                 pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
         Subgroup basic-plain-flip:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_force_connector_basic:
         Subgroup force-connector-state:
                 skip       -> DMESG-FAIL (skl-i5k-2)
                 skip       -> DMESG-FAIL (skl-i7k-2)
         Subgroup force-edid:
                 skip       -> DMESG-FAIL (skl-i5k-2)
                 skip       -> DMESG-FAIL (skl-i7k-2)
         Subgroup prune-stale-modes:
                 skip       -> DMESG-FAIL (skl-i5k-2)
                 skip       -> DMESG-FAIL (skl-i7k-2)
Test kms_pipe_crc_basic:
         Subgroup bad-nb-words-1:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-nb-words-3:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-pipe:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup bad-source:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup hang-read-crc-pipe-a:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup hang-read-crc-pipe-b:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup hang-read-crc-pipe-c:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup read-crc-pipe-a:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2) UNSTABLE
         Subgroup read-crc-pipe-a-frame-sequence:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup read-crc-pipe-b:
                 pass       -> DMESG-FAIL (skl-i5k-2) UNSTABLE
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup read-crc-pipe-b-frame-sequence:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup read-crc-pipe-c:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup read-crc-pipe-c-frame-sequence:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup suspend-read-crc-pipe-a:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup suspend-read-crc-pipe-b:
                 dmesg-warn -> DMESG-FAIL (skl-i5k-2)
                 dmesg-warn -> DMESG-FAIL (skl-i7k-2)
         Subgroup suspend-read-crc-pipe-c:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test kms_psr_sink_crc:
         Subgroup psr_basic:
                 skip       -> DMESG-FAIL (skl-i5k-2)
                 skip       -> DMESG-FAIL (skl-i7k-2)
Test kms_setmode:
         Subgroup basic-clone-single-crtc:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test pm_rpm:
         Subgroup basic-pci-d3-state:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-rte:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test pm_rps:
         Subgroup basic-api:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
Test prime_self_import:
         Subgroup basic-llseek-bad:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-llseek-size:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-with_fd_dup:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-with_one_bo:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-with_one_bo_two_files:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
         Subgroup basic-with_two_bos:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)
bdw-nuci7        total:132  pass:122  dwarn:1   dfail:0   fail:0   skip:9
bdw-ultra        total:132  pass:126  dwarn:0   dfail:0   fail:0   skip:6
bsw-nuc-2        total:135  pass:115  dwarn:0   dfail:0   fail:0   skip:20
byt-nuc          total:135  pass:121  dwarn:1   dfail:0   fail:0   skip:13
hsw-brixbox      total:135  pass:128  dwarn:0   dfail:0   fail:0   skip:7
hsw-gt2          total:135  pass:131  dwarn:0   dfail:0   fail:0   skip:4
ilk-hp8440p      total:135  pass:100  dwarn:0   dfail:0   fail:0   skip:35
ivb-t430s        total:135  pass:129  dwarn:0   dfail:0   fail:0   skip:6
skl-i5k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
skl-i7k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
snb-dellxps      total:135  pass:123  dwarn:0   dfail:0   fail:0   skip:12
snb-x220t        total:135  pass:123  dwarn:0   dfail:0   fail:1   skip:11
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1094/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Looks like the CI SKL doesn't have the GuC firmware installed?

.Dave.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#3 lore raw

Re: ✗ failure: Fi.CI.BAT

Quoted 9 lines · Dave Gordon
Quoted 8 lines · Patchwork

== Summary ==

Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly: 2016y-01m-06d-08h-16m-11s UTC integration manifest

Test drv_getparams_basic:

         Subgroup basic-eu-total:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)

[snip]

Quoted 14 lines
Quoted 14 lines
bdw-nuci7        total:132  pass:122  dwarn:1   dfail:0   fail:0   skip:9
bdw-ultra        total:132  pass:126  dwarn:0   dfail:0   fail:0   skip:6
bsw-nuc-2        total:135  pass:115  dwarn:0   dfail:0   fail:0   skip:20
byt-nuc          total:135  pass:121  dwarn:1   dfail:0   fail:0   skip:13
hsw-brixbox      total:135  pass:128  dwarn:0   dfail:0   fail:0   skip:7
hsw-gt2          total:135  pass:131  dwarn:0   dfail:0   fail:0   skip:4
ilk-hp8440p      total:135  pass:100  dwarn:0   dfail:0   fail:0   skip:35
ivb-t430s        total:135  pass:129  dwarn:0   dfail:0   fail:0   skip:6
skl-i5k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
skl-i7k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
snb-dellxps      total:135  pass:123  dwarn:0   dfail:0   fail:0   skip:12
snb-x220t        total:135  pass:123  dwarn:0   dfail:0   fail:1   skip:11
Quoted 8 lines
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1094/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Looks like the CI SKL doesn't have the GuC firmware installed?

It's tons of:

[   38.169461] [drm:intel_lr_context_deferred_alloc [i915]] *ERROR* ring create req: -5

If that gets fixed by installing the GuC firmware, the answer is *not* to install the GuC firmware on the CI machines. The answer is to make the driver handle missing firmware gracefully.

BR,
Jani.

Quoted 7 lines

.Dave.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Re: ✗ failure: Fi.CI.BAT

Quoted 36 lines · Jani Nikula
Quoted 9 lines · Dave Gordon
Quoted 8 lines · Patchwork

== Summary ==

Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly: 2016y-01m-06d-08h-16m-11s UTC integration manifest

Test drv_getparams_basic:

         Subgroup basic-eu-total:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)

[snip]

Quoted 14 lines
Quoted 14 lines
bdw-nuci7        total:132  pass:122  dwarn:1   dfail:0   fail:0   skip:9
bdw-ultra        total:132  pass:126  dwarn:0   dfail:0   fail:0   skip:6
bsw-nuc-2        total:135  pass:115  dwarn:0   dfail:0   fail:0   skip:20
byt-nuc          total:135  pass:121  dwarn:1   dfail:0   fail:0   skip:13
hsw-brixbox      total:135  pass:128  dwarn:0   dfail:0   fail:0   skip:7
hsw-gt2          total:135  pass:131  dwarn:0   dfail:0   fail:0   skip:4
ilk-hp8440p      total:135  pass:100  dwarn:0   dfail:0   fail:0   skip:35
ivb-t430s        total:135  pass:129  dwarn:0   dfail:0   fail:0   skip:6
skl-i5k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
skl-i7k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
snb-dellxps      total:135  pass:123  dwarn:0   dfail:0   fail:0   skip:12
snb-x220t        total:135  pass:123  dwarn:0   dfail:0   fail:1   skip:11
Quoted 8 lines
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1094/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Looks like the CI SKL doesn't have the GuC firmware installed?

Quoted 7 lines

It's tons of:

[   38.169461] [drm:intel_lr_context_deferred_alloc [i915]] *ERROR* ring create req: -5

If that gets fixed by installing the GuC firmware, the answer is *not* to install the GuC firmware on the CI machines. The answer is to make the driver handle missing firmware gracefully.

I kinda don't want to support 2 different ways to run things on any given platform, because we can't even support one way properly.

But since it took forever to get guc enabled people will indeed scream if guc isn't there, so either we enable this only for bxt and later or we indeed need to support both cases on skl :(

Either way we do need to install guc firmware first on CI boxes, since otherwise coverage isn't there.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#5 lore raw

Re: ✗ failure: Fi.CI.BAT

Quoted 45 lines · Daniel Vetter
Quoted 36 lines · Jani Nikula
Quoted 9 lines · Dave Gordon
Quoted 8 lines · Patchwork

== Summary ==

Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly: 2016y-01m-06d-08h-16m-11s UTC integration manifest

Test drv_getparams_basic:

         Subgroup basic-eu-total:
                 pass       -> DMESG-FAIL (skl-i5k-2)
                 pass       -> DMESG-FAIL (skl-i7k-2)

[snip]

Quoted 14 lines
Quoted 14 lines
bdw-nuci7        total:132  pass:122  dwarn:1   dfail:0   fail:0   skip:9
bdw-ultra        total:132  pass:126  dwarn:0   dfail:0   fail:0   skip:6
bsw-nuc-2        total:135  pass:115  dwarn:0   dfail:0   fail:0   skip:20
byt-nuc          total:135  pass:121  dwarn:1   dfail:0   fail:0   skip:13
hsw-brixbox      total:135  pass:128  dwarn:0   dfail:0   fail:0   skip:7
hsw-gt2          total:135  pass:131  dwarn:0   dfail:0   fail:0   skip:4
ilk-hp8440p      total:135  pass:100  dwarn:0   dfail:0   fail:0   skip:35
ivb-t430s        total:135  pass:129  dwarn:0   dfail:0   fail:0   skip:6
skl-i5k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
skl-i7k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
snb-dellxps      total:135  pass:123  dwarn:0   dfail:0   fail:0   skip:12
snb-x220t        total:135  pass:123  dwarn:0   dfail:0   fail:1   skip:11
Quoted 8 lines
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1094/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Looks like the CI SKL doesn't have the GuC firmware installed?

Quoted 7 lines

It's tons of:

[   38.169461] [drm:intel_lr_context_deferred_alloc [i915]] *ERROR* ring create req: -5

If that gets fixed by installing the GuC firmware, the answer is *not* to install the GuC firmware on the CI machines. The answer is to make the driver handle missing firmware gracefully.

Quoted 6 lines

I kinda don't want to support 2 different ways to run things on any given platform, because we can't even support one way properly.

But since it took forever to get guc enabled people will indeed scream if guc isn't there, so either we enable this only for bxt and later or we indeed need to support both cases on skl :(

It's probably considered a regression to add a hard requirement on guc firmware now that skl has been running fine without. Yet we probably want all the coverage we can get for the guc case, so I don't think we should rely on bxt alone with that.

Quoted 2 lines

Either way we do need to install guc firmware first on CI boxes, since otherwise coverage isn't there.

How about having guc firmware on half the CI boxes, at least for starters. It's going to blow up anyway...

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

Re: ✗ failure: Fi.CI.BAT

In reply to Daniel Vetter
Quoted 45 lines · Daniel Vetter
Quoted 36 lines · Jani Nikula
Quoted 9 lines · Dave Gordon
Quoted 8 lines · Patchwork

== Summary ==

Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly: 2016y-01m-06d-08h-16m-11s UTC integration manifest

Test drv_getparams_basic:

          Subgroup basic-eu-total:
                  pass       -> DMESG-FAIL (skl-i5k-2)
                  pass       -> DMESG-FAIL (skl-i7k-2)

[snip]

Quoted 14 lines
Quoted 14 lines
bdw-nuci7        total:132  pass:122  dwarn:1   dfail:0   fail:0   skip:9
bdw-ultra        total:132  pass:126  dwarn:0   dfail:0   fail:0   skip:6
bsw-nuc-2        total:135  pass:115  dwarn:0   dfail:0   fail:0   skip:20
byt-nuc          total:135  pass:121  dwarn:1   dfail:0   fail:0   skip:13
hsw-brixbox      total:135  pass:128  dwarn:0   dfail:0   fail:0   skip:7
hsw-gt2          total:135  pass:131  dwarn:0   dfail:0   fail:0   skip:4
ilk-hp8440p      total:135  pass:100  dwarn:0   dfail:0   fail:0   skip:35
ivb-t430s        total:135  pass:129  dwarn:0   dfail:0   fail:0   skip:6
skl-i5k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
skl-i7k-2        total:135  pass:2    dwarn:0   dfail:132 fail:0   skip:1
snb-dellxps      total:135  pass:123  dwarn:0   dfail:0   fail:0   skip:12
snb-x220t        total:135  pass:123  dwarn:0   dfail:0   fail:1   skip:11
Quoted 8 lines
Quoted 6 lines

Results at /archive/results/CI_IGT_test/Patchwork_1094/

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Looks like the CI SKL doesn't have the GuC firmware installed?

Quoted 7 lines

It's tons of:

[   38.169461] [drm:intel_lr_context_deferred_alloc [i915]] *ERROR* ring create req: -5

If that gets fixed by installing the GuC firmware, the answer is *not* to install the GuC firmware on the CI machines. The answer is to make the driver handle missing firmware gracefully.

Quoted 6 lines

I kinda don't want to support 2 different ways to run things on any given platform, because we can't even support one way properly.

But since it took forever to get guc enabled people will indeed scream if guc isn't there, so either we enable this only for bxt and later or we indeed need to support both cases on skl :(

Yeah, we used to have that ability, until it was vetoed :( See <[email protected]> or
http://www.mail-archive.com/intel-gfx%40lists.freedesktop.org/msg63553.html

Quoted 3 lines

Either way we do need to install guc firmware first on CI boxes, since otherwise coverage isn't there.
-Daniel

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.BAT: success for drm/i915: add enable_guc_loading parameter

In reply to Jani Nikula
== Summary ==

== Summary ==

Series 3045v1 drm/i915: add enable_guc_loading parameter
http://patchwork.freedesktop.org/api/1.0/series/3045/revisions/1/mbox/

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (hsw-gt2)
bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12 
bsw-nuc-2        total:159  pass:131  dwarn:0   dfail:0   fail:0   skip:28 
byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23 
hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13 
hsw-gt2          total:159  pass:149  dwarn:0   dfail:0   fail:0   skip:10 
ilk-hp8440p      total:159  pass:111  dwarn:0   dfail:0   fail:0   skip:48 
ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14 
skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14 
snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22 
snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1353/

02932377a975a59ccd83095816d5b23183107d79 drm-intel-nightly: 2016y-02m-03d-01h-54m-27s UTC integration manifest 5715ac067feebdd0bf97b49d04023c677dc546d0 drm/i915: add enable_guc_loading parameter

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

PATCH 2/6 drm/i915/guc: Bypass fw loading gracefully if GuC is not supported

From: Alex Dai <[email protected]>

This is to rework previous patch:

commit 9f9e539f90bcecfdc7b3679d337b7a62d4313205

Author: Daniel Vetter <[email protected]>
Date:   Fri Oct 23 11:10:59 2015 +0200

drm/i915: Shut up GuC errors when it's disabled

There is the case where GuC loading is needed even GuC submission is disabled. For example, HuC loading and authentication require GuC to be loaded regardless. In this patch, driver will try to load the firmware only when it explicitly asks for that by specifying fw name and version. All other cases are considered as UC_FIRMWARE_NONE and the loading is bypassed silently.

---
 drivers/gpu/drm/i915/intel_guc_loader.c | 32 +++++++++++---------------------
 1 file changed, 11 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/intel_guc_loader.c +11 -21
index 70dbeb5..e11e1e8 100644
@@ -594,39 +594,29 @@ void intel_guc_ucode_init(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_uc_fw *guc_fw = &dev_priv->guc.guc_fw;
-	const char *fw_path;
+	const char *fw_path = NULL;
+
+	guc_fw->uc_dev = dev;
+	guc_fw->uc_fw_path = NULL;
+	guc_fw->fetch_status = UC_FIRMWARE_NONE;
+	guc_fw->load_status = UC_FIRMWARE_NONE;
 
 	if (!HAS_GUC_SCHED(dev))
 		i915.enable_guc_submission = false;
 
-	if (!HAS_GUC_UCODE(dev)) {
-		fw_path = NULL;
-	} else if (IS_SKYLAKE(dev)) {
+	if (!HAS_GUC_UCODE(dev))
+		return;
+
+	if (IS_SKYLAKE(dev)) {
 		fw_path = I915_SKL_GUC_UCODE;
 		guc_fw->major_ver_wanted = 4;
 		guc_fw->minor_ver_wanted = 3;
-	} else {
-		i915.enable_guc_submission = false;
-		fw_path = "";	/* unknown device */
 	}
 
-	if (!i915.enable_guc_submission)
-		return;
-
-	guc_fw->uc_dev = dev;
-	guc_fw->uc_fw_path = fw_path;
-	guc_fw->fetch_status = UC_FIRMWARE_NONE;
-	guc_fw->load_status = UC_FIRMWARE_NONE;
-
 	if (fw_path == NULL)
 		return;
 
-	if (*fw_path == '\0') {
-		DRM_ERROR("No GuC firmware known for this platform\n");
-		guc_fw->fetch_status = UC_FIRMWARE_FAIL;
-		return;
-	}
-
+	guc_fw->uc_fw_path = fw_path;
 	guc_fw->fetch_status = UC_FIRMWARE_PENDING;
 	DRM_DEBUG_DRIVER("GuC firmware pending, path %s\n", fw_path);
 	intel_uc_fw_fetch(dev, guc_fw);
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw

PATCH 1/1 drm/i915: add enable_guc_loading parameter

Split the function of "enable_guc_submission" into two separate options. The new one "enable_guc_loading" controls only the *fetching and loading* of the GuC firmware image. The existing one is redefined to control only the *use* of the GuC for batch submission once the firmware is loaded.

In addition, the degree of control has been refined from a simple bool to an integer key, allowing several options:

 -1  (default)    whatever the platform default is
  0  DISABLE      don't load/use the GuC
  1  BEST EFFORT  try to load/use the GuC, fallback if not available
  2  REQUIRE      must load/use the GuC, else leave the GPU wedged

The new platform default (as coded here) will be to attempt to load the GuC iff the device has a GuC that requires firmware, to attempt to use it iff the device has a GuC that supports the submission protocol (with or without firmware), and to fall back to execlist mode if any required firmware cannot be found or fails to load.

---
 drivers/gpu/drm/i915/i915_gem.c         |  1 -
 drivers/gpu/drm/i915/i915_params.c      | 14 ++++-
 drivers/gpu/drm/i915/i915_params.h      |  3 +-
 drivers/gpu/drm/i915/intel_guc_loader.c | 99 ++++++++++++++++++---------------
 4 files changed, 68 insertions(+), 49 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -1
index a928823..cd7aada 100644
@@ -4892,7 +4892,6 @@ int i915_gem_init_rings(struct drm_device *dev)
 		ret = intel_guc_ucode_load(dev);
 		if (ret) {
 			DRM_ERROR("Failed to initialize GuC, error %d\n", ret);
-			ret = -EIO;
 			goto out;
 		}
 	}
drivers/gpu/drm/i915/i915_params.c +11 -3
index 8b9f368..ad785ad 100644
@@ -55,7 +55,8 @@ struct i915_params i915 __read_mostly = {
 	.verbose_state_checks = 1,
 	.nuclear_pageflip = 0,
 	.edp_vswing = 0,
-	.enable_guc_submission = false,
+	.enable_guc_loading = -1,
+	.enable_guc_submission = -1,
 	.guc_log_level = -1,
 };
 
@@ -198,8 +199,15 @@ struct i915_params i915 __read_mostly = {
 		 "(0=use value from vbt [default], 1=low power swing(200mV),"
 		 "2=default swing(400mV))");
 
-module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, bool, 0400);
-MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:false)");
+module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
+MODULE_PARM_DESC(enable_guc_submission,
+		"Enable GuC firmware loading "
+		"(-1=auto [default], 0=never, 1=if available, 2=required)");
+
+module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
+MODULE_PARM_DESC(enable_guc_submission,
+		"Enable GuC submission "
+		"(-1=auto [default], 0=never, 1=if available, 2=required)");
 
 module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
 MODULE_PARM_DESC(guc_log_level,
drivers/gpu/drm/i915/i915_params.h +2 -1
index 5299290..7180261 100644
@@ -45,6 +45,8 @@ struct i915_params {
 	int enable_ips;
 	int invert_brightness;
 	int enable_cmd_parser;
+	int enable_guc_loading;
+	int enable_guc_submission;
 	int guc_log_level;
 	int use_mmio_flip;
 	int mmio_debug;
@@ -57,7 +59,6 @@ struct i915_params {
 	bool reset;
 	bool disable_display;
 	bool disable_vtd_wa;
-	bool enable_guc_submission;
 	bool verbose_state_checks;
 	bool nuclear_pageflip;
 };
drivers/gpu/drm/i915/intel_guc_loader.c +55 -44

150 lines not on this page · raw message

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author Reviewed-by on v1 1/1
#10 lore raw

Re: [PATCH] drm/i915: add enable_guc_loading parameter

LGTM.

Thanks,
Alex

Quoted 241 lines · Dave Gordon

Split the function of "enable_guc_submission" into two separate options. The new one "enable_guc_loading" controls only the *fetching and loading* of the GuC firmware image. The existing one is redefined to control only the *use* of the GuC for batch submission once the firmware is loaded.

In addition, the degree of control has been refined from a simple bool to an integer key, allowing several options:

  -1  (default)    whatever the platform default is
   0  DISABLE      don't load/use the GuC
   1  BEST EFFORT  try to load/use the GuC, fallback if not available
   2  REQUIRE      must load/use the GuC, else leave the GPU wedged

The new platform default (as coded here) will be to attempt to load the GuC iff the device has a GuC that requires firmware, to attempt to use it iff the device has a GuC that supports the submission protocol (with or without firmware), and to fall back to execlist mode if any required firmware cannot be found or fails to load.

---
  drivers/gpu/drm/i915/i915_gem.c         |  1 -
  drivers/gpu/drm/i915/i915_params.c      | 14 ++++-
  drivers/gpu/drm/i915/i915_params.h      |  3 +-
  drivers/gpu/drm/i915/intel_guc_loader.c | 99 ++++++++++++++++++---------------
  4 files changed, 68 insertions(+), 49 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -1
index a928823..cd7aada 100644
@@ -4892,7 +4892,6 @@ int i915_gem_init_rings(struct drm_device *dev)
  		ret = intel_guc_ucode_load(dev);
  		if (ret) {
  			DRM_ERROR("Failed to initialize GuC, error %d\n", ret);
-			ret = -EIO;
  			goto out;
  		}
  	}
drivers/gpu/drm/i915/i915_params.c +11 -3
index 8b9f368..ad785ad 100644
@@ -55,7 +55,8 @@ struct i915_params i915 __read_mostly = {
  	.verbose_state_checks = 1,
  	.nuclear_pageflip = 0,
  	.edp_vswing = 0,
-	.enable_guc_submission = false,
+	.enable_guc_loading = -1,
+	.enable_guc_submission = -1,
  	.guc_log_level = -1,
  };
 
@@ -198,8 +199,15 @@ struct i915_params i915 __read_mostly = {
  		 "(0=use value from vbt [default], 1=low power swing(200mV),"
  		 "2=default swing(400mV))");
 
-module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, bool, 0400);
-MODULE_PARM_DESC(enable_guc_submission, "Enable GuC submission (default:false)");
+module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
+MODULE_PARM_DESC(enable_guc_submission,
+		"Enable GuC firmware loading "
+		"(-1=auto [default], 0=never, 1=if available, 2=required)");
+
+module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
+MODULE_PARM_DESC(enable_guc_submission,
+		"Enable GuC submission "
+		"(-1=auto [default], 0=never, 1=if available, 2=required)");
 
  module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
  MODULE_PARM_DESC(guc_log_level,
drivers/gpu/drm/i915/i915_params.h +2 -1
index 5299290..7180261 100644
@@ -45,6 +45,8 @@ struct i915_params {
  	int enable_ips;
  	int invert_brightness;
  	int enable_cmd_parser;
+	int enable_guc_loading;
+	int enable_guc_submission;
  	int guc_log_level;
  	int use_mmio_flip;
  	int mmio_debug;
@@ -57,7 +59,6 @@ struct i915_params {
  	bool reset;
  	bool disable_display;
  	bool disable_vtd_wa;
-	bool enable_guc_submission;
  	bool verbose_state_checks;
  	bool nuclear_pageflip;
  };
drivers/gpu/drm/i915/intel_guc_loader.c +54 -39
index 3accd91..e7eb3db 100644
@@ -369,49 +369,37 @@ int intel_guc_ucode_load(struct drm_device *dev)
  {
  	struct drm_i915_private *dev_priv = dev->dev_private;
  	struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw;
+	const char *fw_path = guc_fw->guc_fw_path;
  	int err = 0;
 
-	if (!i915.enable_guc_submission)
-		return 0;
-
-	DRM_DEBUG_DRIVER("GuC fw status: fetch %s, load %s\n",
+	DRM_DEBUG_DRIVER("GuC fw status: path %s, fetch %s, load %s\n",
+		fw_path,
  		intel_guc_fw_status_repr(guc_fw->guc_fw_fetch_status),
  		intel_guc_fw_status_repr(guc_fw->guc_fw_load_status));
 
-	direct_interrupts_to_host(dev_priv);
+	/* Loading forbidden, or no firmware to load? */
+	if (!i915.enable_guc_loading)
+		goto fail;
+	if (fw_path == NULL)
+		goto fail;
+	if (*fw_path == '\0') {
+		DRM_ERROR("No GuC firmware known for this platform\n");
+		goto fail;
+	}
 
-	if (guc_fw->guc_fw_fetch_status == GUC_FIRMWARE_NONE)
-		return 0;
+	/* Fetch failed, or already fetched but failed to load? */
+	if (guc_fw->guc_fw_fetch_status != GUC_FIRMWARE_SUCCESS)
+		goto fail;
+	if (guc_fw->guc_fw_load_status == GUC_FIRMWARE_FAIL)
+		goto fail;
 
-	if (guc_fw->guc_fw_fetch_status == GUC_FIRMWARE_SUCCESS &&
-	    guc_fw->guc_fw_load_status == GUC_FIRMWARE_FAIL)
-		return -ENOEXEC;
+	direct_interrupts_to_host(dev_priv);
 
  	guc_fw->guc_fw_load_status = GUC_FIRMWARE_PENDING;
 
-	DRM_DEBUG_DRIVER("GuC fw fetch status %s\n",
-		intel_guc_fw_status_repr(guc_fw->guc_fw_fetch_status));
-
-	switch (guc_fw->guc_fw_fetch_status) {
-	case GUC_FIRMWARE_FAIL:
-		/* something went wrong :( */
-		err = -EIO;
-		goto fail;
-
-	case GUC_FIRMWARE_NONE:
-	case GUC_FIRMWARE_PENDING:
-	default:
-		/* "can't happen" */
-		WARN_ONCE(1, "GuC fw %s invalid guc_fw_fetch_status %s [%d]\n",
-			guc_fw->guc_fw_path,
-			intel_guc_fw_status_repr(guc_fw->guc_fw_fetch_status),
-			guc_fw->guc_fw_fetch_status);
-		err = -ENXIO;
-		goto fail;
-
-	case GUC_FIRMWARE_SUCCESS:
-		break;
-	}
+	DRM_DEBUG_DRIVER("GuC fw status: fetch %s, load %s\n",
+		intel_guc_fw_status_repr(guc_fw->guc_fw_fetch_status),
+		intel_guc_fw_status_repr(guc_fw->guc_fw_load_status));
 
  	err = i915_guc_submission_init(dev);
  	if (err)
@@ -440,6 +428,8 @@ int intel_guc_ucode_load(struct drm_device *dev)
  	return 0;
 
  fail:
+	DRM_DEBUG_DRIVER("GuC firmware load fail, err %d\n", err);
+
  	if (guc_fw->guc_fw_load_status == GUC_FIRMWARE_PENDING)
  		guc_fw->guc_fw_load_status = GUC_FIRMWARE_FAIL;
 
@@ -447,6 +437,29 @@ int intel_guc_ucode_load(struct drm_device *dev)
  	i915_guc_submission_disable(dev);
  	i915_guc_submission_fini(dev);
 
+	/*
+	 * We've failed to load the firmware :(
+	 *
+	 * Decide whether to disable GuC submission and fall back to
+	 * execlist mode, and whether to hide the error by returning
+	 * zero or to return -EIO, which the caller will treat as a
+	 * nonfatal error (i.e. it doesn't prevent driver load, but
+	 * marks the GPU as wedged until reset).
+	 */
+	if (i915.enable_guc_loading > 1) {
+		err = -EIO;
+	} else if (HAS_GUC_SCHED(dev) && !HAS_GUC_UCODE(dev)) {
+		return 0;
+	} else if (i915.enable_guc_submission > 1) {
+		err = -EIO;
+	} else {
+		err = 0;
+	}
+
+	i915.enable_guc_submission = 0;
+
+	DRM_DEBUG_DRIVER("falling back to execlist mode, err %d\n", err);
+
  	return err;
  }
 
@@ -588,8 +601,11 @@ void intel_guc_ucode_init(struct drm_device *dev)
  	struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw;
  	const char *fw_path;
 
-	if (!HAS_GUC_SCHED(dev))
-		i915.enable_guc_submission = false;
+	/* A negative value means "use platform default" */
+	if (i915.enable_guc_loading < 0)
+		i915.enable_guc_loading = HAS_GUC_UCODE(dev);
+	if (i915.enable_guc_submission < 0)
+		i915.enable_guc_submission = HAS_GUC_SCHED(dev);
 
  	if (!HAS_GUC_UCODE(dev)) {
  		fw_path = NULL;
@@ -598,26 +614,21 @@ void intel_guc_ucode_init(struct drm_device *dev)
  		guc_fw->guc_fw_major_wanted = 4;
  		guc_fw->guc_fw_minor_wanted = 3;
  	} else {
-		i915.enable_guc_submission = false;
  		fw_path = "";	/* unknown device */
  	}
 
-	if (!i915.enable_guc_submission)
-		return;
-
  	guc_fw->guc_dev = dev;
  	guc_fw->guc_fw_path = fw_path;
  	guc_fw->guc_fw_fetch_status = GUC_FIRMWARE_NONE;
  	guc_fw->guc_fw_load_status = GUC_FIRMWARE_NONE;
 
+	/* Early (and silent) return if GuC loading is disabled */
+	if (!i915.enable_guc_loading)
+		return;
  	if (fw_path == NULL)
  		return;

drivers/gpu/drm/i915/intel_guc_loader.c void intel_guc_ucode_init(struct drm_device *dev) · line 634

Quoted 10 lines
drivers/gpu/drm/i915/intel_guc_loader.c +1 -5
-
-	if (*fw_path == '\0') {
-		DRM_ERROR("No GuC firmware known for this platform\n");
-		guc_fw->guc_fw_fetch_status = GUC_FIRMWARE_FAIL;
+	if (*fw_path == '\0')
  		return;
-	}
 
  	guc_fw->guc_fw_fetch_status = GUC_FIRMWARE_PENDING;
  	DRM_DEBUG_DRIVER("GuC firmware pending, path %s\n", fw_path);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx