drm/i915: reduce memory footprint for debugging
Subsystems (2)
PATCH 1/1 drm/i915: reduce memory footprint for debugging
see df8fbc231b7e4a78dae2b02e116fe73e4ea63cb0
Signed-off-by Stefan Brüns <[email protected]>
--- drivers/gpu/drm/i915/intel_dp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -5
@@ -3322,15 +3322,12 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)struct drm_device *dev = dig_port->base.base.dev;struct drm_i915_private *dev_priv = dev->dev_private; -char dpcd_hex_dump[sizeof (intel_dp->dpcd) *3 ]; -if (intel_dp_dpcd_read_wake (&intel_dp->aux,0x000 , intel_dp->dpcd,sizeof (intel_dp->dpcd)) <0 )return false;/* aux transfer failed */ -hex_dump_to_buffer (intel_dp->dpcd,sizeof (intel_dp->dpcd), -32 ,1 , dpcd_hex_dump,sizeof (dpcd_hex_dump), false); -DRM_DEBUG_KMS ("DPCD: %s\n" , dpcd_hex_dump); +DRM_DEBUG_KMS ("DPCD: %*ph\n" , (int )sizeof (intel_dp->dpcd), + dig_connector->dpcd);if (intel_dp->dpcd[DP_DPCD_REV ] ==0 )return false;/* DPCD not present */
Signature · 7 lines
1.8.4.5 -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424
Jani Nikula
maintainerQuoted 1 line · Stefan Brüns
see
df8fbc231b7e4a78dae2b02e116fe73e4ea63cb0
Andy beat you to it with
commit a8e98153627dfbb10ff4dd65729676115a932b2e
Author: Andy Shevchenko <[email protected]> Date: Mon Sep 1 14:12:01 2014 +0300
drm: i915: reduce memory footprint when debugging
on its way upstream.
Thanks anyway.
BR,
Jani.
Quoted 40 lines
Signed-off-by Stefan Brüns <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_dp.c +2
-5@@ -3322,15 +3322,12 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)struct drm_device *dev = dig_port->base.base.dev;struct drm_i915_private *dev_priv = dev->dev_private; -char dpcd_hex_dump[sizeof (intel_dp->dpcd) *3 ]; -if (intel_dp_dpcd_read_wake (&intel_dp->aux,0x000 , intel_dp->dpcd,sizeof (intel_dp->dpcd)) <0 )return false;/* aux transfer failed */ -hex_dump_to_buffer (intel_dp->dpcd,sizeof (intel_dp->dpcd), -32 ,1 , dpcd_hex_dump,sizeof (dpcd_hex_dump), false); -DRM_DEBUG_KMS ("DPCD: %s\n" , dpcd_hex_dump); +DRM_DEBUG_KMS ("DPCD: %*ph\n" , (int )sizeof (intel_dp->dpcd), + dig_connector->dpcd);if (intel_dp->dpcd[DP_DPCD_REV ] ==0 )return false;/* DPCD not present */ Signature · 11 lines
1.8.4.5 -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Stefan Brüns
see
df8fbc231b7e4a78dae2b02e116fe73e4ea63cb0Signed-off-by Stefan Brüns <[email protected]>
I already have such a patch:
commit a8e98153627dfbb10ff4dd65729676115a932b2e
Author: Andy Shevchenko <[email protected]> Date: Mon Sep 1 14:12:01 2014 +0300
drm: i915: reduce memory footprint when debugging
Please check linux-next before doing such cleanup patches next time around.
Thanks, Daniel
Quoted 38 lines
--- drivers/gpu/drm/i915/intel_dp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_dp.c +2
-5@@ -3322,15 +3322,12 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)struct drm_device *dev = dig_port->base.base.dev;struct drm_i915_private *dev_priv = dev->dev_private; -char dpcd_hex_dump[sizeof (intel_dp->dpcd) *3 ]; -if (intel_dp_dpcd_read_wake (&intel_dp->aux,0x000 , intel_dp->dpcd,sizeof (intel_dp->dpcd)) <0 )return false;/* aux transfer failed */ -hex_dump_to_buffer (intel_dp->dpcd,sizeof (intel_dp->dpcd), -32 ,1 , dpcd_hex_dump,sizeof (dpcd_hex_dump), false); -DRM_DEBUG_KMS ("DPCD: %s\n" , dpcd_hex_dump); +DRM_DEBUG_KMS ("DPCD: %*ph\n" , (int )sizeof (intel_dp->dpcd), + dig_connector->dpcd);if (intel_dp->dpcd[DP_DPCD_REV ] ==0 )return false;/* DPCD not present */ Signature · 11 lines
1.8.4.5 -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch