deadline: remove unused struct member
PATCH 1/1 deadline: remove unused struct member
commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched:
allow non-sequential batching") removed last use of last_sector.
--- block/deadline-iosched.c | 3 --- 1 file changed, 3 deletions(-)
block/deadline-iosched.c +0 -3
@@ -39,7 +39,6 @@ struct deadline_data {*/ struct request *next_rq[2 ];unsigned int batching;/* number of sequential requests made */ -sector_t last_sector;/* head position */ unsigned int starved;/* times reads have starved writes */ /*
@@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq) dd->next_rq[WRITE ] =NULL ; dd->next_rq[data_dir] =deadline_latter_request (rq); - dd->last_sector =rq_end_sector (rq); -/* * take it off the sort and fifo list, move * to dispatch queue
Signature · 1 line
2.6.0.rc2.230.g3dd15c0
Ping?
Quoted 32 lines · Tahsin Erdogan
commit
63de428b139d3d31d86ebe25ae97b33f6540fb7e("deadline-iosched:
allow non-sequential batching") removed last use oflast_sector.Signed-off-by Tahsin Erdogan <[email protected]>--- block/deadline-iosched.c | 3 --- 1 file changed, 3 deletions(-)block/deadline-iosched.c +0
-4@@ -39,7 +39,6 @@ struct deadline_data {*/ struct request *next_rq[2 ];unsigned int batching;/* number of sequential requests made */ -sector_t last_sector;/* head position */ unsigned int starved;/* times reads have starved writes */ /* @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq) dd->next_rq[WRITE ] =NULL ; dd->next_rq[data_dir] =deadline_latter_request (rq); - dd->last_sector =rq_end_sector (rq); -/* * take it off the sort and fifo list, move * to dispatch queue -- 2.6.0.rc2.230.g3dd15c0
Jeff Moyer
Reviewed-byQuoted 1 line · Tahsin Erdogan
Ping?
Yeah, commit 63de428b139d3 (deadline-iosched: allow non-sequential batching) removed the use of last_sector, and should have removed the structure member as well (way back in 2008).
Quoted 37 lines · Tahsin Erdogan
Quoted 30 lines
commit
63de428b139d3d31d86ebe25ae97b33f6540fb7e("deadline-iosched:
allow non-sequential batching") removed last use oflast_sector.Signed-off-by Tahsin Erdogan <[email protected]>--- block/deadline-iosched.c | 3 --- 1 file changed, 3 deletions(-)block/deadline-iosched.c +0
-4@@ -39,7 +39,6 @@ struct deadline_data {*/ struct request *next_rq[2 ];unsigned int batching;/* number of sequential requests made */ -sector_t last_sector;/* head position */ unsigned int starved;/* times reads have starved writes */ /* @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq) dd->next_rq[WRITE ] =NULL ; dd->next_rq[data_dir] =deadline_latter_request (rq); - dd->last_sector =rq_end_sector (rq); -/* * take it off the sort and fifo list, move * to dispatch queue -- Quoted 2 lines
2.6.0.rc2.230.g3dd15c0
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jens Axboe
maintainerQuoted 7 lines · Jeff Moyer
Quoted 1 line · Tahsin Erdogan
Ping?
Yeah, commit
63de428b139d3(deadline-iosched: allow non-sequential batching) removed the use oflast_sector, and should have removed the structure member as well (way back in 2008).
Heh, just 8 years! Thanks Tahsin, applied.
Signature · 1 line
Jens Axboe