Skip to contentSkip to conversation

Clarify --block-outside-dns documentation

PATCH Superseded ValdikSS 2 participants 3 messages Jan 15, 2016 – Jan 16, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

ValdikSS

author
#0 lore raw

PATCH 1/1 Clarify --block-outside-dns documentation

---
 doc/openvpn.8 | 9 +++++++++
 1 file changed, 9 insertions(+)
doc/openvpn.8 +9 -0
index ef77b29..a276936 100644
@@ -5575,6 +5575,15 @@ DNS leaks. This option prevents any application from accessing
 TCP or UDP port 53 except one inside the tunnel. It uses
 Windows Filtering Platform (WFP) and works on Windows Vista or
 later.
+
+This option is considered unknown on non-Windows platforms
+and unsupported versions (Windows XP), resulting in fatal
+error. You may want to use
+.B \-\-setenv opt
+or
+.B \-\-ignore\-unknown\-option
+to ignore said error. Note that pushing unknown options
+from server does not trigger fatal errors.
 .\"*********************************************************
 .TP
 .B \-\-dhcp\-renew
Signature · 1 line
2.7.0
#1 lore raw

Hi,

Quoted 4 lines · ValdikSS
doc/openvpn.8 +0 -0
@@ -5575,6 +5575,15 @@ DNS leaks. This option prevents any application from accessing
 TCP or UDP port 53 except one inside the tunnel. It uses
 Windows Filtering Platform (WFP) and works on Windows Vista or
 later.

doc/openvpn.8 DNS leaks. This option prevents any application from accessing · line 5587

Quoted 10 lines
doc/openvpn.8 +9 -0
+
+This option is considered unknown on non-Windows platforms
+and unsupported versions (Windows XP), resulting in fatal
+error. You may want to use
+.B \-\-setenv opt
+or
+.B \-\-ignore\-unknown\-option
+to ignore said error. Note that pushing unknown options
+from server does not trigger fatal errors.
 .\"*********************************************************

While I agree with the idea (and this is a frequent question, so thanks!), it's not totally correct for Windows XP - with the Fish patch, it actually is *not* an "unknown option", it will "just fail".

--setenv opt block-outside-dns

will handle that (because it will change the message level before running the option processor, so it does not matter if the option is unknown or fails to initialize), but --ignore-unknown-option will not work on XP - it is not "unknown", so that code path does not apply.

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
author
#2 lore raw

You're right, thanks.
Sent v2 of this patch.

Quoted 29 lines · Gert Doering

Hi,

On Sat, Jan 16, 2016 at 02:45:05AM +0300, ValdikSS wrote:
While I agree with the idea (and this is a frequent question, so thanks!), it's not totally correct for Windows XP - with the Fish patch, it actually is *not* an "unknown option", it will "just fail".

--setenv opt block-outside-dns

will handle that (because it will change the message level before running the option processor, so it does not matter if the option is unknown or fails to initialize), but --ignore-unknown-option will not work on XP - it is not "unknown", so that code path does not apply.

gert

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel