Skip to contentSkip to conversation

Patch "pptp: verify sockaddr_len in pptp_bind() and pptp_connect()" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Jan 19, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pptp: verify sockaddr_len in pptp_bind() and pptp_connect()

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pptp-verify-sockaddr_len-in-pptp_bind-and-pptp_connect.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jan 18 21:18:36 PST 2016

From: WANG Cong <[email protected]>
Date: Mon, 14 Dec 2015 13:48:36 -0800
Subject: pptp: verify sockaddr_len in pptp_bind() and pptp_connect()
Status: RO
Content-Length: 993
Lines: 36

From: WANG Cong <[email protected]>

[ Upstream commit 09ccfd238e5a0e670d8178cf50180ea81ae09ae1 ]

---
 drivers/net/ppp/pptp.c |    6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ppp/pptp.c +6 -0
@@ -420,6 +420,9 @@ static int pptp_bind(struct socket *sock
 	struct pptp_opt *opt = &po->proto.pptp;
 	int error = 0;
 
+	if (sockaddr_len < sizeof(struct sockaddr_pppox))
+		return -EINVAL;
+
 	lock_sock(sk);
 
 	opt->src_addr = sp->sa_addr.pptp;
@@ -441,6 +444,9 @@ static int pptp_connect(struct socket *s
 	struct flowi4 fl4;
 	int error = 0;
 
+	if (sockaddr_len < sizeof(struct sockaddr_pppox))
+		return -EINVAL;
+
 	if (sp->sa_protocol != PX_PROTO_PPTP)
 		return -EINVAL;
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/pptp-verify-sockaddr_len-in-pptp_bind-and-pptp_connect.patch