net: add support for phy speed limitation

From: Florian Fainelli <[email protected]>

When a Gigabit PHY device is connected to a 10/100Mbits capable Ethernet MAC, the driver will restrict the phydev->supported modes to mask off Gigabit. If the Gigabit PHY comes out of reset with the Gigabit features set by default in MII_CTRL1000, it will keep advertising these feature, so by the time we call genphy_config_advert(), the condition on phydev->supported having the Gigabit features on is false, and we do not update MII_CTRL1000 with updated values, and we keep advertising Gigabit features, eventually configuring the PHY for Gigabit whilst the Ethernet MAC does not support that.

This patches fixes the problem by ensuring that the Gigabit feature bits are always cleared in MII_CTRL1000, if the PHY happens to be a Gigabit PHY, and then, if Gigabit features are supported, setting those and updating MII_CTRL1000 accordingly.

This is a copy of patch from Linux kernel, see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5273e3a5ca94fbeb8e07d31203069220d5e682aa

Signed-off-by Florian Fainelli <[email protected]>

Signed-off-by Alexey Brodkin <[email protected]>

Cc Joe Hershberger <[email protected]>

---

From: Sascha Hauer <[email protected]>

of_set_phy_supported allows overwiting hardware capabilities of a phy with values from the devicetree. This does not work with the genphy driver though because the genphys config_init function will overwrite all values adjusted by of_set_phy_supported. Fix this by initialising the genphy features in the phy_driver struct and in config_init just limit the features to the ones the hardware can actually support. The resulting features are a subset of the devicetree specified features and the hardware features.

This is a copy of the patch from Linux kernel, see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c242a47238fa2a6a54af8a16e62b54e6e031d4bc

Signed-off-by Sascha Hauer <[email protected]>

Signed-off-by Alexey Brodkin <[email protected]>

Cc Joe Hershberger <[email protected]>

From: Florian Fainelli <[email protected]>

Breakdown the PHY_*_FEATURES into per speed defines such that we can easily re-use them individually.

Signed-off-by Florian Fainelli <[email protected]>

Signed-off-by Alexey Brodkin <[email protected]>

Cc Joe Hershberger <[email protected]>

This new function will allow MAC drivers to override supported capabilities of the phy. It is required when MAC cannot handle all speeds supported by phy.

For example phy supports up-to 1Gb connections while MAC may only work in modes up to 100 or even 10 Mbit/sec.

Signed-off-by Alexey Brodkin <[email protected]>

Cc Joe Hershberger <[email protected]>

This will be used for getting max speed mode of Ethernet interface that a particular MAC supports from Device Tree blob and later being used for phy configuration.

Signed-off-by Alexey Brodkin <[email protected]>

Cc Joe Hershberger <[email protected]>

Current implementation only sets "port select" bit for non-1Gb mode. That works fine if GMAC has just exited reset state but we may as well change connection mode in runtime. Then we'll need to reprogram GMAC for that new mode of operation and if previous mode was 10 or 100 Mb and new one is 1 Gb we'll need to reset port mode bit.

Signed-off-by Alexey Brodkin <[email protected]>

Cc Bin Meng <[email protected]>

Cc Joe Hershberger <[email protected]>

Cc Sonic Zhang <[email protected]>

cc Simon Glass <[email protected]>

This property allows to specify fastest connection mode supported by the MAC (as opposed to features of the phy).

There are situations when phy may handle faster modes than the MAC (or even it's particular implementation or even due to CPU being too slow).

This property is a standard one in Linux kernel these days and some boards do already use it in their device tree descriptions.

Signed-off-by Alexey Brodkin <[email protected]>

Cc Bin Meng <[email protected]>

Cc Joe Hershberger <[email protected]>

Cc Sonic Zhang <[email protected]>

cc Simon Glass <[email protected]>

In some cases Ethernet PHY and network itself might support speeds which are not supported by Ethernet controller (MAC).

To support that kind of situation it is required to force limit PHY so it is not configured for unsupported mode or even if PHY autonegotiated too high speed it will be reconfigured for slower mode.

Note this series is v2 because v1 patches were sent separately not being aranged in series. And now I'm putting all patches in one series and marking it v2 even though no changes were done in patches itself.

Alexey Brodkin (4):
drivers/net/phy: introduce phy_set_supported() include/net.h: add max_speed member in struct eth_pdata net/designware: do explicit port selection for 1Gb mode net/designware: add support of max-speed device tree property

Florian Fainelli (2):
net: phy: ensure Gigabit features are masked off if requested
net: phy: breakdown PHY_*_FEATURES defines

Sascha Hauer (1):
net: phy: genphy: Allow overwriting features

 drivers/net/designware.c | 16 +++++++++-
 drivers/net/designware.h |  1 +
 drivers/net/phy/phy.c    | 77 ++++++++++++++++++++++++++++++++++--------------
 include/net.h            |  2 ++
 include/phy.h            | 23 ++++++++++-----
 5 files changed, 89 insertions(+), 30 deletions(-)

Hi Joe,

Quoted 24 lines · Alexey Brodkin

In some cases Ethernet PHY and network itself might support speeds which are not supported by Ethernet controller (MAC).

To support that kind of situation it is required to force limit PHY so it is not configured for unsupported mode or even if PHY autonegotiated too high speed it will be reconfigured for slower mode.

Note this series is v2 because v1 patches were sent separately not being aranged in series. And now I'm putting all patches in one series and marking it v2 even though no changes were done in patches itself.

Alexey Brodkin (4):
drivers/net/phy: introduce phy_set_supported() include/net.h: add max_speed member in struct eth_pdata net/designware: do explicit port selection for 1Gb mode net/designware: add support of max-speed device tree property

Florian Fainelli (2):
net: phy: ensure Gigabit features are masked off if requested
net: phy: breakdown PHY_*_FEATURES defines

Sascha Hauer (1):
net: phy: genphy: Allow overwriting features

Quoted 6 lines

 drivers/net/designware.c | 16 +++++++++-
 drivers/net/designware.h |  1 +
 drivers/net/phy/phy.c    | 77 ++++++++++++++++++++++++++++++++++--------------
 include/net.h            |  2 ++
 include/phy.h            | 23 ++++++++++-----
 5 files changed, 89 insertions(+), 30 deletions(-)

Please treat this as a polite reminder to review
that series sometime soon.

Hi Joe,

Quoted 34 lines · Alexey Brodkin

Hi Joe,

Quoted 30 lines · Alexey Brodkin

In some cases Ethernet PHY and network itself might support speeds which are not supported by Ethernet controller (MAC).

To support that kind of situation it is required to force limit PHY so it is not configured for unsupported mode or even if PHY autonegotiated too high speed it will be reconfigured for slower mode.

Note this series is v2 because v1 patches were sent separately not being aranged in series. And now I'm putting all patches in one series and marking it v2 even though no changes were done in patches itself.

Alexey Brodkin (4):
drivers/net/phy: introduce phy_set_supported() include/net.h: add max_speed member in struct eth_pdata net/designware: do explicit port selection for 1Gb mode net/designware: add support of max-speed device tree property

Florian Fainelli (2):
net: phy: ensure Gigabit features are masked off if requested
net: phy: breakdown PHY_*_FEATURES defines

Sascha Hauer (1):
net: phy: genphy: Allow overwriting features

 drivers/net/designware.c | 16 +++++++++-
 drivers/net/designware.h |  1 +
 drivers/net/phy/phy.c    | 77 ++++++++++++++++++++++++++++++++++--------------
 include/net.h            |  2 ++
 include/phy.h            | 23 ++++++++++-----
 5 files changed, 89 insertions(+), 30 deletions(-)

Quoted 2 lines

Please treat this as a polite reminder to review
that series sometime soon.

Thank you for reviewing that series.
I'm wondering who's going to pick it up?

Quoted 37 lines · Alexey Brodkin

Hi Joe,

Quoted 34 lines · Alexey Brodkin

Hi Joe,

Quoted 30 lines · Alexey Brodkin

In some cases Ethernet PHY and network itself might support speeds which are not supported by Ethernet controller (MAC).

To support that kind of situation it is required to force limit PHY so it is not configured for unsupported mode or even if PHY autonegotiated too high speed it will be reconfigured for slower mode.

Note this series is v2 because v1 patches were sent separately not being aranged in series. And now I'm putting all patches in one series and marking it v2 even though no changes were done in patches itself.

Alexey Brodkin (4):
drivers/net/phy: introduce phy_set_supported() include/net.h: add max_speed member in struct eth_pdata net/designware: do explicit port selection for 1Gb mode net/designware: add support of max-speed device tree property

Florian Fainelli (2):
net: phy: ensure Gigabit features are masked off if requested
net: phy: breakdown PHY_*_FEATURES defines

Sascha Hauer (1):
net: phy: genphy: Allow overwriting features

 drivers/net/designware.c | 16 +++++++++-
 drivers/net/designware.h |  1 +
 drivers/net/phy/phy.c    | 77 ++++++++++++++++++++++++++++++++++--------------
 include/net.h            |  2 ++
 include/phy.h            | 23 ++++++++++-----
 5 files changed, 89 insertions(+), 30 deletions(-)

Quoted 5 lines

Quoted 2 lines

Please treat this as a polite reminder to review
that series sometime soon.

Thank you for reviewing that series.
I'm wondering who's going to pick it up?

I'm picking it up now and build testing it.