Skip to contentSkip to conversation

fetch2: Don't show checksum warnings if a single checksum was supplied

PATCH New Richard Purdie 1 participant 1 message Jan 22, 2016

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 fetch2: Don't show checksum warnings if a single checksum was supplied

If one checksum is supplied to a SRC_URI, we really don't want to show warnings about the other type which isn't present as one checksum is really good enough for most cases.

Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/fetch2/__init__.py +1 -3
index 0f9c643..5b416ab 100644
@@ -585,12 +585,10 @@ def verify_checksum(ud, d, precomputed={}):
             raise NoChecksumError('Missing SRC_URI checksum', ud.url)
 
         # Log missing sums so user can more easily add them
-        if not ud.md5_expected:
+        if not ud.md5_expected and not ud.sha256_expected:
             logger.warn('Missing md5 SRC_URI checksum for %s, consider adding to the recipe:\n'
                         'SRC_URI[%s] = "%s"',
                         ud.localpath, ud.md5_name, md5data)
-
-        if not ud.sha256_expected:
             logger.warn('Missing sha256 SRC_URI checksum for %s, consider adding to the recipe:\n'
                         'SRC_URI[%s] = "%s"',
                         ud.localpath, ud.sha256_name, sha256data)