sh: sh7753evb: Fix build error
PATCH 1/1 sh: sh7753evb: Fix build error
Currently buildman fails to build sh7753evb and reports the following:
board/renesas/sh7753evb/built-in.o: In function 'init_gether_mdio':
board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'PMB_ADDR_BASE' board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'PMB_DATA_BASE' board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'mk_pmb_addr_val' board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'mk_pmb_data_val'
make: *** [u-boot] Error 1
The fix is to wrap any codes that access these macros with CONFIG_SH_32BIT.
---
board/renesas/sh7753evb/sh7753evb.c | 4 ++++ 1 file changed, 4 insertions(+)
board/renesas/sh7753evb/sh7753evb.c +4 -0
@@ -113,6 +113,7 @@ static void set_mac_to_sh_giga_eth_register(int channel, char *mac_string)writel (val, ðer->malr); } +#if defined(CONFIG_SH_32BIT )/***************************************************************** * This PMB must be set on this timing. The lowlevel_init is run on * Area 0(phys 0x00000000), so we have to map it.
@@ -154,13 +155,16 @@ static void set_pmb_on_board_init(void)writel (mk_pmb_addr_val (0x98 ),PMB_ADDR_BASE (7 )); writel(mk_pmb_data_val(0x58, 0, 1, 1, 0, 1, 1), PMB_DATA_BASE(7)); } +#endif int board_init (void ) {struct gether_control_regs *gether =GETHER_CONTROL_BASE ;init_gpio (); +#if defined(CONFIG_SH_32BIT )set_pmb_on_board_init (); +#endif /* Sets TXnDLY to B'010 */ writel (0x00000202 , &gether->gbecont);
Signature · 1 line
1.8.2.1
PATCH 1/1 sh: sh7753evb: Fix build error
Quoted 9 lines · Bin Meng
Currently buildman fails to build sh7753evb and reports the following:
board/renesas/sh7753evb/built-in.o: In function 'init_gether_mdio':
board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'PMB_ADDR_BASE'board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'PMB_DATA_BASE'board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'mk_pmb_addr_val'board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'mk_pmb_data_val'
make: *** [u-boot] Error 1
Quoted 8 lines
The fix is to wrap any codes that access these macros with
CONFIG_SH_32BIT.Signed-off-by Bin Meng <[email protected]>---
board/renesas/sh7753evb/sh7753evb.c | 4 ++++ 1 file changed, 4 insertions(+)
While I am here, I have no idea how to fix the other 2 warnings for sh7785lcr_32bit and sh7785lcr.
Summary of 1 commit for 23 boards (23 threads, 2 jobs per thread) 01: sh: sh7753evb: Fix build error
sh: + sh7785lcr_32bit sh7785lcr
w+../drivers/net/rtl8169.c:310:2: warning: #warning cache-line size is larger than descriptor size [-Wcpp]
The warning comes from rtl8169.c below
#if RTL8169_DESC_SIZE < ARCH_DMA_MINALIGN
#if !defined(CONFIG_SYS_NONCACHED_MEMORY) && \
!defined(CONFIG_SYS_DCACHE_OFF) && !defined(CONFIG_X86) #warning cache-line size is larger than descriptor size #endif
#endif
Since I don't know anything about SH, I don't know how to eliminate the warning correctly.
Regards,
Bin
Quoted 9 lines · Bin Meng
Currently buildman fails to build sh7753evb and reports the following:
board/renesas/sh7753evb/built-in.o: In function 'init_gether_mdio':
board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'PMB_ADDR_BASE'board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'PMB_DATA_BASE'board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'mk_pmb_addr_val'board/renesas/sh7753evb/sh7753evb.c:94: undefined reference to 'mk_pmb_data_val'
make: *** [u-boot] Error 1
Quoted 3 lines
The fix is to wrap any codes that access these macros with
CONFIG_SH_32BIT.Signed-off-by Bin Meng <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160125/6217b618/attachment.sig>