Skip to contentSkip to conversation

yp-tools, ypbind-mt: new packages

PATCH Superseded Jonathan Ben-Avraham 1 participant 4 messages Jan 25, 2016

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover yp-tools, ypbind-mt: new packages

This patch series adds the yp-tools and yp-bind packages to Buildroot.

Changes v4 -> v5:
- Bumped yp-tools version from 3_4 to 3_5 and tested runtime functionality on arm Cortex-A9 hardware platform.

- Added the package/Config.in changes for each new package to the new package patches for each package rather than as a separate patch. The ypbind-mt patch now depends on the yp-tools patch because they both modify the same patch context lines in package/Config.in.

- Moved the patch of linux-pam.mk after the yp-tools patch and before the ypbind-mt patch.

Changes v3 -> v4:
- Added comment to my yp-tools configure.ac patch 0000-remove-Wcast-align-\
from-configure.ac.patch to indicate that my original patch that actually fixes the cast align problem was applied to the upstream.

- Changed the Config.in web site URL's for yp-tools and yp-bind from the github repo URL's to the http://www.linux-nis.org/nis URL's.

- Added comments in the *.mk files for yp-tools and ypbind-mt to explain the reason for choosing github over the web site Download links for the package sources.

- Replaced the S70ypbind rc script with an original work based on the upstream author's rc script for SuSe. The current version is designed for simplicity.

- Re-ordered the patches by 1) package/Config.in changes required by both of the new packages, 2) changes to other packages required by ypbind-mt, 3) the yp-tools package with all of its files and 4) the ypbind-mt package with all of its files.

Changes v2 -> v3:
- Not changed: I retained the mapv4v6addr.h in its entirety rather than patching nis-hosts.c as per TP's request. The reason for this is that the two files have different licensing, as explained in the comments in yp-tools.mk. I think that patching an BSD-style licensed file in in its entirety, with it's copyright and license, into a GPLv2 file is not correct policy, and extracting the map_v4v6_address from mapv4v6addr.h without the copyright and license notice is a clear violation of license.

- At TP's request, I added the 0000-remove-Wcast-align-from-configure\
.ac.patch to squelch the -Wcast-align warning that causes the ARM build to fail, instead of the original 0001-Change-do_ypcall_tr-\
param-resp-to-ypresp_val.patch that actually fixed the bug. My personal opinion is that it would have been better to leave the fix rather than to squelch the warning.

- Added "comment" to the Config.in regarding glibc dependency.

- Added a patch to linux-pam.mk to enable NIS support if yp-tools is selected.

- Performed menuconfig UI testing and build testing for absolute minimal configurations using the following toolchains:
- br-arm-basic-2015.11-rc1
- br-arm-full-2015.11-rc1
- br-arm-cortex-a9-musl-2015.11-rc1
- br-arm11-full-nothread-2015.11-rc1
- br-arm-full-static-2015.11-rc1
- ia32-2012.09-62-i686-pc-linux-gnu-i386-linux
- crosstool-ng GCC 5.1 arm-mxs-linux-gnueabihf

Jonathan Ben-Avraham (3):
yp-tools: new package
linux-pam: enable NIS support if yp-tools selected
ypbind-mt: new package

 package/Config.in                                  |  2 +
 package/linux-pam/linux-pam.mk                     |  9 ++-
 ...0000-remove-Wcast-align-from-configure.ac.patch | 19 +++++
 package/yp-tools/Config.in                         | 15 ++++
 package/yp-tools/mapv4v6addr.h                     | 69 ++++++++++++++++
 package/yp-tools/yp-tools.hash                     |  2 +
 package/yp-tools/yp-tools.mk                       | 30 +++++++
 .../ypbind-mt/0001-Remove_man_dir_from_build.patch | 16 ++++
 package/ypbind-mt/Config.in                        | 17 ++++
 package/ypbind-mt/S70ypbind                        | 93 ++++++++++++++++++++++
 package/ypbind-mt/ypbind-mt.mk                     | 24 ++++++
 11 files changed, 295 insertions(+), 1 deletion(-)
 create mode 100644 package/yp-tools/0000-remove-Wcast-align-from-configure.ac.patch
 create mode 100644 package/yp-tools/Config.in
 create mode 100644 package/yp-tools/mapv4v6addr.h
 create mode 100644 package/yp-tools/yp-tools.hash
 create mode 100644 package/yp-tools/yp-tools.mk
 create mode 100644 package/ypbind-mt/0001-Remove_man_dir_from_build.patch
 create mode 100644 package/ypbind-mt/Config.in
 create mode 100755 package/ypbind-mt/S70ypbind
 create mode 100644 package/ypbind-mt/ypbind-mt.mk
Signature · 1 line
2.1.4
#1 lore raw

PATCH v5 1/3 yp-tools: new package

Adds the yp-tools package that provides various NIS (yp) utilities.

---
 package/Config.in                                  |  1 +
 ...0000-remove-Wcast-align-from-configure.ac.patch | 19 ++++++
 package/yp-tools/Config.in                         | 15 +++++
 package/yp-tools/mapv4v6addr.h                     | 69 ++++++++++++++++++++++
 package/yp-tools/yp-tools.hash                     |  2 +
 package/yp-tools/yp-tools.mk                       | 30 ++++++++++
 6 files changed, 136 insertions(+)
 create mode 100644 package/yp-tools/0000-remove-Wcast-align-from-configure.ac.patch
 create mode 100644 package/yp-tools/Config.in
 create mode 100644 package/yp-tools/mapv4v6addr.h
 create mode 100644 package/yp-tools/yp-tools.hash
 create mode 100644 package/yp-tools/yp-tools.mk
package/Config.in +1 -0
index 09c2b40..6d8caf7 100644
@@ -1482,6 +1482,7 @@ endif
 	source "package/xinetd/Config.in"
 	source "package/xl2tp/Config.in"
 	source "package/xtables-addons/Config.in"
+	source "package/yp-tools/Config.in"
 	source "package/znc/Config.in"
 
 endmenu
package/yp-tools/0000-remove-Wcast-align-from-configure.ac.patch new file +19 -0
new file mode 100644
index 0000000..f73728d
@@ -0,0 +1,19 @@
+Remove "-Wcast-align" from the compiler warnings for compilation on arm arch.
+A patch to fix the cast-align warning was submitted to the package maintainer
+on December 16, 2015 and applied on January 20, 2016 in https://github.com/\
+thkukuk/yp-tools/commit/ea66fde92c228bf7b13612b07e4cf1b0667e8481.
+
+Signed-off-by: Jonathan Ben Avraham <[email protected]>
+
+--- a/configure.ac	2015-04-16 13:08:34.000000000 +0300
++++ b/configure.ac	2015-12-23 18:38:55.358622278 +0200
+@@ -56,7 +56,7 @@
+ AM_PROG_CC_C_O
+ dnl If we're using gcc, we want warning flags
+ dnl test -n "$GCC" && WARNFLAGS="-Wall"
+-test -n "$GCC" && WARNFLAGS="-W -Wall -Wbad-function-cast -Wcast-align -Winline -Wnested-externs -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wundef -Werror"
++test -n "$GCC" && WARNFLAGS="-W -Wall -Wbad-function-cast -Winline -Wnested-externs -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wundef -Werror"
+ AC_SUBST(WARNFLAGS)
+ AC_PROG_CPP
+ AC_ISC_POSIX
+
package/yp-tools/Config.in new file +15 -0
new file mode 100644
index 0000000..846bb1e
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_YP_TOOLS
+	bool "yp-tools"
+	depends on BR2_TOOLCHAIN_USES_GLIBC # rpcsvc/nis.h
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+	select BR2_PACKAGE_RPCBIND # runtime
+	help
+	  The yp-tools package contains the programs domainname,
+	  nisdomainname, ypcat, ypchfn, ypchsh, ypdomainname, ypmatch,
+	  yppoll, ypset, ypwhich and yppasswd. yp-tools 3.x is a port of
+	  yp-tools 2.x to support IPv6.
+
+	  http://www.linux-nis.org/nis/yp-tools/
+
+comment "yp-tools needs an (e)glibc toolchain with rpcsvc/nis.h"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
package/yp-tools/mapv4v6addr.h new file +69 -0

69 lines not on this page · raw message

package/yp-tools/yp-tools.hash new file +2 -0
new file mode 100644
index 0000000..9e8b532
@@ -0,0 +1,2 @@
+# Computed locally
+sha256 2dfa7ddfb797f2a5b4b7baaef7d6ee6fda41fe7066695fc7e3db998a32c1c698  yp-tools-yp-tools-3_5.tar.gz
package/yp-tools/yp-tools.mk new file +30 -0
new file mode 100644
index 0000000..b47f797
@@ -0,0 +1,30 @@
+################################################################################
+#
+# yp-tools
+#
+################################################################################
+
+# The github release tags are one to two releases ahead of the "Download"
+# links on http://www.linux-nis.org/nis/yp-tools/
+YP_TOOLS_VERSION = yp-tools-3_5
+YP_TOOLS_SITE = $(call github,thkukuk,yp-tools,$(YP_TOOLS_VERSION))
+YP_TOOLS_LICENSE = GPLv2
+YP_TOOLS_LICENSE_FILES = COPYING
+YP_TOOLS_AUTORECONF = YES
+YP_TOOLS_DEPENDENCIES = host-pkgconf
+YP_TOOLS_PRE_CONFIGURE_HOOKS += YP_TOOLS_LOCAL_MAPV4V6ADDR_H
+
+# If mapv4v6addr.h is not otherwise available we provide it here. It provides a
+# single function, map_v4v6_address is needed by a single yp-tools file,
+# nis-hosts.c. This mapv4v6addr.h code has BSD style licensing, whereas yp-tools
+# has GPLv2 licensing. In order not to confuse the licensing we maintain
+# mapv4v6addr.h as a separate file rather than patching the entire file with
+# it's copyright and license notice into nis-hosts.c, which is licensed under
+# GPLv2.
+
+define YP_TOOLS_LOCAL_MAPV4V6ADDR_H
+	$(INSTALL) -D -m 0644 $(YP_TOOLS_PKGDIR)/mapv4v6addr.h \
+		$(STAGING_DIR)/usr/include/resolv/mapv4v6addr.h
+endef
+
+$(eval $(autotools-package))
Signature · 1 line
2.1.4
#2 lore raw

PATCH v5 2/3 linux-pam: enable NIS support if yp-tools selected

In reply to Jonathan Ben-Avraham

Enable the NIS support in linux-pam when the yp-tools package is selected.

---
 package/linux-pam/linux-pam.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
package/linux-pam/linux-pam.mk +8 -1
index 26b627e..3d860d2 100644
@@ -11,7 +11,6 @@ LINUX_PAM_INSTALL_STAGING = YES
 LINUX_PAM_CONF_OPTS = \
 	--disable-prelude \
 	--disable-isadir \
-	--disable-nis \
 	--disable-db \
 	--disable-regenerate-docu \
 	--enable-securedir=/lib/security \
@@ -21,6 +20,14 @@ LINUX_PAM_AUTORECONF = YES
 LINUX_PAM_LICENSE = BSD-3c
 LINUX_PAM_LICENSE_FILES = Copyright
 
+ifeq ($(BR2_PACKAGE_YP_TOOLS),y)
+LINUX_PAM_CONF_OPTS += \
+	--enable-nis
+else
+LINUX_PAM_CONF_OPTS += \
+	--disable-nis
+endif
+
 ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 LINUX_PAM_DEPENDENCIES += gettext
 LINUX_PAM_MAKE_OPTS += LIBS=-lintl
Signature · 1 line
2.1.4
#3 lore raw

PATCH v5 3/3 ypbind-mt: new package

In reply to Jonathan Ben-Avraham

Adds the ypbind-mt package that contains a multi-threaded ypbind daemon for Linux. Depends on yp-tools patch.

---
 package/Config.in                                  |  1 +
 .../ypbind-mt/0001-Remove_man_dir_from_build.patch | 16 ++++
 package/ypbind-mt/Config.in                        | 17 ++++
 package/ypbind-mt/S70ypbind                        | 93 ++++++++++++++++++++++
 package/ypbind-mt/ypbind-mt.mk                     | 24 ++++++
 5 files changed, 151 insertions(+)
 create mode 100644 package/ypbind-mt/0001-Remove_man_dir_from_build.patch
 create mode 100644 package/ypbind-mt/Config.in
 create mode 100755 package/ypbind-mt/S70ypbind
 create mode 100644 package/ypbind-mt/ypbind-mt.mk
package/Config.in +1 -0
index 6d8caf7..af9656b 100644
@@ -1483,6 +1483,7 @@ endif
 	source "package/xl2tp/Config.in"
 	source "package/xtables-addons/Config.in"
 	source "package/yp-tools/Config.in"
+	source "package/ypbind-mt/Config.in"
 	source "package/znc/Config.in"
 
 endmenu
package/ypbind-mt/0001-Remove_man_dir_from_build.patch new file +16 -0
new file mode 100644
index 0000000..10ebed7
@@ -0,0 +1,16 @@
+Remove the man directory from the build in order to avoid trying to build the
+commented targets ypbind.8 and ypconf.5
+
+Signed-off-by: Jonathan Ben Avraham <[email protected]>
+
+--- a/Makefile.am	2014-12-04 16:27:18.000000000 +0200
++++ b/Makefile.am	2015-12-16 15:00:21.950050679 +0200
+@@ -5,7 +5,7 @@
+ #
+ AUTOMAKE_OPTIONS = 1.6 gnits dist-bzip2
+ #
+-SUBDIRS = lib src man po
++SUBDIRS = lib src po
+ 
+ CLEANFILES = *~
+ 
package/ypbind-mt/Config.in new file +17 -0
new file mode 100644
index 0000000..2ac9d28
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_YPBIND_MT
+	bool "ypbind-mt"
+	depends on BR2_TOOLCHAIN_USES_GLIBC # rpcsvc/nis.h
+	select BR2_PACKAGE_YP_TOOLS
+	select BR2_PACKAGE_RPCBIND # runtime
+	help
+	  The ypbind-mt package contains a multithreaded ypbind daemon
+	  for Linux. It uses threads for better response and supports
+	  the ypbind protocols version 1, 2 and 3.
+
+	  Note: You need to select package "linux-pam" for NIS
+	  authentication.
+
+	  http://www.linux-nis.org/nis/ypbind-mt/
+
+comment "ypbind-mt needs an (e)glibc toolchain with rpcsvc/nis.h"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
package/ypbind-mt/S70ypbind new file +93 -0

93 lines not on this page · raw message

package/ypbind-mt/ypbind-mt.mk new file +24 -0
new file mode 100644
index 0000000..08baf6e
@@ -0,0 +1,24 @@
+################################################################################
+#
+# ypbind-mt
+#
+################################################################################
+
+# The github releases of ypbind-mt are often a release or more ahead of the
+# "Download" links on http://www.linux-nis.org/nis/ypbind-mt/
+YPBIND_MT_VERSION = ypbind-mt-2_2
+YPBIND_MT_SITE = $(call github,thkukuk,ypbind-mt,$(YPBIND_MT_VERSION))
+YPBIND_MT_LICENSE = GPLv2
+YPBIND_MT_LICENSE_FILES = COPYING
+YPBIND_MT_AUTORECONF = YES
+YPBIND_MT_DEPENDENCIES = host-pkgconf yp-tools
+YPBIND_MT_CONF_ENV = \
+	PKG_CONFIG_SYSROOT_DIR="$(TARGET_DIR)" \
+	PKG_CONFIG_PATH="$(TARGET_DIR)/usr/lib/pkgconfig"
+
+define YPBIND_MT_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 755 $(YPBIND_MT_PKGDIR)/S70ypbind \
+		$(TARGET_DIR)/etc/init.d/S70ypbind
+endef
+
+$(eval $(autotools-package))
Signature · 1 line
2.1.4