Patch "ALSA: hda - Apply click noise workaround for Thinkpads generically" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ALSA: hda - Apply click noise workaround for Thinkpads generically
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-hda-apply-click-noise-workaround-for-thinkpads-generically.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
157f0b7f6c0cc0bc88647390006e959e267a0143Mon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Thu, 10 Dec 2015 23:30:43 +0100
Subject: ALSA: hda - Apply click noise workaround for Thinkpads generically
From: Takashi Iwai <[email protected]>
commit 157f0b7f6c0cc0bc88647390006e959e267a0143 upstream.
It seems that a workaround for Thinkpad T440s crackling noise can be applied generically to all Thinkpad models: namely, disabling the default alc269 shutup callback. This patch moves it to the existing alc_fixup_tpt440_dock() while also replacing the rest code with another existing alc_fixup_disable_aamix(). It resulted in a good code reduction.
Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=958439
--- sound/pci/hda/patch_realtek.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
sound/pci/hda/patch_realtek.c +2 -13
@@ -4202,24 +4202,13 @@ static void alc_fixup_tpt440_dock(structstruct alc_spec *spec = codec->spec;if (action ==HDA_FIXUP_ACT_PRE_PROBE ) { + spec->shutup = alc_no_shutup;/* reduce click noise */ spec->parse_flags =HDA_PINCFG_NO_HP_FIXUP ; codec->power_save_node =0 ;/* avoid click noises */ snd_hda_apply_pincfgs (codec, pincfgs); } } -/* additional fixup for Thinkpad T440s noise problem */ -static void alc_fixup_tpt440 (struct hda_codec *codec, -const struct hda_fixup *fix,int action) -{ -struct alc_spec *spec = codec->spec; - -if (action ==HDA_FIXUP_ACT_PRE_PROBE ) { - spec->shutup = alc_no_shutup;/* reduce click noise */ - spec->gen.mixer_nid =0 ;/* reduce background noise */ - } -} -static void alc_shutup_dell_xps13 (struct hda_codec *codec) {struct alc_spec *spec = codec->spec;
@@ -5016,7 +5005,7 @@ static const struct hda_fixup alc269_fix }, [ALC292_FIXUP_TPT440] = { .type = HDA_FIXUP_FUNC, - .v.func = alc_fixup_tpt440, + .v.func = alc_fixup_disable_aamix, .chained = true, .chain_id = ALC292_FIXUP_TPT440_DOCK, },
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/alsa-hda-add-fixup-for-acer-aspire-one-cloudbook-14.patch queue-4.1/alsa-usb-audio-add-sample-rate-inquiry-quirk-for-audioquest-dragonfly.patch queue-4.1/alsa-hda-apply-hp-headphone-fixups-more-generically.patch queue-4.1/alsa-hda-set-codec-to-d3-at-reboot-shutdown-on-thinkpads.patch queue-4.1/alsa-hda-realtek-fix-silent-headphone-output-on-macpro-4-1-v2.patch queue-4.1/alsa-rme96-fix-unexpected-volume-reset-after-rate-changes.patch queue-4.1/alsa-fireworks-bebob-oxfw-dice-enable-to-make-as-built-in.patch queue-4.1/alsa-hda-set-skl-hda-controller-power-at-freeze-and-thaw.patch queue-4.1/alsa-hda-add-inverted-dmic-for-packard-bell-dots.patch queue-4.1/alsa-hda-add-intel-lewisburg-device-ids-audio.patch queue-4.1/alsa-hda-add-a-fixup-for-thinkpad-x1-carbon-2nd.patch queue-4.1/alsa-hda-disable-64bit-address-for-creative-hda-controllers.patch queue-4.1/alsa-usb-audio-add-a-more-accurate-volume-quirk-for-audioquest-dragonfly.patch queue-4.1/alsa-hda-fix-noise-problems-on-thinkpad-t440s.patch queue-4.1/alsa-hda-apply-pin-fixup-for-hp-probook-6550b.patch queue-4.1/alsa-hda-apply-click-noise-workaround-for-thinkpads-generically.patch queue-4.1/alsa-hda-fix-noise-on-gigabyte-z170x-mobo.patch