Skip to contentSkip to conversation

Patch "ASoC: rt286: Fix run time error while modifying const data" has been added to the 4.3-stable tree

PATCH [email protected] 1 participant 1 message Jan 26, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ASoC: rt286: Fix run time error while modifying const data

to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
asoc-rt286-fix-run-time-error-while-modifying-const-data.patch
and it can be found in the queue-4.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From dc6d84c69cf8296b1e8e2fd0b1e115b7787ef4e9 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Mon, 5 Oct 2015 21:22:40 +0800
Subject: ASoC: rt286: Fix run time error while modifying const data

From: Axel Lin <[email protected]>

commit dc6d84c69cf8296b1e8e2fd0b1e115b7787ef4e9 upstream.

Make a copy of memory for index_cache rather than directly use the rt286_index_def to avoid run time error.

Fixes c418a84a8c8f ("ASoC: Constify reg_default tables")
---
 sound/soc/codecs/rt286.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
sound/soc/codecs/rt286.c +6 -2
@@ -38,7 +38,7 @@
 #define RT288_VENDOR_ID 0x10ec0288
 
 struct rt286_priv {
-	const struct reg_default *index_cache;
+	struct reg_default *index_cache;
 	int index_cache_size;
 	struct regmap *regmap;
 	struct snd_soc_codec *codec;
@@ -1161,7 +1161,11 @@ static int rt286_i2c_probe(struct i2c_cl
 		return -ENODEV;
 	}
 
-	rt286->index_cache = rt286_index_def;
+	rt286->index_cache = devm_kmemdup(&i2c->dev, rt286_index_def,
+					  sizeof(rt286_index_def), GFP_KERNEL);
+	if (!rt286->index_cache)
+		return -ENOMEM;
+
 	rt286->index_cache_size = INDEX_CACHE_SIZE;
 	rt286->i2c = i2c;
 	i2c_set_clientdata(i2c, rt286);

Patches currently in stable-queue which might be from [email protected] are

queue-4.3/asoc-rt286-fix-run-time-error-while-modifying-const-data.patch