Patch "ALSA: timer: Fix double unlink of active_list" has been added to the 3.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ALSA: timer: Fix double unlink of active_list
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-timer-fix-double-unlink-of-active_list.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
ee8413b01045c74340aa13ad5bdf905de32be736Mon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Wed, 13 Jan 2016 21:35:06 +0100
Subject: ALSA: timer: Fix double unlink of active_list
From: Takashi Iwai <[email protected]>
commit ee8413b01045c74340aa13ad5bdf905de32be736 upstream.
ALSA timer instance object has a couple of linked lists and they are unlinked unconditionally at snd_timer_stop(). Meanwhile snd_timer_interrupt() unlinks it, but it calls list_del() which leaves the element list itself unchanged. This ends up with unlinking twice, and it was caught by syzkaller fuzzer.
The fix is to use list_del_init() variant properly there, too.
--- sound/core/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/timer.c +1 -1
@@ -703,7 +703,7 @@ void snd_timer_interrupt(struct snd_time }else { ti->flags &= ~SNDRV_TIMER_IFLG_RUNNING ;if (--timer->running) -list_del (&ti->active_list); +list_del_init (&ti->active_list); }if ((timer->hw.flags &SNDRV_TIMER_HW_TASKLET ) || (ti->flags &SNDRV_TIMER_IFLG_FAST ))
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/alsa-hrtimer-fix-stall-by-hrtimer_cancel.patch queue-3.14/alsa-timer-harden-slave-timer-list-handling.patch queue-3.14/alsa-timer-fix-double-unlink-of-active_list.patch queue-3.14/alsa-control-avoid-kernel-warnings-from-tlv-ioctl-with-numid-0.patch queue-3.14/alsa-hda-realtek-fix-silent-headphone-output-on-macpro-4-1-v2.patch queue-3.14/alsa-rme96-fix-unexpected-volume-reset-after-rate-changes.patch queue-3.14/alsa-hda-set-skl-hda-controller-power-at-freeze-and-thaw.patch queue-3.14/alsa-hda-add-inverted-dmic-for-packard-bell-dots.patch queue-3.14/alsa-hda-add-intel-lewisburg-device-ids-audio.patch queue-3.14/alsa-seq-fix-race-at-timer-setup-and-close.patch queue-3.14/alsa-pcm-fix-snd_pcm_hw_params-struct-copy-in-compat-mode.patch queue-3.14/alsa-seq-fix-snd_seq_call_port_info_ioctl-in-compat-mode.patch queue-3.14/alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch queue-3.14/alsa-timer-fix-race-among-timer-ioctls.patch queue-3.14/alsa-hda-apply-pin-fixup-for-hp-probook-6550b.patch