Skip to contentSkip to conversation

prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.

RFC PATCH In review John Stultz 3 participants 4 messages Jan 26, 2016 – Jan 27, 2016

lore
Share & tools
lore
#0 lore raw

RFC PATCH v2 1/1 prctl: Add PR_SET_TIMERSLACK_PID for setting timer slack of an arbitrary thread.

From: Ruchi Kandoi <[email protected]>

This allows power/performance management software to set timer slack for other threads according to its policy for the thread (such as when the thread is designated foreground vs. background activity)

Second argument is similar to PR_SET_TIMERSLACK, if non-zero then the slack is set to that value otherwise sets it to the default for the thread.

Takes PID of the thread as the third argument.

This interface checks that the calling task has permissions to to use PTRACE_MODE_ATTACH on the target task, so that we can ensure arbitrary apps do not change the timer slack for other apps.

Additional fixes from Ruchi and Micha Kalfon <[email protected]> have been folded into this patch to make it easier to reivew.

Cc Arjan van de Ven <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Oren Laadan <[email protected]>
Cc Micha Kalfon <[email protected]>
Cc Ruchi Kandoi <[email protected]>
Cc Rom Lemarchand <[email protected]>
Cc Android Kernel Team <[email protected]>

[jstultz:
* Folded in CAP_SYS_NICE check from Ruchi.
* Folded in fix misplaced PR_SET_TIMERSLACK_PID case fix from Micha.
* Folded in make PR_SET_TIMERSLACK_PID pid namespace aware fix from Micha.
* Changed PR_SET_TIMERSLACK_PID so it didn't collide with already upstream prctrl values.
* Reworked commit message.
* Moved from CAP_SYS_NICE to PTRACE_MODE_ATTACH for permissions checks]

---
New in v2:
* Changed from CAP_SYS_NICE to PTRACE_MODE_ATTACH permissions checking on Arjan's suggestion

 include/uapi/linux/prctl.h |  7 +++++++
 kernel/sys.c               | 25 +++++++++++++++++++++++++
 2 files changed, 32 insertions(+)
include/uapi/linux/prctl.h +7 -0
index a8d0759..1a13c2b 100644
@@ -187,6 +187,13 @@ struct prctl_mm_map {
 
 #define PR_SET_FP_MODE		45
 #define PR_GET_FP_MODE		46
+
+/* Sets the timerslack for arbitrary threads
+ * arg2 slack value, 0 means "use default"
+ * arg3 pid of the thread whose timer slack needs to be set
+ */
+#define PR_SET_TIMERSLACK_PID	47
+
 # define PR_FP_MODE_FR		(1 << 0)	/* 64b FP registers */
 # define PR_FP_MODE_FRE		(1 << 1)	/* 32b compatibility */
 
kernel/sys.c +25 -0
index 78947de..5189378 100644
@@ -41,6 +41,9 @@
 #include <linux/syscore_ops.h>
 #include <linux/version.h>
 #include <linux/ctype.h>
+#include <linux/mm.h>
+#include <linux/mempolicy.h>
+#include <linux/sched.h>
 
 #include <linux/compat.h>
 #include <linux/syscalls.h>
@@ -2076,6 +2079,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,
 		unsigned long, arg4, unsigned long, arg5)
 {
 	struct task_struct *me = current;
+	struct task_struct *tsk;
 	unsigned char comm[sizeof(me->comm)];
 	long error;
 
@@ -2218,6 +2222,27 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,
 	case PR_GET_TID_ADDRESS:
 		error = prctl_get_tid_address(me, (int __user **)arg2);
 		break;
+	case PR_SET_TIMERSLACK_PID:
+		rcu_read_lock();
+		tsk = find_task_by_vpid((pid_t)arg3);
+		if (tsk == NULL) {
+			rcu_read_unlock();
+			return -EINVAL;
+		}
+		get_task_struct(tsk);
+		rcu_read_unlock();
+		if (ptrace_may_access(tsk, PTRACE_MODE_ATTACH)) {
+			put_task_struct(tsk);
+			return -EPERM;
+		}
+		if (arg2 <= 0)
+			tsk->timer_slack_ns =
+				tsk->default_timer_slack_ns;
+		else
+			tsk->timer_slack_ns = arg2;
+		put_task_struct(tsk);
+		error = 0;
+		break;
 	case PR_SET_CHILD_SUBREAPER:
 		me->signal->is_child_subreaper = !!arg2;
 		break;
Signature · 1 line
1.9.1
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · John Stultz

From: Ruchi Kandoi <[email protected]>

This allows power/performance management software to set timer slack for other threads according to its policy for the thread (such as when the thread is designated foreground vs. background activity)

Second argument is similar to PR_SET_TIMERSLACK, if non-zero then the slack is set to that value otherwise sets it to the default for the thread.

Quoted 6 lines

Takes PID of the thread as the third argument.

This interface checks that the calling task has permissions to to use PTRACE_MODE_ATTACH on the target task, so that we can ensure arbitrary apps do not change the timer slack for other apps.

only slight concern is the locking around the value of the field in the task struct, but nobody does read-modify-write on it, so they'll get either the new or the old version, which should be ok.

(until now only the local thread would touch the field, and if you're setting it, by definition you're not going to sleep yet, so you're not using the field)

#2 lore raw
Quoted 27 lines · Arjan van de Ven
Quoted 11 lines · John Stultz

From: Ruchi Kandoi <[email protected]>

This allows power/performance management software to set timer slack for other threads according to its policy for the thread (such as when the thread is designated foreground vs. background activity)

Second argument is similar to PR_SET_TIMERSLACK, if non-zero then the slack is set to that value otherwise sets it to the default for the thread.

Quoted 6 lines

Takes PID of the thread as the third argument.

This interface checks that the calling task has permissions to to use PTRACE_MODE_ATTACH on the target task, so that we can ensure arbitrary apps do not change the timer slack for other apps.

only slight concern is the locking around the value of the field in the task struct,
but nobody does read-modify-write on it, so they'll get either the new or the old version,
which should be ok.

Quoted 3 lines

(until now only the local thread would touch the field, and if you're setting it, by definition
you're not going to sleep yet, so you're not using the field)

Even if you access it remote, it's a non issue. The task will see either the old or the new value. Which is equally true when you add locking around the write.

Thanks,

tglx

Reviewed-by on v2 1/1
#3 lore raw
In reply to John Stultz
Quoted 40 lines · John Stultz

From: Ruchi Kandoi <[email protected]>

This allows power/performance management software to set timer slack for other threads according to its policy for the thread (such as when the thread is designated foreground vs. background activity)

Second argument is similar to PR_SET_TIMERSLACK, if non-zero then the slack is set to that value otherwise sets it to the default for the thread.

Takes PID of the thread as the third argument.

This interface checks that the calling task has permissions to to use PTRACE_MODE_ATTACH on the target task, so that we can ensure arbitrary apps do not change the timer slack for other apps.

Additional fixes from Ruchi and Micha Kalfon <[email protected]> have been folded into this patch to make it easier to reivew.

Cc Arjan van de Ven <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Oren Laadan <[email protected]>
Cc Micha Kalfon <[email protected]>
Cc Ruchi Kandoi <[email protected]>
Cc Rom Lemarchand <[email protected]>
Cc Android Kernel Team <[email protected]>

[jstultz:
* Folded in CAP_SYS_NICE check from Ruchi.
* Folded in fix misplaced PR_SET_TIMERSLACK_PID case fix from Micha.
* Folded in make PR_SET_TIMERSLACK_PID pid namespace aware fix from Micha.
* Changed PR_SET_TIMERSLACK_PID so it didn't collide with already upstream prctrl values.
* Reworked commit message.
* Moved from CAP_SYS_NICE to PTRACE_MODE_ATTACH for permissions checks]

Quoted 1 line