Skip to contentSkip to conversation

drm/i915/bxt: update list of PCIIDs

PATCH In review Imre Deak 4 participants 6 messages Jan 28, 2016 – Feb 2, 2016 DRM drivers

lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH 1/1 drm/i915/bxt: update list of PCIIDs

Add PCIIDs for new versions of the SOC, based on BSpec. Also add the name of the versions as code comment where this is available. The new versions don't have any changes visible to the kernel driver.

---
 include/drm/i915_pciids.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/drm/i915_pciids.h +3 -1
index f970209..9b48ac1 100644
@@ -296,7 +296,9 @@
 #define INTEL_BXT_IDS(info) \
 	INTEL_VGA_DEVICE(0x0A84, info), \
 	INTEL_VGA_DEVICE(0x1A84, info), \
-	INTEL_VGA_DEVICE(0x5A84, info)
+	INTEL_VGA_DEVICE(0x1A85, info), \
+	INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \
+	INTEL_VGA_DEVICE(0x5A85, info)  /* APL HD Graphics 500 */
 
 #define INTEL_KBL_GT1_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Imre Deak

Add PCIIDs for new versions of the SOC, based on BSpec. Also add the name of the versions as code comment where this is available. The new versions don't have any changes visible to the kernel driver.

Quoted 26 lines
---
 include/drm/i915_pciids.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/drm/i915_pciids.h +3 -1
index f970209..9b48ac1 100644
@@ -296,7 +296,9 @@
 #define INTEL_BXT_IDS(info) \
 	INTEL_VGA_DEVICE(0x0A84, info), \
 	INTEL_VGA_DEVICE(0x1A84, info), \
-	INTEL_VGA_DEVICE(0x5A84, info)
+	INTEL_VGA_DEVICE(0x1A85, info), \
+	INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \
+	INTEL_VGA_DEVICE(0x5A85, info)  /* APL HD Graphics 500 */
 
 #define INTEL_KBL_GT1_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/bxt: update list of PCIIDs

In reply to Imre Deak
== Summary ==

== Summary ==

Series 2901v1 drm/i915/bxt: update list of PCIIDs
http://patchwork.freedesktop.org/api/1.0/series/2901/revisions/1/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a:
                skip       -> PASS       (byt-nuc)
bdw-nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:12 
bsw-nuc-2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30 
byt-nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:23 
hsw-brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:13 
hsw-gt2          total:159  pass:149  dwarn:0   dfail:0   fail:0   skip:10 
ilk-hp8440p      total:159  pass:110  dwarn:1   dfail:0   fail:0   skip:48 
ivb-t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:14 
skl-i5k-2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14 
snb-dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:22 
snb-x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:21 

Results at /archive/results/CI_IGT_test/Patchwork_1312/

5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest 4632905fa2a81fe378d0170dcbb9733cec7726cf drm/i915/bxt: update list of PCIIDs

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#3 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915/bxt: update list of PCIIDs

Quoted 6 lines · Patchwork

== Summary ==

Series 2901v1 drm/i915/bxt: update list of PCIIDs
http://patchwork.freedesktop.org/api/1.0/series/2901/revisions/1/mbox
/

Quoted 6 lines

Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a:
                skip       -> PASS       (byt-nuc)

Thanks for the review, I pushed the patch to dinq.

--Imre

Quoted 33 lines

bdw-
nuci7        total:156  pass:147  dwarn:0   dfail:0   fail:0   skip:9
bdw-
ultra        total:159  pass:147  dwarn:0   dfail:0   fail:0   skip:1 2
bsw-nuc-
2        total:159  pass:129  dwarn:0   dfail:0   fail:0   skip:30 byt-
nuc          total:159  pass:136  dwarn:0   dfail:0   fail:0   skip:2 3
hsw-
brixbox      total:159  pass:146  dwarn:0   dfail:0   fail:0   skip:1 3
hsw-
gt2          total:159  pass:149  dwarn:0   dfail:0   fail:0   skip:1 0
ilk-
hp8440p      total:159  pass:110  dwarn:1   dfail:0   fail:0   skip:4 8
ivb-
t430s        total:159  pass:145  dwarn:0   dfail:0   fail:0   skip:1 4
skl-i5k-
2        total:159  pass:144  dwarn:1   dfail:0   fail:0   skip:14 snb-
dellxps      total:159  pass:137  dwarn:0   dfail:0   fail:0   skip:2 2
snb-
x220t        total:159  pass:137  dwarn:0   dfail:0   fail:1   skip:2 1

Quoted 7 lines

Results at /archive/results/CI_IGT_test/Patchwork_1312/

5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y- 01m-29d-07h-32m-09s UTC integration manifest 4632905fa2a81fe378d0170dcbb9733cec7726cf drm/i915/bxt: update list of PCIIDs

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Imre Deak
Quoted 14 lines · Imre Deak

Add PCIIDs for new versions of the SOC, based on BSpec. Also add the name of the versions as code comment where this is available. The new versions don't have any changes visible to the kernel driver.

---
 include/drm/i915_pciids.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/drm/i915_pciids.h +0 -0
index f970209..9b48ac1 100644

include/drm/i915_pciids.h line 299

Quoted 5 lines
include/drm/i915_pciids.h +1 -1
@@ -296,7 +296,9 @@
 #define INTEL_BXT_IDS(info) \
 	INTEL_VGA_DEVICE(0x0A84, info), \
 	INTEL_VGA_DEVICE(0x1A84, info), \
-	INTEL_VGA_DEVICE(0x5A84, info)
+	INTEL_VGA_DEVICE(0x1A85, info), \

I don't see 0x1A85 in the bspec (at least not in the "Configurations -> Steppings and Device IDs" section...is there another list elsewhere in the bspec you got it from?)

Semi-related...the revision ID vs stepping info on that page doesn't seem to quite match what we have in bxt_stepping_info[] in intel_csr.c (plus it looks like we have some new revision ID's we could add in general).

Matt

Quoted 12 lines
include/drm/i915_pciids.h +2 -0
+	INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */ \
+	INTEL_VGA_DEVICE(0x5A85, info)  /* APL HD Graphics 500 */
 
 #define INTEL_KBL_GT1_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 9 lines
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#5 lore raw
Quoted 12 lines · Matt Roper
Quoted 11 lines · Imre Deak

Add PCIIDs for new versions of the SOC, based on BSpec. Also add the
name of the versions as code comment where this is available. The new
versions don't have any changes visible to the kernel driver.

---
 include/drm/i915_pciids.h | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 16 lines

include/drm/i915_pciids.h line 299

Quoted 10 lines
include/drm/i915_pciids.h +1 -1
index f970209..9b48ac1 100644
@@ -296,7 +296,9 @@
  #define INTEL_BXT_IDS(info) \
  	INTEL_VGA_DEVICE(0x0A84, info), \
  	INTEL_VGA_DEVICE(0x1A84, info), \
-	INTEL_VGA_DEVICE(0x5A84, info)
+	INTEL_VGA_DEVICE(0x1A85, info), \

I don't see 0x1A85 in the bspec (at least not in the "Configurations ->
Steppings and Device IDs" section...is there another list elsewhere in
the bspec you got it from?)

Hm yes, it looks like it was left out from the first table, it is only listed under "Broxton SKUs and Device IDs". I opened a new issue on the relevant BSpec page.

Quoted 3 lines

Semi-related...the revision ID vs stepping info on that page doesn't seem to quite match what we have in bxt_stepping_info[] in intel_csr.c

Hm good point. This depends on how the firmware versions will be packaged for the newer versions. It is possible that for the new steppings a default entry will be used, in which case we wouldn't have to encode the individual steppings.

+Animesh. Animesh could you check the above and follow-up with a patch updating the table if necessary?

Quoted 2 lines

(plus it looks like we have some new revision ID's we could add in general).

The way we did this so far is to add encodings only for steppings that we need for a WA. There hasn't been any need for the newer steppings based on this.

--Imre

Quoted 11 lines

Matt

Quoted 9 lines
include/drm/i915_pciids.h +2 -0
+	INTEL_VGA_DEVICE(0x5A84, info), /* APL HD Graphics 505 */
 \
+	INTEL_VGA_DEVICE(0x5A85, info)  /* APL HD Graphics 500 */


 #define INTEL_KBL_GT1_IDS(info) \
  INTEL_VGA_DEVICE(0x5913, info), /* ULT GT1.5 */ \

Signature · 1 line
2.5.0
Quoted 5 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx