Skip to contentSkip to conversation

ch7006: correctly handling failed allocation

PATCH Applied Insu Yun 2 participants 2 messages Jan 28, 2016 – Feb 9, 2016

Subsystems (2)
lore
Share & tools
lore

Insu Yun

author
#0 lore raw

PATCH 1/1 ch7006: correctly handling failed allocation

Since drm_property_create_range can be failed in memory pressure, it needs to be checked and return -ENOMEM.

---
 drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i2c/ch7006_drv.c +2 -0
index 90db5f4..0594c45 100644
@@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder,
 	drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names);
 
 	priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2);
+	if (!priv->scale_property)
+		return -ENOMEM;
 
 	drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property,
 				      priv->select_subconnector);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · Insu Yun

Since drm_property_create_range can be failed in memory pressure, it needs to be checked and return -ENOMEM.

Applied to drm-misc, thanks.
-Daniel

Quoted 20 lines
---
 drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i2c/ch7006_drv.c +2 -0
index 90db5f4..0594c45 100644
@@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder,
 	drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names);
 
 	priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2);
+	if (!priv->scale_property)
+		return -ENOMEM;
 
 	drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property,
 				      priv->select_subconnector);
Signature · 1 line
1.9.1
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel