Skip to contentSkip to conversation

Update most Freescale packages

PATCH New Gary Bisson 3 participants 30 messages Jan 30, 2016 – Feb 2, 2016 Arm i.MX and Layerscape

lore
Share & tools
lore

Gary Bisson

author
#0 lore raw

cover Update most Freescale packages

Hi all,

Here is yet another series to update most of Freescale packages. I've skipped the graphics update for now since not all the manufacturers have a kernel ready for it. Plus it can be easily updated separately.

Actually, NXP/Vivante now releases a kernel module which allows to have a matching driver for the latest binaries. However this implies some defconfig modification as follows:
https://github.com/Freescale/meta-fsl-arm/blob/master/classes/fsl-vivante-kernel-driver-handler.bbclass#L52

Not sure how to do that in Buildroot, maybe adding a linux post configure hook.

Anyway, all the other components (GStreamer plugins, codecs & firmwares) are updated. The big change of this series is the update of the gst1-imx plugin. Since the i.MX7 SoC is coming and does not include VPU nor GPU, the plugin dependencies have been modified to it can be built without graphics nor video codecs selected. Also, the plugin now relies on libimxvpuapi which is a community-driven alternative of libfslvpuwrap.

The testing has been done on a SabreLite with the following defconfig:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_FPU_NEON=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1" BR2_ROOTFS_POST_BUILD_SCRIPT="board/boundarydevices/nitrogen6x/post-build.sh"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_TARBALL=y BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/linux-imx6/tarball/d7a412b/linux-imx6-d7a412b.tar.gz" BR2_LINUX_KERNEL_DEFCONFIG="boundary"
BR2_LINUX_KERNEL_ZIMAGE=y
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabrelite"
BR2_LINUX_KERNEL_INSTALL_TARGET=y
BR2_PACKAGE_ALSA_UTILS=y
BR2_PACKAGE_ALSA_UTILS_ALSACONF=y
BR2_PACKAGE_ALSA_UTILS_AMIDI=y
BR2_PACKAGE_ALSA_UTILS_AMIXER=y
BR2_PACKAGE_ALSA_UTILS_APLAY=y
BR2_PACKAGE_ALSA_UTILS_APLAYMIDI=y
BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST=y
BR2_PACKAGE_GSTREAMER=y
BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC=y
BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC=y
BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA=y
BR2_PACKAGE_GST_PLUGINS_GOOD=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_AUTODETECT=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUGUTILS=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLV=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ID3DEMUX=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_MATROSKA=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_VIDEOBOX=y
BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_V4L2=y
BR2_PACKAGE_GST_FSL_PLUGINS=y
BR2_PACKAGE_GSTREAMER1=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORATE=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOTESTSRC=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ENCODING=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_GIO=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_SUBPARSE=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_TCP=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOTESTSRC=y
BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA=y
BR2_PACKAGE_GST1_PLUGINS_GOOD=y
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUDIOPARSERS=y
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_AUTODETECT=y
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_DEBUGUTILS=y
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_FLV=y
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ID3DEMUX=y
BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA=y
BR2_PACKAGE_GST1_IMX=y
BR2_PACKAGE_GST1_IMX_V4L2_PLUGIN=y
BR2_PACKAGE_GST1_IMX_VPU_PLUGIN=y
BR2_PACKAGE_GST1_IMX_EGL_PLUGIN=y
BR2_PACKAGE_GST1_IMX_G2D_PLUGIN=y
BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q=y
BR2_PACKAGE_IMX_GPU_VIV=y
BR2_PACKAGE_IMX_GPU_VIV_APITRACE=y
BR2_PACKAGE_IMX_GPU_VIV_EXAMPLES=y
BR2_PACKAGE_IMX_GPU_VIV_GMEM_INFO=y
BR2_PACKAGE_FONTCONFIG=y
BR2_PACKAGE_HOST_MKE2IMG=y
BR2_PACKAGE_HOST_UBOOT_TOOLS=y

Regards,
Gary

Gary Bisson (10):
firmware-imx: bump to version 5.2
imx-kobs: bump to version 5.1
imx-lib: bump to version 5.1
freescale-imx: remove FREESCALE_IMX_VERSION
libfslcodec: bump to version 4.0.7
libfslparser: bump to version 4.0.7
libfslvpuwrap: bump to version 1.0.61
libimxvpuapi: add new package
gst1-plugins-bad: add install to staging directory
gst1-imx: bump to version 0.12.0

 package/Config.in                                  |  1 +
 .../freescale-imx/firmware-imx/firmware-imx.hash   |  2 +-
 package/freescale-imx/firmware-imx/firmware-imx.mk |  9 ++--
 package/freescale-imx/freescale-imx.mk             |  1 -
 package/freescale-imx/imx-kobs/imx-kobs.hash       |  2 +-
 package/freescale-imx/imx-kobs/imx-kobs.mk         |  2 +-
 package/freescale-imx/imx-lib/imx-lib.hash         |  2 +-
 package/freescale-imx/imx-lib/imx-lib.mk           |  4 +-
 package/gstreamer1/gst1-imx/Config.in              | 58 ++++++++++++++++++----
 package/gstreamer1/gst1-imx/gst1-imx.mk            | 15 +++++-
 .../gst1-plugins-bad/gst1-plugins-bad.mk           |  1 +
 package/libfslcodec/libfslcodec.hash               |  2 +-
 package/libfslcodec/libfslcodec.mk                 |  2 +-
 package/libfslparser/libfslparser.hash             |  2 +-
 package/libfslparser/libfslparser.mk               |  2 +-
 package/libfslvpuwrap/libfslvpuwrap.hash           |  2 +-
 package/libfslvpuwrap/libfslvpuwrap.mk             |  2 +-
 package/libimxvpuapi/Config.in                     | 10 ++++
 package/libimxvpuapi/libimxvpuapi.mk               | 35 +++++++++++++
 19 files changed, 127 insertions(+), 27 deletions(-)
 create mode 100644 package/libimxvpuapi/Config.in
 create mode 100644 package/libimxvpuapi/libimxvpuapi.mk
Signature · 1 line
2.6.4
author
#1 lore raw

PATCH 1/10 firmware-imx: bump to version 5.2

Use a different versioning schema based on package versioning instead of BSP version. This way, if a new BSP version does not bump this package, we can keep this package unchanged as well.

VPU firmware upgraded to v3.1.1_r46067
- Low Latency fixes for H.264 encoder
- Wrong frame number fix for H.264 decoder
- Decode failure fix for H.264 decoder with multi-SPS/PPS headers

The package adds the EPDC waveforms and the needed changes to properly install those were done in the firmware-imx.inc file.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/d869826
https://github.com/Freescale/meta-fsl-arm/commit/075a5b1

This package has been implicitely tested through gstreamer as the plugins rely on them for vpu decoding for instance:

 # gst-launch-1.0 filesrc location=/root/tears_of_steel_1080p.webm ! \
   matroskademux ! imxvpudec ! imxipuvideosink
Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/firmware-imx/firmware-imx.hash | 2 +-
 package/freescale-imx/firmware-imx/firmware-imx.mk   | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)
package/freescale-imx/firmware-imx/firmware-imx.hash +1 -1
index 0b89c4b..06d5a54 100644
@@ -1,2 +1,2 @@
 # locally computed
-sha256 1f09acd4d605efc78a0672068a658cb16274811d2f444cf3ae7aaa075266746f  firmware-imx-3.14.28-1.0.0.bin
+sha256 8cc2df128c0e2d2f5224d73389fbe6e4d6fa9ede76f8c0a9adaf7ec0986d0f1f  firmware-imx-5.2.bin
package/freescale-imx/firmware-imx/firmware-imx.mk +6 -3
index 9cab5c2..51c428f 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FIRMWARE_IMX_VERSION = $(FREESCALE_IMX_VERSION)
+FIRMWARE_IMX_VERSION = 5.2
 FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE)
 FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
 

@@ -13,17 +13,20 @@ FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \
 FIRMWARE_IMX_LICENSE_FILES = EULA COPYING
 FIRMWARE_IMX_REDISTRIBUTE = NO
 
-FIRMWARE_IMX_BLOBS = ath6k sdma vpu
+FIRMWARE_IMX_BLOBS = sdma vpu
 
 define FIRMWARE_IMX_EXTRACT_CMDS
 	$(call FREESCALE_IMX_EXTRACT_HELPER,$(DL_DIR)/$(FIRMWARE_IMX_SOURCE))
 endef
 
 define FIRMWARE_IMX_INSTALL_TARGET_CMDS
-	mkdir -p $(TARGET_DIR)/lib/firmware
+	mkdir -p $(TARGET_DIR)/lib/firmware/imx
 	for blobdir in $(FIRMWARE_IMX_BLOBS); do \
 		cp -r $(@D)/firmware/$${blobdir} $(TARGET_DIR)/lib/firmware; \
 	done
+	cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx; \
+	mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \
+	   $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw;
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.6.4
#2 lore raw

PATCH 1/10 firmware-imx: bump to version 5.2

Dear Gary Bisson,

Quoted 2 lines · Gary Bisson

The package adds the EPDC waveforms and the needed changes to properly install those were done in the firmware-imx.inc file.

I guess you wanted to say firmware-imx.mk. Maybe you've done too much Yocto :-)

package/freescale-imx/firmware-imx/firmware-imx.mk FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \ · line 27

Quoted 7 lines

define FIRMWARE_IMX_INSTALL_TARGET_CMDS

package/freescale-imx/firmware-imx/firmware-imx.mk +2 -1
-	mkdir -p $(TARGET_DIR)/lib/firmware
+	mkdir -p $(TARGET_DIR)/lib/firmware/imx
 	for blobdir in $(FIRMWARE_IMX_BLOBS); do \
 		cp -r $(@D)/firmware/$${blobdir} $(TARGET_DIR)/lib/firmware; \
 	done
+	cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx; \

The ; \ is not needed.

package/freescale-imx/firmware-imx/firmware-imx.mk FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \ · line 29

Quoted 2 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +2 -0
+	mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \
+	   $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw;

The final is not needed.

Also, this rename is a bit weird, maybe a comment would have been good.

I've fixed the typos and applied.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH 1/10 firmware-imx: bump to version 5.2

Thomas, All,

Quoted 9 lines · Thomas Petazzoni

Dear Gary Bisson,

Quoted 2 lines · Gary Bisson

The package adds the EPDC waveforms and the needed changes to properly install those were done in the firmware-imx.inc file.

I guess you wanted to say firmware-imx.mk. Maybe you've done too much Yocto :-)

Haha, no trust me I try not to. It's just a bad copy/paste from the Yocto commit log.

Quoted 8 lines

package/freescale-imx/firmware-imx/firmware-imx.mk FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \ · line 27

Quoted 7 lines

define FIRMWARE_IMX_INSTALL_TARGET_CMDS

package/freescale-imx/firmware-imx/firmware-imx.mk +2 -1
-     mkdir -p $(TARGET_DIR)/lib/firmware
+     mkdir -p $(TARGET_DIR)/lib/firmware/imx
      for blobdir in $(FIRMWARE_IMX_BLOBS); do \
              cp -r $(@D)/firmware/$${blobdir} $(TARGET_DIR)/lib/firmware; \
      done
+     cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx; \
Quoted 8 lines

The ; \ is not needed.

package/freescale-imx/firmware-imx/firmware-imx.mk FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \ · line 29

Quoted 2 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +2 -0
+     mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \
+        $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw;

The final is not needed.

Also, this rename is a bit weird, maybe a comment would have been good.

I agree, my guess is that the driver is looking for the .fw file but the package includes this strange .nonrestricted extension. So I just copied what was done in the Yocto package.

Regards,
Gary

author
#4 lore raw

PATCH 2/10 imx-kobs: bump to version 5.1

In reply to Gary Bisson

Use a different versioning schema based on package versioning instead of BSP version. This way, if a new BSP version does not bump this package, we can keep this package unchanged as well.

Changelog since 3.14.28-1.0.0_ga:
- Add fixes for maximum ecc strength for each platform.
- Add mx7 boot config support.
- Add i.MX 6UltraLite support.
- Join the ecc with real FCB data when not byte-aligned.
- Generalize the encode_bch_ecc function for different configurations.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/8d47a2e
https://github.com/Freescale/meta-fsl-arm/commit/70edf16

Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/imx-kobs/imx-kobs.hash | 2 +-
 package/freescale-imx/imx-kobs/imx-kobs.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/freescale-imx/imx-kobs/imx-kobs.hash +1 -1
index 13373ea..477f231 100644
@@ -1,2 +1,2 @@
 # locally computed
-sha256 cfac042f5c96731205c397a4a6b3ed966f804569ae4d0e2685d22fdf6bdc9eb7  imx-kobs-3.14.28-1.0.0.tar.gz
+sha256 28c7356187ae26a2b37fb37a4b7bfdb63b3628b72d737d897ae6d5b969fbb51a  imx-kobs-5.1.tar.gz
package/freescale-imx/imx-kobs/imx-kobs.mk +1 -1
index 02c5cad..bf01567 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-IMX_KOBS_VERSION = $(FREESCALE_IMX_VERSION)
+IMX_KOBS_VERSION = 5.1
 IMX_KOBS_SITE = $(FREESCALE_IMX_SITE)
 IMX_KOBS_LICENSE = GPLv2+
 IMX_KOBS_LICENSE_FILES = COPYING
Signature · 1 line
2.6.4
Applied
#5 lore raw

PATCH 2/10 imx-kobs: bump to version 5.1

Dear Gary Bisson,

Quoted 15 lines · Gary Bisson

Use a different versioning schema based on package versioning instead of BSP version. This way, if a new BSP version does not bump this package, we can keep this package unchanged as well.

Changelog since 3.14.28-1.0.0_ga:
- Add fixes for maximum ecc strength for each platform.
- Add mx7 boot config support.
- Add i.MX 6UltraLite support.
- Join the ecc with real FCB data when not byte-aligned.
- Generalize the encode_bch_ecc function for different configurations.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/8d47a2e
https://github.com/Freescale/meta-fsl-arm/commit/70edf16

Quoted 5 lines
Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/imx-kobs/imx-kobs.hash | 2 +-
 package/freescale-imx/imx-kobs/imx-kobs.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#6 lore raw

PATCH 3/10 imx-lib: bump to version 5.1

In reply to Gary Bisson

Change version to be independent of BSP version. This limits confusion on future BSP updates that do not include imx-lib updates.

Changelog since 3.14.28-1.0.0_ga:
- Add i.MX 7D support.
- Change LICENSE file.
- Enable pxp libraries for i.MX 6UltraLite.
- Fix rng and shara2 to exclude the 6UL platform to avoid build breaks

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/b299454
https://github.com/Freescale/meta-fsl-arm/commit/5f28af0

Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/imx-lib/imx-lib.hash | 2 +-
 package/freescale-imx/imx-lib/imx-lib.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
package/freescale-imx/imx-lib/imx-lib.hash +1 -1
index 85f0a40..8e4bd73 100644
@@ -1,2 +1,2 @@
 # locally computed
-sha256 46022817d25f154b60247fdcbb87216e23e553bd88ec9664b1b5d5911e7aa2a2  imx-lib-3.14.28-1.0.0.tar.gz
+sha256 2b4547ffb1de328cf8997a09a423c6f015d808493efd11a98a5d42c6497e3445  imx-lib-5.1.tar.gz
package/freescale-imx/imx-lib/imx-lib.mk +2 -2
index e160cca..b49357b 100644
@@ -4,10 +4,10 @@
 #
 ################################################################################
 
-IMX_LIB_VERSION = $(FREESCALE_IMX_VERSION)
+IMX_LIB_VERSION = 5.1
 IMX_LIB_SITE = $(FREESCALE_IMX_SITE)
 IMX_LIB_LICENSE = LGPLv2.1+
-IMX_LIB_LICENSE_FILES = pxp/pxp_lib.h
+IMX_LIB_LICENSE_FILES = COPYING-LGPL-2.1
 
 IMX_LIB_INSTALL_STAGING = YES
Signature · 1 line
2.6.4
Applied
#7 lore raw

PATCH 3/10 imx-lib: bump to version 5.1

Dear Gary Bisson,

Quoted 13 lines · Gary Bisson

Change version to be independent of BSP version. This limits confusion on future BSP updates that do not include imx-lib updates.

Changelog since 3.14.28-1.0.0_ga:
- Add i.MX 7D support.
- Change LICENSE file.
- Enable pxp libraries for i.MX 6UltraLite.
- Fix rng and shara2 to exclude the 6UL platform to avoid build breaks

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/b299454
https://github.com/Freescale/meta-fsl-arm/commit/5f28af0

Quoted 5 lines
Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/imx-lib/imx-lib.hash | 2 +-
 package/freescale-imx/imx-lib/imx-lib.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#8 lore raw

PATCH 4/10 freescale-imx: remove FREESCALE_IMX_VERSION

In reply to Gary Bisson

As all the packages now have a version which doesn't depend on the BSP version.

Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/freescale-imx.mk | 1 -
 1 file changed, 1 deletion(-)
package/freescale-imx/freescale-imx.mk +0 -1
index d4f8967..e8ca77f 100644
@@ -4,7 +4,6 @@
 #
 ################################################################################
 
-FREESCALE_IMX_VERSION = 3.14.28-1.0.0
 FREESCALE_IMX_SITE = http://www.freescale.com/lgfiles/NMG/MAD/YOCTO
 
 # Helper for self-extracting binaries distributed by Freescale.
Signature · 1 line
2.6.4
Applied
#9 lore raw

PATCH 4/10 freescale-imx: remove FREESCALE_IMX_VERSION

Dear Gary Bisson,

Quoted 7 lines · Gary Bisson

As all the packages now have a version which doesn't depend on the BSP version.

Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/freescale-imx.mk | 1 -
 1 file changed, 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#10 lore raw

PATCH 5/10 libfslcodec: bump to version 4.0.7

In reply to Gary Bisson

Changelog since 4.0.3:
- Add mx7 SoC support.
- Add test binary to release package.
- Fix segmentation fault issue with only standard build.
- Build std only for arm11 and arm12.
- Fix some mp3_dec noise issue of c code for arm11 and arm9.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/47b2677
https://github.com/Freescale/meta-fsl-arm/commit/c88fd22
https://github.com/Freescale/meta-fsl-arm/commit/3220a4c

This package has been implicitely tested through gstreamer as the 0.10 plugin relies on it:

 # gst-launch-0.10 playbin uri=file:///root/tears_of_steel_1080p.webm
Signed-off-by Gary Bisson <[email protected]>
---
 package/libfslcodec/libfslcodec.hash | 2 +-
 package/libfslcodec/libfslcodec.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/libfslcodec/libfslcodec.hash +1 -1
index 6a41be1..d977a66 100644
@@ -1,2 +1,2 @@
 # locally computed
-sha256	0d0ff933eed0a021763115b9c8ae812c6376a19bbd95e555d89ea7404f6c8f2f  libfslcodec-4.0.3.bin
+sha256	de1251286ebbc1541452f2f70fbd73e42c58f95630d65d1f9aaabf10a6caa38f  libfslcodec-4.0.7.bin
package/libfslcodec/libfslcodec.mk +1 -1
index 473d662..e151c66 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBFSLCODEC_VERSION = 4.0.3
+LIBFSLCODEC_VERSION = 4.0.7
 LIBFSLCODEC_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLCODEC_SOURCE = libfslcodec-$(LIBFSLCODEC_VERSION).bin
 LIBFSLCODEC_INSTALL_STAGING = YES
Signature · 1 line
2.6.4
Applied
#11 lore raw

PATCH 5/10 libfslcodec: bump to version 4.0.7

Dear Gary Bisson,

Quoted 14 lines · Gary Bisson

Changelog since 4.0.3:
- Add mx7 SoC support.
- Add test binary to release package.
- Fix segmentation fault issue with only standard build.
- Build std only for arm11 and arm12.
- Fix some mp3_dec noise issue of c code for arm11 and arm9.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/47b2677
https://github.com/Freescale/meta-fsl-arm/commit/c88fd22
https://github.com/Freescale/meta-fsl-arm/commit/3220a4c

This package has been implicitely tested through gstreamer as the 0.10 plugin relies on it:

Quoted 7 lines
 # gst-launch-0.10 playbin uri=file:///root/tears_of_steel_1080p.webm
Signed-off-by Gary Bisson <[email protected]>
---
 package/libfslcodec/libfslcodec.hash | 2 +-
 package/libfslcodec/libfslcodec.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#12 lore raw

PATCH 6/10 libfslparser: bump to version 4.0.7

In reply to Gary Bisson

Changelog:
- Add h264 parser version.
- Support wide and 'ms 0x0 0x11' adpcm tag.
- Support hev1 tag for hevc video codec.
- TS segment fault.
- Improve mkv parser's loading time when create parser with large size file.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/6406ad4
https://github.com/Freescale/meta-fsl-arm/commit/09a532c
https://github.com/Freescale/meta-fsl-arm/commit/371df94

This package has been implicitely tested through gstreamer as the 0.10 plugin relies on it:

 # gst-launch-0.10 playbin uri=file:///root/tears_of_steel_1080p.webm
Signed-off-by Gary Bisson <[email protected]>
---
 package/libfslparser/libfslparser.hash | 2 +-
 package/libfslparser/libfslparser.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/libfslparser/libfslparser.hash +1 -1
index 19ee12e..976a2d2 100644
@@ -1,2 +1,2 @@
 # locally computed
-sha256	9db10ca6a61c8fdbe91b55b65d084dcbb5f9cfb58b088996c7dd2d6dc8385730  libfslparser-4.0.3.bin
+sha256	e7c248e64db03c3ddd84f50ae408e560f8f5819e58c487a5dec5141bc384ae83  libfslparser-4.0.7.bin
package/libfslparser/libfslparser.mk +1 -1
index 2b53d62..c5efc85 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBFSLPARSER_VERSION = 4.0.3
+LIBFSLPARSER_VERSION = 4.0.7
 LIBFSLPARSER_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLPARSER_SOURCE = libfslparser-$(LIBFSLPARSER_VERSION).bin
 LIBFSLPARSER_INSTALL_STAGING = YES
Signature · 1 line
2.6.4
Applied
#13 lore raw

PATCH 6/10 libfslparser: bump to version 4.0.7

Dear Gary Bisson,

Quoted 15 lines · Gary Bisson

Changelog:
- Add h264 parser version.
- Support wide and 'ms 0x0 0x11' adpcm tag.
- Support hev1 tag for hevc video codec.
- TS segment fault.
- Improve mkv parser's loading time when create parser with large size file.

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/6406ad4
https://github.com/Freescale/meta-fsl-arm/commit/09a532c
https://github.com/Freescale/meta-fsl-arm/commit/371df94

This package has been implicitely tested through gstreamer as the 0.10 plugin relies on it:

Quoted 7 lines
 # gst-launch-0.10 playbin uri=file:///root/tears_of_steel_1080p.webm
Signed-off-by Gary Bisson <[email protected]>
---
 package/libfslparser/libfslparser.hash | 2 +-
 package/libfslparser/libfslparser.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#14 lore raw

PATCH 7/10 libfslvpuwrap: bump to version 1.0.61

In reply to Gary Bisson

Changelog:
- Enable resolution change for H.263 and VP8

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/f11936b

This package has been implicitely tested through gstreamer as the plugins rely on it for vpu decoding:

 # gst-launch-0.10 playbin uri=file:///root/tears_of_steel_1080p.webm
 # gst-launch-1.0 playbin uri=file:///root/tears_of_steel_1080p.webm
 # gst-launch-1.0 filesrc location=/root/tears_of_steel_1080p.webm ! \
   matroskademux ! imxvpudec ! imxipuvideosink
Signed-off-by Gary Bisson <[email protected]>
---
 package/libfslvpuwrap/libfslvpuwrap.hash | 2 +-
 package/libfslvpuwrap/libfslvpuwrap.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/libfslvpuwrap/libfslvpuwrap.hash +1 -1
index e7ca1a8..8e6ba61 100644
@@ -1,2 +1,2 @@
 # locally computed
-sha256	a278eb18ec24230166ac39e2eadf7b934798f0432654c2e24c4cb69c3ac1cf0f  libfslvpuwrap-1.0.58.bin
+sha256	e4bfe218d17ec66acf8cd97d08fef8ef71ab6762d4c8cf0d0193eca5f599b4c9  libfslvpuwrap-1.0.61.bin
package/libfslvpuwrap/libfslvpuwrap.mk +1 -1
index 7669c63..b3d6f0c 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBFSLVPUWRAP_VERSION = 1.0.58
+LIBFSLVPUWRAP_VERSION = 1.0.61
 LIBFSLVPUWRAP_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLVPUWRAP_SOURCE = libfslvpuwrap-$(LIBFSLVPUWRAP_VERSION).bin
 LIBFSLVPUWRAP_DEPENDENCIES = imx-vpu
Signature · 1 line
2.6.4
Applied
#15 lore raw

PATCH 7/10 libfslvpuwrap: bump to version 1.0.61

Dear Gary Bisson,

Quoted 13 lines · Gary Bisson

Changelog:
- Enable resolution change for H.263 and VP8

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/f11936b

This package has been implicitely tested through gstreamer as the plugins rely on it for vpu decoding:

 # gst-launch-0.10 playbin uri=file:///root/tears_of_steel_1080p.webm
 # gst-launch-1.0 playbin uri=file:///root/tears_of_steel_1080p.webm
 # gst-launch-1.0 filesrc location=/root/tears_of_steel_1080p.webm ! \
   matroskademux ! imxvpudec ! imxipuvideosink
Quoted 5 lines
Signed-off-by Gary Bisson <[email protected]>
---
 package/libfslvpuwrap/libfslvpuwrap.hash | 2 +-
 package/libfslvpuwrap/libfslvpuwrap.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#16 lore raw

PATCH 8/10 libimxvpuapi: add new package

In reply to Gary Bisson

This is a library for using the i.MX6 VPU. It is an alternative to libfslvpuwrap, hosted on Github, and has an API that features several improvements over libfslvpuwrap, which include:

* User-defined context information associated with input frames, which is passed on to corresponding output frames (to be able to identify which input frame produced which output frame)
* Groundwork for future DMA-BUF/BMM/ION/CMA allocator integration, using file descriptors instead of physical addresses
* Indicators for when it is safe to try to decode frames, which is critical in multi-threaded playback cases
* Simplified, higher-level JPEG en/decoding API, based on the VPU MJPEG codec; useful for picture viewing without the extra boilerplate for VPU-based en/decoding

Changelog 0.10.0 -> 0.10.1:
- add debian packaging files
- update waf to version 1.8.16
- add workaround in wscript to prevent stale pkg-config .pc files
- fix memory leak by adding missing IOFreeVirtMem() call in vpulib backend

This patch is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/e519d6c
https://github.com/Freescale/meta-fsl-arm/commit/1dd6a5b

This package has been implicitely tested through gstreamer as the plugins rely on it for vpu decoding:

 # gst-launch-1.0 playbin uri=file:///root/tears_of_steel_1080p.webm
Signed-off-by Gary Bisson <[email protected]>
---
 package/Config.in                    |  1 +
 package/libimxvpuapi/Config.in       | 10 ++++++++++
 package/libimxvpuapi/libimxvpuapi.mk | 35 +++++++++++++++++++++++++++++++++++
 3 files changed, 46 insertions(+)
 create mode 100644 package/libimxvpuapi/Config.in
 create mode 100644 package/libimxvpuapi/libimxvpuapi.mk
package/Config.in +1 -0
index 09c2b40..d3e5e30 100644
@@ -1033,6 +1033,7 @@ menu "Multimedia"
 	source "package/libfslparser/Config.in"
 	source "package/libfslvpuwrap/Config.in"
 	source "package/libhdhomerun/Config.in"
+	source "package/libimxvpuapi/Config.in"
 	source "package/libmatroska/Config.in"
 	source "package/libmms/Config.in"
 	source "package/libmpeg2/Config.in"
package/libimxvpuapi/Config.in new file +10 -0
new file mode 100644
index 0000000..222aa76
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBIMXVPUAPI
+	bool "libimxvpuapi"
+	depends on BR2_arm # Only relevant for i.MX
+	select BR2_PACKAGE_FREESCALE_IMX
+	select BR2_PACKAGE_IMX_VPU
+	help
+	  This library provides an API for using the iMX6 VPU video engine. It
+	  is an alternative to Freescale's VPU wrapper. Both the wrapper and
+	  this library are layered on top of imx-vpu, the low-level iMX6 VPU
+	  interface.
package/libimxvpuapi/libimxvpuapi.mk new file +35 -0
new file mode 100644
index 0000000..ff9282d
@@ -0,0 +1,35 @@
+################################################################################
+#
+# libimxvpuapi
+#
+################################################################################
+
+LIBIMXVPUAPI_VERSION = 0.10.1
+LIBIMXVPUAPI_SITE = $(call github,Freescale,libimxvpuapi,$(LIBIMXVPUAPI_VERSION))
+LIBIMXVPUAPI_LICENSE = LGPLv2.1
+LIBIMXVPUAPI_LICENSE_FILES = LICENSE
+LIBIMXVPUAPI_DEPENDENCIES = host-pkgconf host-python imx-vpu
+LIBIMXVPUAPI_INSTALL_STAGING = YES
+
+define LIBIMXVPUAPI_CONFIGURE_CMDS
+	cd $(@D); \
+	$(TARGET_CONFIGURE_OPTS) $(HOST_DIR)/usr/bin/python2 ./waf configure \
+		--prefix=/usr
+endef
+
+define LIBIMXVPUAPI_BUILD_CMDS
+	cd $(@D); \
+	$(HOST_DIR)/usr/bin/python2 ./waf build -j $(PARALLEL_JOBS)
+endef
+
+define LIBIMXVPUAPI_INSTALL_STAGING_CMDS
+	cd $(@D); \
+	$(HOST_DIR)/usr/bin/python2 ./waf --destdir=$(STAGING_DIR) install
+endef
+
+define LIBIMXVPUAPI_INSTALL_TARGET_CMDS
+	cd $(@D); \
+	$(HOST_DIR)/usr/bin/python2 ./waf --destdir=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.6.4
#17 lore raw

PATCH 8/10 libimxvpuapi: add new package

Dear Gary Bisson,

package/Config.in menu "Multimedia" · line 1036

Quoted 9 lines · Gary Bisson
package/Config.in +1 -0
index 09c2b40..d3e5e30 100644
@@ -1033,6 +1033,7 @@ menu "Multimedia"
 	source "package/libfslparser/Config.in"
 	source "package/libfslvpuwrap/Config.in"
 	source "package/libhdhomerun/Config.in"
+	source "package/libimxvpuapi/Config.in"

Why isn't it part of the package/freescale/ directory ? Because it isn't sourced from the same site ?

Quoted 9 lines
package/Config.in +0 -0
 	source "package/libmatroska/Config.in"
 	source "package/libmms/Config.in"
 	source "package/libmpeg2/Config.in"
package/libimxvpuapi/Config.in new file +0 -0
new file mode 100644
index 0000000..222aa76

package/libimxvpuapi/Config.in line 5

Quoted 5 lines
package/libimxvpuapi/Config.in new file +5 -0
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBIMXVPUAPI
+	bool "libimxvpuapi"
+	depends on BR2_arm # Only relevant for i.MX
+	select BR2_PACKAGE_FREESCALE_IMX
+	select BR2_PACKAGE_IMX_VPU

I am wondering if the first one shouldn't be a "depends on", but I'm not sure. What do other think ?

package/libimxvpuapi/Config.in line 10

Quoted 5 lines
package/libimxvpuapi/Config.in new file +5 -0
+	help
+	  This library provides an API for using the iMX6 VPU video engine. It
+	  is an alternative to Freescale's VPU wrapper. Both the wrapper and
+	  this library are layered on top of imx-vpu, the low-level iMX6 VPU
+	  interface.

A URL to the upstream web page would be good. A github page is fine as a fallback if there's no real upstream web site.

Quoted 6 lines
package/libimxvpuapi/libimxvpuapi.mk new file +0 -0
new file mode 100644
index 0000000..ff9282d

package/libimxvpuapi/libimxvpuapi.mk line 9

Quoted 9 lines
package/libimxvpuapi/libimxvpuapi.mk new file +9 -0
@@ -0,0 +1,35 @@
+################################################################################
+#
+# libimxvpuapi
+#
+################################################################################
+
+LIBIMXVPUAPI_VERSION = 0.10.1
+LIBIMXVPUAPI_SITE = $(call github,Freescale,libimxvpuapi,$(LIBIMXVPUAPI_VERSION))
+LIBIMXVPUAPI_LICENSE = LGPLv2.1

License seems to be LGPLv2.1+.

Also, you forgot to include a hash file. Could you fix those issues and send an updated version?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#18 lore raw

PATCH 8/10 libimxvpuapi: add new package

Thomas, All,

Quoted 4 lines · Thomas Petazzoni

Dear Gary Bisson,

On Sat, 30 Jan 2016 12:45:55 +0100, Gary Bisson wrote:

Quoted 12 lines

package/Config.in menu "Multimedia" · line 1036

Quoted 9 lines
package/Config.in +1 -0
index 09c2b40..d3e5e30 100644
@@ -1033,6 +1033,7 @@ menu "Multimedia"
      source "package/libfslparser/Config.in"
      source "package/libfslvpuwrap/Config.in"
      source "package/libhdhomerun/Config.in"
+     source "package/libimxvpuapi/Config.in"

Why isn't it part of the package/freescale/ directory ? Because it isn't sourced from the same site ?

No actually my thought process was that this package is the equivalent of libfslvpuwrap which, for some reason, isn't part of the freescale-imx folder. Not sure why, I'm sure there's an historical reason behind it.

Quoted 18 lines
Quoted 9 lines
package/Config.in +0 -0
      source "package/libmatroska/Config.in"
      source "package/libmms/Config.in"
      source "package/libmpeg2/Config.in"
package/libimxvpuapi/Config.in new file +0 -0
new file mode 100644
index 0000000..222aa76

package/libimxvpuapi/Config.in line 5

Quoted 5 lines
package/libimxvpuapi/Config.in new file +5 -0
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBIMXVPUAPI
+     bool "libimxvpuapi"
+     depends on BR2_arm # Only relevant for i.MX
+     select BR2_PACKAGE_FREESCALE_IMX
+     select BR2_PACKAGE_IMX_VPU

I am wondering if the first one shouldn't be a "depends on", but I'm not sure. What do other think ?

Quoted 8 lines

package/libimxvpuapi/Config.in line 10

Quoted 5 lines
package/libimxvpuapi/Config.in new file +5 -0
+     help
+       This library provides an API for using the iMX6 VPU video engine. It
+       is an alternative to Freescale's VPU wrapper. Both the wrapper and
+       this library are layered on top of imx-vpu, the low-level iMX6 VPU
+       interface.

A URL to the upstream web page would be good. A github page is fine as a fallback if there's no real upstream web site.

Ok, I will add the Github page then:
https://github.com/Freescale/libimxvpuapi

Quoted 9 lines
Quoted 9 lines
package/libimxvpuapi/libimxvpuapi.mk new file +3 -0
new file mode 100644
index 0000000..ff9282d
@@ -0,0 +1,35 @@
+################################################################################
+#
+# libimxvpuapi
Quoted 8 lines

package/libimxvpuapi/libimxvpuapi.mk line 9

Quoted 6 lines
package/libimxvpuapi/libimxvpuapi.mk new file +6 -0
+#
+################################################################################
+
+LIBIMXVPUAPI_VERSION = 0.10.1
+LIBIMXVPUAPI_SITE = $(call github,Freescale,libimxvpuapi,$(LIBIMXVPUAPI_VERSION))
+LIBIMXVPUAPI_LICENSE = LGPLv2.1

License seems to be LGPLv2.1+.

The LICENSE file says LGPLv2.1 but indeed the source code headers state the LGPLv2.1+. Who wins then?
https://github.com/Freescale/libimxvpuapi/blob/master/imxvpuapi/imxvpuapi_jpeg.c#L7
https://github.com/Freescale/libimxvpuapi/blob/master/LICENSE

Quoted 2 lines

Also, you forgot to include a hash file. Could you fix those issues and send an updated version?

I might have missed an update, are we providing hash even for Github projects now?

Regards,
Gary

#19 lore raw

PATCH 8/10 libimxvpuapi: add new package

Hello,

Quoted 13 lines · Gary Bisson
Quoted 4 lines
Quoted 4 lines
package/Config.in +0 -0
index 09c2b40..d3e5e30 100644
Quoted 8 lines

package/Config.in menu "Multimedia" · line 1036

Quoted 5 lines
package/Config.in +1 -0
@@ -1033,6 +1033,7 @@ menu "Multimedia"
      source "package/libfslparser/Config.in"
      source "package/libfslvpuwrap/Config.in"
      source "package/libhdhomerun/Config.in"
+     source "package/libimxvpuapi/Config.in"

Why isn't it part of the package/freescale/ directory ? Because it isn't sourced from the same site ?

Quoted 4 lines

No actually my thought process was that this package is the equivalent of libfslvpuwrap which, for some reason, isn't part of the freescale-imx folder. Not sure why, I'm sure there's an historical reason behind it.

The main reason to have a sub-folder is to be able to share variables, such as _VERSION and _SITE. So if they are not shared with your package, there's indeed little reason to have it under package/freescale-imx/.

Now, the question is where it should appear in the menuconfig. I don't have a strong opinion here, but if libfslvpuwrap is in Multimedia, then I think your choice is OK. And indeed, libfslvpuwrap also selects BR2_PACKAGE_FREESCALE_IMX and BR2_PACKAGE_IMX_VPU, so let's do the same for your package.

Quoted 10 lines
Quoted 5 lines

package/Config.in menu "Multimedia" · line 1039

Quoted 3 lines
package/Config.in +3 -0
+LIBIMXVPUAPI_VERSION = 0.10.1
+LIBIMXVPUAPI_SITE = $(call github,Freescale,libimxvpuapi,$(LIBIMXVPUAPI_VERSION))
+LIBIMXVPUAPI_LICENSE = LGPLv2.1

License seems to be LGPLv2.1+.

The LICENSE file says LGPLv2.1 but indeed the source code headers state the LGPLv2.1+. Who wins then?
https://github.com/Freescale/libimxvpuapi/blob/master/imxvpuapi/imxvpuapi_jpeg.c#L7
https://github.com/Freescale/libimxvpuapi/blob/master/LICENSE

It's not a question of who wins. All software under GPLvX+ or LGPLvX+ will have the license text of GPLvX or LGPLvX in its COPYING/LICENSE file. It doesn't change the fact that the source is distributed under GPLvX+ / LGPLvX+, which means that the recipient can chose either GPLvX or any later version of the GPL (ditto LGPLvX).

Quoted 5 lines
Quoted 2 lines

Also, you forgot to include a hash file. Could you fix those issues and send an updated version?

I might have missed an update, are we providing hash even for Github projects now?

As explained on IRC, Github changed the way they generate tarballs, and they now seem to generate stable tarballs (i.e tarballs that have the exact same contents for a given tag/commit of a given project).

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#20 lore raw

PATCH 9/10 gst1-plugins-bad: add install to staging directory

In reply to Gary Bisson

gst1-imx package links against libgstphotography for its imxv4l2src plugin.

Signed-off-by Gary Bisson <[email protected]>
---
 package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 1 +
 1 file changed, 1 insertion(+)
package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk +1 -0
index f9f8558..3a097e8 100644
@@ -7,6 +7,7 @@
 GST1_PLUGINS_BAD_VERSION = 1.6.3
 GST1_PLUGINS_BAD_SOURCE = gst-plugins-bad-$(GST1_PLUGINS_BAD_VERSION).tar.xz
 GST1_PLUGINS_BAD_SITE = http://gstreamer.freedesktop.org/src/gst-plugins-bad
+GST1_PLUGINS_BAD_INSTALL_STAGING = YES
 GST1_PLUGINS_BAD_LICENSE_FILES = COPYING COPYING.LIB
 # Unknown and GPL licensed plugins will append to GST1_PLUGINS_BAD_LICENSE if
 # enabled.
Signature · 1 line
2.6.4
Applied
#21 lore raw

PATCH 9/10 gst1-plugins-bad: add install to staging directory

Dear Gary Bisson,

Quoted 7 lines · Gary Bisson

gst1-imx package links against libgstphotography for its imxv4l2src plugin.

Signed-off-by Gary Bisson <[email protected]>
---
 package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#22 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

In reply to Gary Bisson

Changelog:
* vpu:
- Completely rewritten plugin code; elements now based on libimxvpuapi instead of libfslvpuwrap
- imxvpuenc_h264 inserts SPS/PPS data in front of I/IDR frames
- imxvpuenc_mjpeg's quality factor actually has an effect, and is equivalent to the libjpeg's quality factor (it is used in exactly the same way to scale the quantization matrix' coefficients)
- the encoder's output buffers no longer have to use DMA memory; they use regular system memory instead
- new support in imxvpudec (referred to as "chroma interleaving") for NV12, NV16, NV24 as output formats as an alternative to the I420, Y42B, Y444 formats
- removed all of the system frame number tracking code, since it is unnecessary; Instead, the libimxvpuapi's context fields are used to associate input/output frames with GstVideoCodecFrame system frame numbers
- fix memory leaks related to missing buffer pool unref'ing

* imxv4l2videosrc:
- support for crop metadata
- element uses the width, height, etc. of the format that the device actually uses during operation (instead of default values)
- autofocus control support via GstPhotography
- fix incorrect GLib warnings
- fix segmentation fault when shutting down the element

* eglvivsink:
- remove extra g_free() calls, which lead to runtime errors
- remove GLESv2 VIVANTE link dependencies
- add Android platform
- manually retrieve VIV direct texture functions
with this and the link dependency elimination, this means that for platforms except the framebuffer one, no Vivante specific headers and libraries are needed anymore
- fix blocking issue in the Wayland platform mainloop

* improved and expanded documentation

* pxp: NV16 *is* supported after all (it was actually a bug in GStreamer pre-1.5.91)
NOTE: this does not break compatibility with GStreamer versions older than 1.5.91

* compositor: Update backported aggregator code to GStreamer 1.6

* blitter:
- error handling improvements
- add missing buffer pool unref'ing, which lead to memory leaks
- add missing compositor dependency to blitter base

* uniaudio:
- only build the uniaudio plugin if at least one codec was found during configuration
- disable plugin if the gstaudio library is not available
- add AAC profile field to the sink caps with GStreamer >= 1.4.4 to ensure the uniaudio decoder is only used for AAC-LC data

* ipu: increase fill frame width from 8 to 64 pixels to make IPU fill operations work with pre-3.14 Freescale kernels

* g2d: use padding pixels when setting surface parameters, fixing G2D failures with frame sizes that aren't aligned

* wscript:
- improve Android support
- fix installation paths for the common, blitter, compositor libraries

This is based on the Yocto equivalent:
https://github.com/Freescale/meta-fsl-arm/commit/cf7a088

However this package now offers a more flexible approach because it can be built without the GPU or VPU elements for devices based on SoCs that lack those features like the new i.MX7.

Tested with the following commands on i.MX6Q (IPU):

 # gst-launch-1.0 playbin uri=file:///root/tears_of_steel_1080p.webm
 # gst-launch-1.0 filesrc location=/root/tears_of_steel_1080p.webm ! \
   matroskademux ! imxvpudec ! imxipuvideosink
 # gst-launch-1.0 filesrc location=/root/tears_of_steel_1080p.webm ! \
   matroskademux ! imxvpudec ! imxeglvivsink

Tested with the following commands on i.MX6SX (PXP):

 # gst-launch-1.0 imxv4l2videosrc device=/dev/video1 ! imxpxpvideosink
Signed-off-by Gary Bisson <[email protected]>
---
 package/gstreamer1/gst1-imx/Config.in   | 58 ++++++++++++++++++++++++++++-----
 package/gstreamer1/gst1-imx/gst1-imx.mk | 15 +++++++--
 2 files changed, 62 insertions(+), 11 deletions(-)
package/gstreamer1/gst1-imx/Config.in +49 -9
index f7284f4..5f0da84 100644
@@ -1,19 +1,13 @@
 comment "gst1-imx needs an imx-specific Linux kernel to be built"
 	depends on BR2_arm && !BR2_LINUX_KERNEL
 
-# Required by imx-gpu-viv
-comment "gst1-imx needs an (e)glibc toolchain"
-	depends on BR2_arm
-	depends on !BR2_TOOLCHAIN_USES_GLIBC
-
-config BR2_PACKAGE_GST1_IMX
+menuconfig BR2_PACKAGE_GST1_IMX
 	bool "gst1-imx"
 	depends on BR2_LINUX_KERNEL
 	depends on BR2_arm # Only relevant for i.MX
-	depends on BR2_TOOLCHAIN_USES_GLIBC # imx-gpu-viv
-	depends on BR2_PACKAGE_IMX_GPU_VIV
-	depends on BR2_PACKAGE_LIBFSLVPUWRAP
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+	select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN
 	help
 	  This is a set of GStreamer 1.0 plugins for plugins for Freescale's
 	  i.MX6 platforms, with emphasis on video en/decoding using the VPU

@@ -25,3 +19,49 @@ config BR2_PACKAGE_GST1_IMX
 	  The software as a whole is currently in beta stage.
 
 	  https://github.com/Freescale/gstreamer-imx
+
+if BR2_PACKAGE_GST1_IMX
+
+config BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+	bool "IPU plugin"
+	help
+	  IPU plugin library
+
+config BR2_PACKAGE_GST1_IMX_PXP_PLUGIN
+	bool "PXP plugin"
+	help
+	  PXP plugin library
+
+config BR2_PACKAGE_GST1_IMX_V4L2_PLUGIN
+	bool "V4L2 plugin"
+	select BR2_PACKAGE_GST1_PLUGINS_BAD
+	help
+	  V4L2 plugin library
+
+config BR2_PACKAGE_GST1_IMX_VPU_PLUGIN
+	bool "VPU plugin"
+	select BR2_PACKAGE_LIBIMXVPUAPI
+	help
+	  VPU plugin library
+
+# Required by imx-gpu-viv
+comment "GPU sinks need an (e)glibc toolchain"
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+
+config BR2_PACKAGE_GST1_IMX_EGL_PLUGIN
+	bool "EGL plugin"
+	depends on BR2_TOOLCHAIN_USES_GLIBC # imx-gpu-viv
+	depends on BR2_PACKAGE_IMX_GPU_VIV
+	help
+	  EGL plugin library
+
+config BR2_PACKAGE_GST1_IMX_G2D_PLUGIN
+	bool "G2D plugin"
+	depends on BR2_TOOLCHAIN_USES_GLIBC # imx-gpu-viv
+	depends on BR2_PACKAGE_IMX_GPU_VIV
+	depends on BR2_PACKAGE_GST1_IMX_EGL_PLUGIN
+	select BR2_PACKAGE_IMX_GPU_VIV_G2D
+	help
+	  G2D plugin library
+
+endif
package/gstreamer1/gst1-imx/gst1-imx.mk +13 -2
index 8ede8ad..f3eac0a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_IMX_VERSION = 0.11.1
+GST1_IMX_VERSION = 0.12.0
 GST1_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GST1_IMX_VERSION))
 
 GST1_IMX_LICENSE = LGPLv2+

@@ -13,13 +13,23 @@ GST1_IMX_LICENSE_FILES = LICENSE
 GST1_IMX_INSTALL_STAGING = YES
 
 GST1_IMX_DEPENDENCIES += host-pkgconf host-python \
-	imx-gpu-viv gstreamer1 gst1-plugins-base libfslvpuwrap
+	gstreamer1 gst1-plugins-base
 
 # needs access to imx-specific kernel headers
 GST1_IMX_DEPENDENCIES += linux
 GST1_IMX_CONF_OPTS += --prefix="/usr" \
 	--kernel-headers="$(LINUX_DIR)/include"
 
+ifeq ($(BR2_PACKAGE_GST1_IMX_V4L2_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += gst1-plugins-bad
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_IMX_VPU_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += libimxvpuapi
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_IMX_EGL_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += imx-gpu-viv
 ifeq ($(BR2_PACKAGE_XLIB_LIBX11),y)
 GST1_IMX_DEPENDENCIES += xlib_libX11
 GST1_IMX_CONF_OPTS += --egl-platform=x11

@@ -31,6 +41,7 @@ else
 GST1_IMX_CONF_OPTS += --egl-platform=fb
 endif
 endif
+endif
 
 define GST1_IMX_CONFIGURE_CMDS
 	cd $(@D); \
Signature · 1 line
2.6.4
#23 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

Dear Gary Bisson,

package/gstreamer1/gst1-imx/Config.in line 14

Quoted 7 lines · Gary Bisson
package/gstreamer1/gst1-imx/Config.in +1 -3
-config BR2_PACKAGE_GST1_IMX
+menuconfig BR2_PACKAGE_GST1_IMX
 	bool "gst1-imx"
 	depends on BR2_LINUX_KERNEL
 	depends on BR2_arm # Only relevant for i.MX
-	depends on BR2_TOOLCHAIN_USES_GLIBC # imx-gpu-viv
-	depends on BR2_PACKAGE_IMX_GPU_VIV

So it no longer depends on the GPU stuff ?

package/gstreamer1/gst1-imx/Config.in line 10

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +2 -1
-	depends on BR2_PACKAGE_LIBFSLVPUWRAP
 	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+	select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there is no way to disable those options. So why are they options in the first place ?

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +0 -0
 	help
 	  This is a set of GStreamer 1.0 plugins for plugins for Freescale's
 	  i.MX6 platforms, with emphasis on video en/decoding using the VPU

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX · line 28

Quoted 10 lines
package/gstreamer1/gst1-imx/Config.in +7 -0
@@ -25,3 +19,49 @@ config BR2_PACKAGE_GST1_IMX
 	  The software as a whole is currently in beta stage.
 
 	  https://github.com/Freescale/gstreamer-imx
+
+if BR2_PACKAGE_GST1_IMX
+
+config BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+	bool "IPU plugin"
+	help
+	  IPU plugin library

This one.

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX · line 33

Quoted 5 lines
package/gstreamer1/gst1-imx/Config.in +5 -0
+
+config BR2_PACKAGE_GST1_IMX_PXP_PLUGIN
+	bool "PXP plugin"
+	help
+	  PXP plugin library

And this one.

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX · line 49

Quoted 3 lines
package/gstreamer1/gst1-imx/Config.in +3 -0
+# Required by imx-gpu-viv
+comment "GPU sinks need an (e)glibc toolchain"
+	depends on !BR2_TOOLCHAIN_USES_GLIBC

Ah ok, here is the GPU dependency.

Quoted 39 lines
package/gstreamer1/gst1-imx/gst1-imx.mk +12 -2
index 8ede8ad..f3eac0a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_IMX_VERSION = 0.11.1
+GST1_IMX_VERSION = 0.12.0
 GST1_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GST1_IMX_VERSION))
 
 GST1_IMX_LICENSE = LGPLv2+

@@ -13,13 +13,23 @@ GST1_IMX_LICENSE_FILES = LICENSE
 GST1_IMX_INSTALL_STAGING = YES
 
 GST1_IMX_DEPENDENCIES += host-pkgconf host-python \
-	imx-gpu-viv gstreamer1 gst1-plugins-base libfslvpuwrap
+	gstreamer1 gst1-plugins-base
 
 # needs access to imx-specific kernel headers
 GST1_IMX_DEPENDENCIES += linux
 GST1_IMX_CONF_OPTS += --prefix="/usr" \
 	--kernel-headers="$(LINUX_DIR)/include"
 
+ifeq ($(BR2_PACKAGE_GST1_IMX_V4L2_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += gst1-plugins-bad
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_IMX_VPU_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += libimxvpuapi
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_IMX_EGL_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += imx-gpu-viv
 ifeq ($(BR2_PACKAGE_XLIB_LIBX11),y)
 GST1_IMX_DEPENDENCIES += xlib_libX11
 GST1_IMX_CONF_OPTS += --egl-platform=x11

package/gstreamer1/gst1-imx/gst1-imx.mk else · line 47

Quoted 7 lines
package/gstreamer1/gst1-imx/gst1-imx.mk +1 -0
@@ -31,6 +41,7 @@ else
 GST1_IMX_CONF_OPTS += --egl-platform=fb
 endif
 endif
+endif
 
 define GST1_IMX_CONFIGURE_CMDS
 	cd $(@D); \

Also, please add a hash file. The rest looks good. Can you fix and resend ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#24 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

Thomas, All,

Quoted 4 lines · Thomas Petazzoni

Dear Gary Bisson,

On Sat, 30 Jan 2016 12:45:57 +0100, Gary Bisson wrote:

Quoted 9 lines

package/gstreamer1/gst1-imx/Config.in line 14

Quoted 7 lines
package/gstreamer1/gst1-imx/Config.in +1 -3
-config BR2_PACKAGE_GST1_IMX
+menuconfig BR2_PACKAGE_GST1_IMX
      bool "gst1-imx"
      depends on BR2_LINUX_KERNEL
      depends on BR2_arm # Only relevant for i.MX
-     depends on BR2_TOOLCHAIN_USES_GLIBC # imx-gpu-viv
-     depends on BR2_PACKAGE_IMX_GPU_VIV

So it no longer depends on the GPU stuff ?

No, you can build this package without the GPU backend which implies the GPU sinks won't be built. The end goal is for i.MX7 which doesn't have any GPU, right now I have to include the GPU binaries just to build the pxp/v4l plugins.

Quoted 8 lines

package/gstreamer1/gst1-imx/Config.in line 10

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +2 -1
-     depends on BR2_PACKAGE_LIBFSLVPUWRAP
      select BR2_PACKAGE_GST1_PLUGINS_BASE
+     select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+     select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there is no way to disable those options. So why are they options in the first place ?

I just wanted to make it explicit that the package will at least build those two plugins. Then leaving it up to the user to select whichever plugin he wants. There actually is no option to disable plugins from the packages, it's all a question of dependency. As soon as the i.MX linux kernel is built, PXP and IPU will be. As soon as the GPU libraries are includes, GPU sink plugins will be built.

Quoted 17 lines
Quoted 4 lines

help
This is a set of GStreamer 1.0 plugins for plugins for Freescale's i.MX6 platforms, with emphasis on video en/decoding using the VPU

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX · line 28

Quoted 10 lines
package/gstreamer1/gst1-imx/Config.in +7 -0
@@ -25,3 +19,49 @@ config BR2_PACKAGE_GST1_IMX
        The software as a whole is currently in beta stage.
 
        https://github.com/Freescale/gstreamer-imx
+
+if BR2_PACKAGE_GST1_IMX
+
+config BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+     bool "IPU plugin"
+     help
+       IPU plugin library

This one.

Quoted 7 lines

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX · line 33

Quoted 5 lines
package/gstreamer1/gst1-imx/Config.in +5 -0
+
+config BR2_PACKAGE_GST1_IMX_PXP_PLUGIN
+     bool "PXP plugin"
+     help
+       PXP plugin library

And this one.

The above just makes it clear (to the user) that those plugins will be built.

Quoted 50 lines

package/gstreamer1/gst1-imx/Config.in config BR2_PACKAGE_GST1_IMX · line 49

Quoted 3 lines
package/gstreamer1/gst1-imx/Config.in +3 -0
+# Required by imx-gpu-viv
+comment "GPU sinks need an (e)glibc toolchain"
+     depends on !BR2_TOOLCHAIN_USES_GLIBC

Ah ok, here is the GPU dependency.

Quoted 44 lines
package/gstreamer1/gst1-imx/gst1-imx.mk +13 -2
index 8ede8ad..f3eac0a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_IMX_VERSION = 0.11.1
+GST1_IMX_VERSION = 0.12.0
 GST1_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GST1_IMX_VERSION))
 
 GST1_IMX_LICENSE = LGPLv2+

@@ -13,13 +13,23 @@ GST1_IMX_LICENSE_FILES = LICENSE
 GST1_IMX_INSTALL_STAGING = YES
 
 GST1_IMX_DEPENDENCIES += host-pkgconf host-python \
-     imx-gpu-viv gstreamer1 gst1-plugins-base libfslvpuwrap
+     gstreamer1 gst1-plugins-base
 
 # needs access to imx-specific kernel headers
 GST1_IMX_DEPENDENCIES += linux
 GST1_IMX_CONF_OPTS += --prefix="/usr" \
      --kernel-headers="$(LINUX_DIR)/include"
 
+ifeq ($(BR2_PACKAGE_GST1_IMX_V4L2_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += gst1-plugins-bad
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_IMX_VPU_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += libimxvpuapi
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_IMX_EGL_PLUGIN),y)
+GST1_IMX_DEPENDENCIES += imx-gpu-viv
 ifeq ($(BR2_PACKAGE_XLIB_LIBX11),y)
 GST1_IMX_DEPENDENCIES += xlib_libX11
 GST1_IMX_CONF_OPTS += --egl-platform=x11

@@ -31,6 +41,7 @@ else
 GST1_IMX_CONF_OPTS += --egl-platform=fb
 endif
 endif
+endif
Quoted 5 lines

package/gstreamer1/gst1-imx/gst1-imx.mk else · line 47

Quoted 2 lines
package/gstreamer1/gst1-imx/gst1-imx.mk +0 -0
 define GST1_IMX_CONFIGURE_CMDS
      cd $(@D); \

Also, please add a hash file. The rest looks good. Can you fix and resend ?

Ok, let me know if you want the IPU/PXP options to be removed.

Regards,
Gary

#25 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

Hello,

Quoted 6 lines · Gary Bisson
Quoted 1 line

So it no longer depends on the GPU stuff ?

No, you can build this package without the GPU backend which implies the GPU sinks won't be built. The end goal is for i.MX7 which doesn't have any GPU, right now I have to include the GPU binaries just to build the pxp/v4l plugins.

ACK, makes sense.

Quoted 9 lines
Quoted 8 lines

package/gstreamer1/gst1-imx/Config.in line 10

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +2 -1
-     depends on BR2_PACKAGE_LIBFSLVPUWRAP
      select BR2_PACKAGE_GST1_PLUGINS_BASE
+     select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+     select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there is no way to disable those options. So why are they options in the first place ?

Quoted 6 lines

I just wanted to make it explicit that the package will at least build those two plugins. Then leaving it up to the user to select whichever plugin he wants. There actually is no option to disable plugins from the packages, it's all a question of dependency. As soon as the i.MX linux kernel is built, PXP and IPU will be. As soon as the GPU libraries are includes, GPU sink plugins will be built.

Hum, then it is not good, because it means that even if you disable the GPU sink plugin options, but still have the GPU libraries enabled, the GPU sink plugins will be installed on your target. This is very confusing.

I think you should remove the sub-options, and then simply expand the Config.in help text of the main option to say:

- The IPU and PXP plugins are always built.
- The GPU sink plugin is built when ... is enabled.
- The ... plugin is built when ... is enabled.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#26 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

Thomas, All,

Quoted 29 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Gary Bisson
Quoted 1 line

So it no longer depends on the GPU stuff ?

No, you can build this package without the GPU backend which implies the GPU sinks won't be built. The end goal is for i.MX7 which doesn't have any GPU, right now I have to include the GPU binaries just to build the pxp/v4l plugins.

ACK, makes sense.

Quoted 9 lines
Quoted 8 lines

package/gstreamer1/gst1-imx/Config.in line 10

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +2 -1
-     depends on BR2_PACKAGE_LIBFSLVPUWRAP
      select BR2_PACKAGE_GST1_PLUGINS_BASE
+     select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+     select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there is no way to disable those options. So why are they options in the first place ?

Quoted 6 lines

I just wanted to make it explicit that the package will at least build those two plugins. Then leaving it up to the user to select whichever plugin he wants. There actually is no option to disable plugins from the packages, it's all a question of dependency. As soon as the i.MX linux kernel is built, PXP and IPU will be. As soon as the GPU libraries are includes, GPU sink plugins will be built.

Quoted 4 lines

Hum, then it is not good, because it means that even if you disable the GPU sink plugin options, but still have the GPU libraries enabled, the GPU sink plugins will be installed on your target. This is very confusing.

Yes, I understand, is it really a big deal? There's going to be more plugins than expected in the rootfs, it's free!

Quoted 6 lines

I think you should remove the sub-options, and then simply expand the Config.in help text of the main option to say:

- The IPU and PXP plugins are always built.
- The GPU sink plugin is built when ... is enabled.
- The ... plugin is built when ... is enabled.

This would be ever more confusing in my opinion. It means that when you select gstreamer-imx you have no idea of what is going to be built. Then when you realize you need the graphics libraries you have to browse to select it yourself.

Wouldn't it be possible to force the option value when the IMX_GPU_VIV package is selected? I guess that would bring a circular dependency but at least someone wouldn't be able to remove the option without removing the graphics binaries.

Regards,
Gary

#27 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

Quoted 33 lines · Gary Bisson

Thomas, All,

Quoted 29 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Gary Bisson
Quoted 1 line

So it no longer depends on the GPU stuff ?

No, you can build this package without the GPU backend which implies the GPU sinks won't be built. The end goal is for i.MX7 which doesn't have any GPU, right now I have to include the GPU binaries just to build the pxp/v4l plugins.

ACK, makes sense.

Quoted 15 lines
Quoted 8 lines

package/gstreamer1/gst1-imx/Config.in line 10

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +2 -1
-     depends on BR2_PACKAGE_LIBFSLVPUWRAP
      select BR2_PACKAGE_GST1_PLUGINS_BASE
+     select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+     select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there is no way to disable those options. So why are they options in the first place ?

I just wanted to make it explicit that the package will at least build those two plugins. Then leaving it up to the user to select whichever plugin he wants. There actually is no option to disable plugins from the packages, it's all a question of dependency. As soon as the i.MX linux kernel is built, PXP and IPU will be. As soon as the GPU libraries are includes, GPU sink plugins will be built.

Quoted 7 lines
Quoted 4 lines

Hum, then it is not good, because it means that even if you disable the GPU sink plugin options, but still have the GPU libraries enabled, the GPU sink plugins will be installed on your target. This is very confusing.

Yes, I understand, is it really a big deal? There's going to be more plugins than expected in the rootfs, it's free!

We don't consider rootfs size to be for free.

Quoted 4 lines
Quoted 4 lines

I think you should remove the sub-options, and then simply expand the Config.in help text of the main option to say:

Quoted 8 lines
Quoted 3 lines

- The IPU and PXP plugins are always built.
- The GPU sink plugin is built when ... is enabled.
- The ... plugin is built when ... is enabled.

This would be ever more confusing in my opinion. It means that when you select gstreamer-imx you have no idea of what is going to be built. Then when you realize you need the graphics libraries you have to browse to select it yourself.

That's why it should be mentioned in the help text.

Quoted 5 lines

Wouldn't it be possible to force the option value when the IMX_GPU_VIV package is selected? I guess that would bring a circular dependency but at least someone wouldn't be able to remove the option without removing the graphics binaries.

Yes, that is possible. But we only do that in situations where it is not
obvious which other package you should select. The idea is to avoid a proliferation of Config.in options.

But in this case, you _anyway_ still have to manually select the imx-gpu-viv
package... So I don't think there is much point in adding the sub-options. Except if you can convert all the depends into selects (except for the glibc one of course).

Regards,
Arnout

Quoted 8 lines

Regards,
Gary
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#28 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

Arnout, All,

Quoted 39 lines · Arnout Vandecappelle
Quoted 38 lines · Gary Bisson

Thomas, All,

Quoted 33 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Gary Bisson
Quoted 1 line

So it no longer depends on the GPU stuff ?

No, you can build this package without the GPU backend which implies the GPU sinks won't be built. The end goal is for i.MX7 which doesn't have any GPU, right now I have to include the GPU binaries just to build the pxp/v4l plugins.

ACK, makes sense.

Quoted 9 lines
Quoted 8 lines

package/gstreamer1/gst1-imx/Config.in line 10

Quoted 4 lines
package/gstreamer1/gst1-imx/Config.in +2 -1
-     depends on BR2_PACKAGE_LIBFSLVPUWRAP
      select BR2_PACKAGE_GST1_PLUGINS_BASE
+     select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
+     select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there is no way to disable those options. So why are they options in the first place ?

Quoted 6 lines

I just wanted to make it explicit that the package will at least build those two plugins. Then leaving it up to the user to select whichever plugin he wants. There actually is no option to disable plugins from the packages, it's all a question of dependency. As soon as the i.MX linux kernel is built, PXP and IPU will be. As soon as the GPU libraries are includes, GPU sink plugins will be built.

Hum, then it is not good, because it means that even if you disable the GPU sink plugin options, but still have the GPU libraries enabled, the GPU sink plugins will be installed on your target. This is very confusing.

Quoted 4 lines
Quoted 2 lines

Yes, I understand, is it really a big deal? There's going to be more plugins than expected in the rootfs, it's free!

We don't consider rootfs size to be for free.

I understand.

Quoted 20 lines
Quoted 11 lines
Quoted 6 lines

I think you should remove the sub-options, and then simply expand the Config.in help text of the main option to say:

- The IPU and PXP plugins are always built.
- The GPU sink plugin is built when ... is enabled.
- The ... plugin is built when ... is enabled.

This would be ever more confusing in my opinion. It means that when you select gstreamer-imx you have no idea of what is going to be built. Then when you realize you need the graphics libraries you have to browse to select it yourself.

That's why it should be mentioned in the help text.

Quoted 5 lines

Wouldn't it be possible to force the option value when the IMX_GPU_VIV package is selected? I guess that would bring a circular dependency but at least someone wouldn't be able to remove the option without removing the graphics binaries.

Quoted 8 lines

Yes, that is possible. But we only do that in situations where it is not
obvious which other package you should select. The idea is to avoid a proliferation of Config.in options.

But in this case, you _anyway_ still have to manually select the imx-gpu-viv
package... So I don't think there is much point in adding the sub-options. Except if you can convert all the depends into selects (except for the glibc one of course).

Yes the GPU was actually a bad example, the VPU and V4L plugins do have selects that work. But I'll offer a v3 without the options, just with text in the Config.in and if later I find another approach I'll submit an RFC.

Thank you all for your feedback.

Regards,
Gary

#29 lore raw

PATCH 10/10 gst1-imx: bump to version 0.12.0

In reply to Gary Bisson

On 30-01-16 12:45, Gary Bisson wrote:
[snip]

Quoted 14 lines
package/gstreamer1/gst1-imx/gst1-imx.mk +1 -1
index 8ede8ad..f3eac0a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_IMX_VERSION = 0.11.1
+GST1_IMX_VERSION = 0.12.0
 GST1_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GST1_IMX_VERSION))
 
 GST1_IMX_LICENSE = LGPLv2+

package/gstreamer1/gst1-imx/gst1-imx.mk GST1_IMX_LICENSE_FILES = LICENSE · line 16

Quoted 5 lines
package/gstreamer1/gst1-imx/gst1-imx.mk +1 -1
@@ -13,13 +13,23 @@ GST1_IMX_LICENSE_FILES = LICENSE
 GST1_IMX_INSTALL_STAGING = YES
 
 GST1_IMX_DEPENDENCIES += host-pkgconf host-python \
-	imx-gpu-viv gstreamer1 gst1-plugins-base libfslvpuwrap
+	gstreamer1 gst1-plugins-base

Minor nit in addition to Thomas's comments: please split this into one
dependency per line.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF