Skip to contentSkip to conversation

git: add site_perl to packaged files to fix QA install error

PATCH In review Paul Gortmaker 3 participants 4 messages Jan 31, 2016 – Feb 1, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 git: add site_perl to packaged files to fix QA install error

Recently this started appearing on my x86_64 builds:

ERROR: QA Issue: git: Files/directories were installed but not shipped in any package:
/usr/lib64
/usr/lib64/site_perl
/usr/lib64/site_perl/5.22.1
/usr/lib64/site_perl/5.22.1/Git.pm
/usr/lib64/site_perl/5.22.1/Error.pm
/usr/lib64/site_perl/5.22.1/perllocal.pod
/usr/lib64/site_perl/5.22.1/Git
/usr/lib64/site_perl/5.22.1/auto
/usr/lib64/site_perl/5.22.1/Git/IndexInfo.pm
/usr/lib64/site_perl/5.22.1/Git/SVN.pm
/usr/lib64/site_perl/5.22.1/Git/I18N.pm
/usr/lib64/site_perl/5.22.1/Git/SVN
/usr/lib64/site_perl/5.22.1/Git/SVN/Log.pm
/usr/lib64/site_perl/5.22.1/Git/SVN/Prompt.pm
[...]
/usr/lib64/site_perl/5.22.1/Git/SVN/Memoize/YAML.pm
/usr/lib64/site_perl/5.22.1/auto/Git
/usr/lib64/site_perl/5.22.1/auto/Git/.packlist
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
git: 24 installed and not shipped files. [installed-vs-shipped]
ERROR: Fatal QA errors found, failing task.
ERROR: Function failed: do_package
ERROR: Logfile of failure stored in: /home/paul/poky/build/tmp/work/core2-64-overc-linux/git/2.7.0-r0/temp/log.do_package.15893
ERROR: Task 11 (/home/paul/poky/meta/recipes-devtools/git/git_2.7.0.bb, do_package) failed with exit code '1'

At first I thought it was the git uprev from 2.5 --> 2.7 but even after reverting that, the problem remained. So it must be related to some other infrastructural or perl change. As the fix was relatively obvious, I did not investigate the root cause any further -- as the perl magic in the git bb is enough to scare small children.

Cc Robert Yang <[email protected]>
Cc Richard Purdie <[email protected]>
---
 meta/recipes-devtools/git/git.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/git/git.inc +1 -0
index c19e0d47483c..4a0a62888631 100644
@@ -101,6 +101,7 @@ PACKAGES =+ "${PN}-perltools"
 FILES_${PN}-perltools += " \
     ${PERLTOOLS} \
     ${libdir}/perl \
+    ${libdir}/site_perl \
     ${datadir}/perl \
 "
 RDEPENDS_${PN}-perltools = "${PN} perl perl-module-file-path findutils"
Signature · 1 line
2.1.4
#1 lore raw
Quoted 5 lines · Paul Gortmaker
 FILES_${PN}-perltools += " \
     ${PERLTOOLS} \
     ${libdir}/perl \
+    ${libdir}/site_perl \
     ${datadir}/perl \

It seems a bit wrong for git (or any other package) to be installing itself into site-perl. That path is meant to be for stuff installed locally via cpan, right?

So, rather than patching the FILES to accept site-perl I think it would be better to find out why git is suddenly putting stuff there and stop it. For what it's worth, I just built git from oe-core master and didn't see this problem so it's possible that the breakage is being caused by something outside oe-core itself.

p.

#2 lore raw
Quoted 10 lines · [Re: [OE-core] [PATCH] git: add site_perl to packaged files to fix QA install…
Quoted 5 lines · Paul Gortmaker
 FILES_${PN}-perltools += " \
     ${PERLTOOLS} \
     ${libdir}/perl \
+    ${libdir}/site_perl \
     ${datadir}/perl \

It seems a bit wrong for git (or any other package) to be installing itself into site-perl. That path is meant to be for stuff installed locally via cpan, right?

I'm not up to speed on perl/cpan specs, but yeah off the cuff it does seem rather odd for it to be sprawling out into any perl dir IMHO.

Even the perl bb itself seems to actively clobber site_perl for the non native case.

Quoted 3 lines

So, rather than patching the FILES to accept site-perl I think it would be better to find out why git is suddenly putting stuff there and stop

Interestingly enough, you won't find site_perl mentioned anywhere in a checkout of git 2.7 itself. Nor does it appear here:

paul@yow-cube1:~/poky/meta/recipes-devtools/git$ git grep site_perl ./
paul@yow-cube1:~/poky/meta/recipes-devtools/git$ 

I'd reverted the git uprev, no change. There was a perl uprev that was recent and I reverted that too as a test but no change. Unfortunately I'm not exactly sure when it got broke, so I'd probably just have to guess and go back a week or two, if I wanted to try and bisect it.

Quoted 3 lines

it. For what it's worth, I just built git from oe-core master and didn't see this problem so it's possible that the breakage is being caused by something outside oe-core itself.

Interesting. I've not got any local bbappends for git so I don't know what is the trigger. I'm guessing SVN is perhaps involved, since all the "extra" files are related to git-svn. And I'm loosely based on the self-hosting build appliance here, which IIRC has svn in the pkglist. So maybe that triggers git to do additional svn import features?

I'm going to locally bbappend do_install to clobber that crap, and in the meantime if I get a chance to investigate in more detail, I'll follow up with what I find. At least we've primed google for the next guy who runs into this and searches...

P.
--

Quoted 4 lines

p.

#3 lore raw
In reply to Paul Gortmaker
Quoted 8 lines · Paul Gortmaker

ERROR: QA Issue: git: Files/directories were installed but not shipped in any package:
/usr/lib64
/usr/lib64/site_perl
/usr/lib64/site_perl/5.22.1 /usr/lib64/site_perl/5.22.1/Git.pm /usr/lib64/site_perl/5.22.1/Error.pm

Interestingly I'm seeing this:

git-perltools:

        /usr/bin/git-cvsserver
        /usr/lib/perl/site_perl/5.22.1/Error.pm
        /usr/lib/perl/site_perl/5.22.1/Git.pm

So my git is installing into site_perl too, but obviously multilib is breaking something.

Ross