Skip to contentSkip to conversation

tqma6_wru4: Fix the reset delay for the the LAN8720 PHY

PATCH New Fabio Estevam 2 participants 2 messages Feb 1, 2016 – Feb 2, 2016

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 tqma6_wru4: Fix the reset delay for the the LAN8720 PHY

From: Fabio Estevam <[email protected]>

According to the LAN8720 datasheet tpurstd (time that reset line should stay asserted) is 25ms.

So do as suggested by the LAN8720 datasheet.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/tqc/tqma6/tqma6_wru4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/tqc/tqma6/tqma6_wru4.c +1 -1
index 4427799..c9a7ab7 100644
@@ -177,7 +177,7 @@ static void setup_iomuxc_enet(void)
 	ret = gpio_request(ENET_PHY_RESET_GPIO, "phy-reset");
 	if (!ret)
 		gpio_direction_output(ENET_PHY_RESET_GPIO , 0);
-	udelay(1000);
+	udelay(25000);
 	gpio_set_value(ENET_PHY_RESET_GPIO, 1);
 }
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 tqma6_wru4: Fix the reset delay for the the LAN8720 PHY

Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

According to the LAN8720 datasheet tpurstd (time that reset line should stay asserted) is 25ms.

So do as suggested by the LAN8720 datasheet.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/tqc/tqma6/tqma6_wru4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/tqc/tqma6/tqma6_wru4.c +0 -0
index 4427799..c9a7ab7 100644

board/tqc/tqma6/tqma6_wru4.c static void setup_iomuxc_enet(void) · line 183

Quoted 8 lines
board/tqc/tqma6/tqma6_wru4.c +1 -1
@@ -177,7 +177,7 @@ static void setup_iomuxc_enet(void)
 	ret = gpio_request(ENET_PHY_RESET_GPIO, "phy-reset");
 	if (!ret)
 		gpio_direction_output(ENET_PHY_RESET_GPIO , 0);
-	udelay(1000);
+	udelay(25000);
 	gpio_set_value(ENET_PHY_RESET_GPIO, 1);
 }

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================