patch "iio: light: acpi-als: Report data as processed" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: light: acpi-als: Report data as processed
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
fa34e6dd44d7c02c8a8468ce4a52a7506f907befMon Sep 17 00:00:00 2001
From: Gabriele Mazzotta <[email protected]>
Date: Tue, 12 Jan 2016 16:21:39 +0100
Subject: iio: light: acpi-als: Report data as processed
As per the ACPI specification (Revision 5.0) [1], the data coming from the sensor represent the ambient light illuminance reading expressed in lux. So use IIO_CHAN_INFO_PROCESSED to signify that the data are pre-processed.
However, to keep backward ABI compatibility, the IIO_CHAN_INFO_RAW bit is not removed.
[1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
This issue has also been responsible for at least one userspace bug report hence marking what is a small semantic fix really for stable.
[2] https://github.com/hadess/iio-sensor-proxy/issues/46
--- drivers/iio/light/acpi-als.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/iio/light/acpi-als.c +4 -2
@@ -54,7 +54,9 @@ static const struct iio_chan_spec acpi_als_channels[] = { .realbits = 32, .storagebits = 32, }, - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), +/* _RAW is here for backward ABI compatibility */ + .info_mask_separate =BIT (IIO_CHAN_INFO_RAW ) | + BIT(IIO_CHAN_INFO_PROCESSED), }, };
@@ -152,7 +154,7 @@ static int acpi_als_read_raw(struct iio_dev *indio_dev,s32 temp_val;int ret; -if (mask !=IIO_CHAN_INFO_RAW ) +if ((mask !=IIO_CHAN_INFO_PROCESSED ) && (mask !=IIO_CHAN_INFO_RAW ))return -EINVAL ;/* we support only illumination (_ALI) so far. */
Signature · 1 line
2.7.0