Skip to contentSkip to conversation

patch "iio: inkern: fix a NULL dereference on error" added to staging-linus

PATCH [email protected] 1 participant 1 message Feb 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: inkern: fix a NULL dereference on error

to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From d81dac3c1c5295c61b15293074ac2bd3254e1875 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Tue, 26 Jan 2016 12:25:21 +0300
Subject: iio: inkern: fix a NULL dereference on error

In twl4030_bci_probe() there are some failure paths where we call iio_channel_release() with a NULL pointer. (Apparently, that driver can opperate without a valid channel pointer). Let's fix it by adding a NULL check in iio_channel_release().

Fixes 2202e1fc5a29 ('drivers: power: twl4030_charger: fix link problems when building as module')
---
 drivers/iio/inkern.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/inkern.c +2 -0
index c8bad3cf891d..217e9306aa0f 100644
@@ -351,6 +351,8 @@ EXPORT_SYMBOL_GPL(iio_channel_get);
 
 void iio_channel_release(struct iio_channel *channel)
 {
+	if (!channel)
+		return;
 	iio_device_put(channel->indio_dev);
 	kfree(channel);
 }
Signature · 1 line
2.7.0