Skip to contentSkip to conversation

regmap: Return an error if a caller attempts to do an unsupported raw read

PATCH In review Mark Brown 1 participant 2 messages Feb 1, 2016

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 regmap: Return an error if a caller attempts to do an unsupported raw read

regmaps without raw I/O access can't implement raw I/O operations, return an error if someone tries to do that rather than crashing.

---
 drivers/base/regmap/regmap.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/base/regmap/regmap.c +3 -0
index 343263449aff..e2f68807d970 100644
@@ -2255,6 +2255,9 @@ static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
 
 	WARN_ON(!map->bus);
 
+	if (!map->bus || !map->bus->read)
+		return -EINVAL;
+
 	range = _regmap_range_lookup(map, reg);
 	if (range) {
 		ret = _regmap_select_page(map, &reg, range,
Signature · 1 line
2.7.0.rc3
author maintainer
#1 lore raw

Applied "regmap: Return an error if a caller attempts to do an unsupported raw read" to the regmap tree

The patch

regmap: Return an error if a caller attempts to do an unsupported raw read

has been applied to the regmap tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From bb2bb45d1be28987e6cb50f50e4819795537ab83 Mon Sep 17 00:00:00 2001

From: Mark Brown <[email protected]>
Date: Mon, 1 Feb 2016 21:09:14 +0000
Subject: [PATCH] regmap: Return an error if a caller attempts to do an
unsupported raw read

regmaps without raw I/O access can't implement raw I/O operations, return an error if someone tries to do that rather than crashing.

---
 drivers/base/regmap/regmap.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/base/regmap/regmap.c +3 -0
index 343263449aff..e2f68807d970 100644
@@ -2255,6 +2255,9 @@ static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
 
 	WARN_ON(!map->bus);
 
+	if (!map->bus || !map->bus->read)
+		return -EINVAL;
+
 	range = _regmap_range_lookup(map, reg);
 	if (range) {
 		ret = _regmap_select_page(map, &reg, range,
Signature · 1 line
2.7.0.rc3