Skip to contentSkip to conversation

toaster: reinstate ID on edit columns button

PATCH In review Ed Bartosh 1 participant 2 messages Feb 4, 2016

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 toaster: reinstate ID on edit columns button

From: Elliot Smith <[email protected]>

The ID was omitted from the "edit columns" button on the "projects", "all builds" and "project builds" tables when they were converted to ToasterTable. This caused the QA tests to fail.

Reinstate the ID so the tests can identify the "edit columns" button correctly.

[YOCTO #9051]

---
 bitbake/lib/toaster/toastergui/templates/toastertable.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/toaster/toastergui/templates/toastertable.html +1 -1
index f0a3aed..9099b30 100644
@@ -57,7 +57,7 @@
 
       <div class="pull-right">
         <div class="btn-group">
-          <button class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
+          <button id="edit-columns-button" class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
             <span class="caret"></span>
           </button>
           <ul class="dropdown-menu editcol">
Signature · 1 line
2.1.4
author
#1 lore raw

Looks good to me.
Sent upstream.

Quoted 33 lines · Ed Bartosh

From: Elliot Smith <[email protected]>

The ID was omitted from the "edit columns" button on the "projects", "all builds" and "project builds" tables when they were converted to ToasterTable. This caused the QA tests to fail.

Reinstate the ID so the tests can identify the "edit columns" button correctly.

[YOCTO #9051]

---
 bitbake/lib/toaster/toastergui/templates/toastertable.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/toaster/toastergui/templates/toastertable.html +1 -1
index f0a3aed..9099b30 100644
@@ -57,7 +57,7 @@
 
       <div class="pull-right">
         <div class="btn-group">
-          <button class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
+          <button id="edit-columns-button" class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
             <span class="caret"></span>
           </button>
           <ul class="dropdown-menu editcol">
Signature · 1 line
2.1.4
Signature · 3 lines
--
Regards,
Ed