Skip to contentSkip to conversation

tests/kms_pipe_crc_basic: Don't suspend the machine if

PATCH Superseded Marius Vlad 2 participants 3 messages Feb 4, 2016 – Feb 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_pipe_crc_basic: Don't suspend the machine if

suspend-read-crc-pipe will perform a suspend and then skip the test in case the pipe is not present on the platform. Skip the test before doing the suspend.

---
 tests/kms_pipe_crc_basic.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_pipe_crc_basic.c +1 -0
index 3c51ba0..dbb2919 100644
@@ -271,6 +271,7 @@ igt_main
 			test_read_crc(&data, i, TEST_SEQUENCE | TEST_NONBLOCK);
 
 		igt_subtest_f("suspend-read-crc-pipe-%c", 'A'+i) {
+			igt_skip_on(i >= data.display.n_pipes);
 			igt_system_suspend_autoresume();
 
 			test_read_crc(&data, i, 0);
Signature · 6 lines
2.7.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v2 1/1 tests/kms_pipe_crc_basic: Don't suspend the machine if the pipe is not present.

suspend-read-crc-pipe will perform a suspend and then skip the test in case the pipe is not present or is fused w/ another pipe. Skip the test before doing the suspend.

v2: Somehow the subject was trimmed.

---
 tests/kms_pipe_crc_basic.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_pipe_crc_basic.c +1 -0
index 3c51ba0..dbb2919 100644
@@ -271,6 +271,7 @@ igt_main
 			test_read_crc(&data, i, TEST_SEQUENCE | TEST_NONBLOCK);
 
 		igt_subtest_f("suspend-read-crc-pipe-%c", 'A'+i) {
+			igt_skip_on(i >= data.display.n_pipes);
 			igt_system_suspend_autoresume();
 
 			test_read_crc(&data, i, 0);
Signature · 6 lines
2.7.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
In reply to Marius Vlad
Quoted 14 lines · Marius Vlad

suspend-read-crc-pipe will perform a suspend and then skip the test in case the pipe is not present on the platform. Skip the test before doing the suspend.

---
 tests/kms_pipe_crc_basic.c | 1 +
 1 file changed, 1 insertion(+)
tests/kms_pipe_crc_basic.c +0 -0
index 3c51ba0..dbb2919 100644

tests/kms_pipe_crc_basic.c igt_main · line 274

Quoted 4 lines
tests/kms_pipe_crc_basic.c +1 -0
@@ -271,6 +271,7 @@ igt_main
 			test_read_crc(&data, i, TEST_SEQUENCE | TEST_NONBLOCK);
 
 		igt_subtest_f("suspend-read-crc-pipe-%c", 'A'+i) {
+			igt_skip_on(i >= data.display.n_pipes);

We should place this into an igt_fixture at the top of the loop. Hitting igt_skip outside of any testcase means we'll skip all the subsequent ones without doing any work.

Otoh this is a bit a bikeshed, so Reviewed-by: Daniel Vetter <[email protected]> either way.
-Daniel

Quoted 10 lines
tests/kms_pipe_crc_basic.c +0 -0
 			igt_system_suspend_autoresume();
 
 			test_read_crc(&data, i, 0);
Signature · 6 lines
2.7.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx