Skip to contentSkip to conversation

STAGING: COMEDI: Remove unnecessary typecast of c90 int constant

PATCH In review Pablo G. Gallardo 2 participants 4 messages Feb 4, 2016 – Feb 5, 2016 Staging

lore
Share & tools
lore

Pablo G. Gallardo

author
#0 lore raw

PATCH v2 1/2 STAGING: COMEDI: Remove unnecessary typecast of c90 int constant

This patch removes unnecessary typecast of c90 int constant.

Signed-off-by Pablo G. Gallardo <[email protected]>
---
 drivers/staging/comedi/comedi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/comedi.h +1 -1
index 83bd309..f0d1b15 100644
@@ -516,7 +516,7 @@ struct comedi_bufinfo {
 #define UNIT_mA			1
 #define UNIT_none		2
 
-#define COMEDI_MIN_SPEED	((unsigned int)0xffffffff)
+#define COMEDI_MIN_SPEED	0xffffffffu
 
 /**********************************************************/
 /* everything after this line is ALPHA */
Signature · 1 line
2.7.0
author
#1 lore raw

PATCH v2 2/2 STAGING: COMEDI: Wrap line over 80 characters

This patch wraps lines over 80 characters.

Signed-off-by Pablo G. Gallardo <[email protected]>
---
 drivers/staging/comedi/comedi_pcmcia.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/comedi_pcmcia.h +2 -1
index 5d3db2b..5a572c2 100644
@@ -39,7 +39,8 @@ void comedi_pcmcia_driver_unregister(struct comedi_driver *,
 				     struct pcmcia_driver *);
 
 /**
- * module_comedi_pcmcia_driver() - Helper macro for registering a comedi PCMCIA driver
+ * module_comedi_pcmcia_driver() - Helper macro for registering a comedi
+ * PCMCIA driver
  * @__comedi_driver: comedi_driver struct
  * @__pcmcia_driver: pcmcia_driver struct
  *
Signature · 1 line
2.7.0
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] STAGING: COMEDI: Wrap line over 80 characters

Quoted 13 lines · Pablo G. Gallardo

This patch wraps lines over 80 characters.

Signed-off-by Pablo G. Gallardo <[email protected]>
---
  drivers/staging/comedi/comedi_pcmcia.h | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/comedi_pcmcia.h +0 -0
index 5d3db2b..5a572c2 100644

drivers/staging/comedi/comedi_pcmcia.h void comedi_pcmcia_driver_unregister(struct comedi_driver *, · line 46

Quoted 9 lines
drivers/staging/comedi/comedi_pcmcia.h +2 -1
@@ -39,7 +39,8 @@ void comedi_pcmcia_driver_unregister(struct comedi_driver *,
  				     struct pcmcia_driver *);
 
  /**
- * module_comedi_pcmcia_driver() - Helper macro for registering a comedi PCMCIA driver
+ * module_comedi_pcmcia_driver() - Helper macro for registering a comedi
+ * PCMCIA driver
   * @__comedi_driver: comedi_driver struct
   * @__pcmcia_driver: pcmcia_driver struct
   *

Thanks!

Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
Reviewed-by on v2 1/2
#3 lore raw
In reply to Pablo G. Gallardo
Quoted 13 lines · Pablo G. Gallardo

This patch removes unnecessary typecast of c90 int constant.

Signed-off-by Pablo G. Gallardo <[email protected]>
---
  drivers/staging/comedi/comedi.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/comedi.h +0 -0
index 83bd309..f0d1b15 100644

drivers/staging/comedi/comedi.h struct comedi_bufinfo { · line 522

Quoted 8 lines
drivers/staging/comedi/comedi.h +1 -1
@@ -516,7 +516,7 @@ struct comedi_bufinfo {
  #define UNIT_mA			1
  #define UNIT_none		2
 
-#define COMEDI_MIN_SPEED	((unsigned int)0xffffffff)
+#define COMEDI_MIN_SPEED	0xffffffffu
 
  /**********************************************************/
  /* everything after this line is ALPHA */

Thanks.

Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-