Skip to contentSkip to conversation

block: partition: Add partition specific uevent callbacks for partition info

PATCH RESEND In review John Stultz 3 participants 4 messages Feb 5, 2016 – Feb 6, 2016 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 block: partition: Add partition specific uevent callbacks for partition info

From: San Mehat <[email protected]>

This patch has been carried in the Android tree for quite some time and is one of the few patches required to get a mainline kernel up and running with an exsiting Android userspace. So I wanted to submit it for review and consideration if it should be merged.

For partitions, add new uevent parameters 'PARTN' which specifies the partitions index in the table, and 'PARTNAME', which specifies PARTNAME specifices the partition name of a partition device.

Android's userspace uses this for creating device node links from the partition name and number: ie:
/dev/block/platform/soc/by-name/system
or
/dev/block/platform/soc/by-num/p1

One can see its usage here:
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#355
and
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#494

Cc Jens Axboe <[email protected]>
Cc Rom Lemarchand <[email protected]>
Cc Android Kernel Team <[email protected]>
Cc Jeff Moyer <[email protected]>
Cc Kees Cook <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Kay Sievers <[email protected]>
[Dropped NPARTS and reworded commit message for context]

---
v2: Dropped NPARTS thanks to Jeff noticing it wasn't used

 block/partition-generic.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
block/partition-generic.c +11 -0
index 746935a..ae95e96 100644
@@ -216,10 +216,21 @@ static void part_release(struct device *dev)
 	kfree(p);
 }
 
+static int part_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+	struct hd_struct *part = dev_to_part(dev);
+
+	add_uevent_var(env, "PARTN=%u", part->partno);
+	if (part->info && part->info->volname[0])
+		add_uevent_var(env, "PARTNAME=%s", part->info->volname);
+	return 0;
+}
+
 struct device_type part_type = {
 	.name		= "partition",
 	.groups		= part_attr_groups,
 	.release	= part_release,
+	.uevent		= part_uevent,
 };
 
 static void delete_partition_rcu_cb(struct rcu_head *head)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 40 lines · On Fri, 5 Feb 2016 10:01:43 -0800 John Stultz <[email protected]> wrote:

From: San Mehat <[email protected]>

This patch has been carried in the Android tree for quite some time and is one of the few patches required to get a mainline kernel up and running with an exsiting Android userspace. So I wanted to submit it for review and consideration if it should be merged.

For partitions, add new uevent parameters 'PARTN' which specifies the partitions index in the table, and 'PARTNAME', which specifies PARTNAME specifices the partition name of a partition device.

Android's userspace uses this for creating device node links from the partition name and number: ie:
/dev/block/platform/soc/by-name/system
or
/dev/block/platform/soc/by-num/p1

One can see its usage here:
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#355
and
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#494

...

block/partition-generic.c +8 -0
@@ -216,10 +216,21 @@ static void part_release(struct device *dev)
 	kfree(p);
 }
 
+static int part_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+	struct hd_struct *part = dev_to_part(dev);
+
+	add_uevent_var(env, "PARTN=%u", part->partno);
+	if (part->info && part->info->volname[0])
+		add_uevent_var(env, "PARTNAME=%s", part->info->volname);
+	return 0;

block/partition-generic.c static void part_release(struct device *dev) · line 236

Quoted 10 lines
block/partition-generic.c +3 -0
+}
+
 struct device_type part_type = {
 	.name		= "partition",
 	.groups		= part_attr_groups,
 	.release	= part_release,
+	.uevent		= part_uevent,
 };
 
 static void delete_partition_rcu_cb(struct rcu_head *head)

Interestingly, this feature appears to already be documented in Documentation/block/cmdline-partition.txt. I wonder how that happened. Maybe we used to do this but it got taken away?

It seems bad that we don't document uevents in any organized fashion. But the audience is very small and knows how to find kernel source code so I guess it doesn't matter.

Anyway, please do check that the conveniently self-adding documentation is accurate and complete.

#2 lore raw
Quoted 51 lines · Andrew Morton
Quoted 49 lines · On Fri, 5 Feb 2016 10:01:43 -0800 John Stultz <[email protected]> wrote:

From: San Mehat <[email protected]>

This patch has been carried in the Android tree for quite some time and is one of the few patches required to get a mainline kernel up and running with an exsiting Android userspace. So I wanted to submit it for review and consideration if it should be merged.

For partitions, add new uevent parameters 'PARTN' which specifies the partitions index in the table, and 'PARTNAME', which specifies PARTNAME specifices the partition name of a partition device.

Android's userspace uses this for creating device node links from the partition name and number: ie:
/dev/block/platform/soc/by-name/system
or
/dev/block/platform/soc/by-num/p1

One can see its usage here:
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#355
and
https://android.googlesource.com/platform/system/core/+/master/init/devices.cpp#494

...

block/partition-generic.c +11 -0
@@ -216,10 +216,21 @@ static void part_release(struct device *dev)
      kfree(p);
 }
 
+static int part_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+     struct hd_struct *part = dev_to_part(dev);
+
+     add_uevent_var(env, "PARTN=%u", part->partno);
+     if (part->info && part->info->volname[0])
+             add_uevent_var(env, "PARTNAME=%s", part->info->volname);
+     return 0;
+}
+
 struct device_type part_type = {
      .name           = "partition",
      .groups         = part_attr_groups,
      .release        = part_release,
+     .uevent         = part_uevent,
 };
 
Quoted 5 lines

block/partition-generic.c static void part_release(struct device *dev) · line 236

Quoted 1 line
block/partition-generic.c +0 -0
 static void delete_partition_rcu_cb(struct rcu_head *head)

Interestingly, this feature appears to already be documented in Documentation/block/cmdline-partition.txt. I wonder how that happened. Maybe we used to do this but it got taken away?

Heh. Looks like the documentation was added not too long ago (by Cai - cc'ed). I suspect they had been working w/ the Android tree and assumed the functionality was already upstream?

Quoted 6 lines

It seems bad that we don't document uevents in any organized fashion. But the audience is very small and knows how to find kernel source code so I guess it doesn't matter.

Anyway, please do check that the conveniently self-adding documentation is accurate and complete.

It does match the behavior this patch provides from Android. It is somewhat tangential to the functionality described in the documentation, so I'm not sure of its measure of completeness (for example, it doesn't talk about PARTN parameter, but again, the documentation is covering how to specify partition info via the boot cmdline, and isn't really covering the uevents - the uevent was just a mentioned side-effect for the partition name portion of the cmdline option).

thanks
-john

#3 lore raw
Quoted 3 lines
Quoted 3 lines

Interestingly, this feature appears to already be documented in Documentation/block/cmdline-partition.txt. I wonder how that happened. Maybe we used to do this but it got taken away?

This documentation talk about the partition name usages,
my patch support get partition name from android userspace.
the mainline kernel appears does not support the 'PARTNAME' uevent, but this feature is very convenient.

Quoted 23 lines

Heh. Looks like the documentation was added not too long ago (by Cai - cc'ed). I suspect they had been working w/ the Android tree and assumed the functionality was already upstream?

Quoted 6 lines

It seems bad that we don't document uevents in any organized fashion. But the audience is very small and knows how to find kernel source code so I guess it doesn't matter.

Anyway, please do check that the conveniently self-adding documentation is accurate and complete.

It does match the behavior this patch provides from Android. It is somewhat tangential to the functionality described in the documentation, so I'm not sure of its measure of completeness (for example, it doesn't talk about PARTN parameter, but again, the documentation is covering how to specify partition info via the boot cmdline, and isn't really covering the uevents - the uevent was just a mentioned side-effect for the partition name portion of the cmdline option).

thanks
-john