staging/lustre/lnet: Don't call roundup_pow_of_two on zero in LNetEQAlloc
PATCH 1/1 staging/lustre/lnet: Don't call roundup_pow_of_two on zero in LNetEQAlloc
From: Oleg Drokin <[email protected]>
roundup_pow_of_two return when called on a zero argument is undefined, so don't call it like that.
This fixes a problem introduced by commit 322489d9d551
("staging/lustre: Use roundup_pow_of_two() in LNetEQAlloc()")
since 0 is a valid count parameter for LNetEQAlloc. Also manifesting
itself as an annoying kernel warning:
LNet: 3486:0:(lib-eq.c:85:LNetEQAlloc()) EQ callback is guaranteed to get every event, do you still want to set eqcount 1 for polling event which will have locking overhead? Please contact with developer to confirm
Signed-off-by Oleg Drokin <[email protected]>
CC Pekka Enberg <[email protected]>
--- drivers/staging/lustre/lnet/lnet/lib-eq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/lustre/lnet/lnet/lib-eq.c +2 -1
@@ -79,7 +79,8 @@ LNetEQAlloc(unsigned int count, lnet_eq_handler_t callback,* overflow, they don't skip entries, so the queue has the same * apparent capacity at all times */ - count =roundup_pow_of_two (count); +if (count) + count =roundup_pow_of_two (count);if (callback !=LNET_EQ_HANDLER_NONE && count !=0 )CWARN ("EQ callback is guaranteed to get every event, do you still want to set eqcount %d for polling event which will have locking overhead? Please contact with developer to confirm\n" , count);
Signature · 1 line
2.1.0