Skip to contentSkip to conversation

clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes

PATCH In review Stephen Boyd 2 participants 3 messages Feb 7, 2016 – Feb 8, 2016 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes

These functions either never existed or were only used in OF_CLK_DECLARE() macros. Remove the dead prototypes.

---
 include/linux/clk-provider.h | 4 ----
 1 file changed, 4 deletions(-)
include/linux/clk-provider.h +0 -4
index 9c3a18c1a984..fce7f027f8a7 100644
@@ -626,8 +626,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
 		const char *parent_name, unsigned gpio, bool active_low,
 		unsigned long flags);
 
-void of_gpio_clk_gate_setup(struct device_node *node);
-
 /**
  * struct clk_gpio_mux - gpio controlled clock multiplexer
  *
@@ -643,8 +641,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, unsigned gpio,
 		bool active_low, unsigned long flags);
 
-void of_gpio_mux_clk_setup(struct device_node *node);
-
 /**
  * clk_register - allocate a new clock, register it and return an opaque cookie
  * @dev: device that is registering this clock
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Stephen Boyd

These functions either never existed or were only used in OF_CLK_DECLARE() macros. Remove the dead prototypes.

Yes, they were used by OF_CLK_DECLARE() macros. I originally made the of_gpio_clk_gate_setup() non static just because the other basic clocks were implemented the same way. Actually I do not follow why the functions needed to be non static in the first place. Surely the declarations can go now after the conversion to a platform driver.

Quoted 29 lines
---
  include/linux/clk-provider.h | 4 ----
  1 file changed, 4 deletions(-)
include/linux/clk-provider.h +0 -4
index 9c3a18c1a984..fce7f027f8a7 100644
@@ -626,8 +626,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
  		const char *parent_name, unsigned gpio, bool active_low,
  		unsigned long flags);
 
-void of_gpio_clk_gate_setup(struct device_node *node);
-
  /**
   * struct clk_gpio_mux - gpio controlled clock multiplexer
   *
@@ -643,8 +641,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
  		const char * const *parent_names, u8 num_parents, unsigned gpio,Acked-by:
  		bool active_low, unsigned long flags);
 
-void of_gpio_mux_clk_setup(struct device_node *node);
-
  /**
   * clk_register - allocate a new clock, register it and return an opaque cookie
   * @dev: device that is registering this clock
#2 lore raw
Quoted 11 lines · Jyri Sarha
Quoted 3 lines · Stephen Boyd

These functions either never existed or were only used in OF_CLK_DECLARE() macros. Remove the dead prototypes.

Yes, they were used by OF_CLK_DECLARE() macros. I originally made the of_gpio_clk_gate_setup() non static just because the other basic clocks were implemented the same way. Actually I do not follow why the functions needed to be non static in the first place. Surely the declarations can go now after the conversion to a platform driver.

Thanks. There is some exporting of basic type functions for u300. I'm not entirely sure why we do it there either though.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project