Skip to contentSkip to conversation

ARM: tegra: Add stdout-path for various boards

PATCH Applied Jon Hunter 4 participants 7 messages Feb 9, 2016 – Apr 5, 2016 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Jon Hunter

author
#0 lore raw

PATCH 1/2 ARM: tegra: Add stdout-path for various boards

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

This has been tested on boards, tegra20-trimslice, tegra30-beaver, tegra114-dalmore and tegra124-jetson-tk1.

---

The only boards that I have not modified are tegra114-roth and tegra114-tn7 because these boards have two entries for console in the *.dts file. AFAICT we cannot suppport multiple consoles via the stdout-path and if a console is specified by the kernel boot parameters then this sets the kernel variable "console_set_on_cmdline" and prevents the stdout-path console being registered. If there is a better way to handle these boards via device-tree let me know.

 arch/arm/boot/dts/tegra114-dalmore.dts        | 4 ++++
 arch/arm/boot/dts/tegra124-jetson-tk1.dts     | 4 ++++
 arch/arm/boot/dts/tegra124-nyan.dtsi          | 4 ++++
 arch/arm/boot/dts/tegra124-venice2.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-harmony.dts         | 4 ++++
 arch/arm/boot/dts/tegra20-iris-512.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-medcom-wide.dts     | 4 ++++
 arch/arm/boot/dts/tegra20-paz00.dts           | 4 ++++
 arch/arm/boot/dts/tegra20-seaboard.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-tamonten.dtsi       | 4 ++++
 arch/arm/boot/dts/tegra20-trimslice.dts       | 4 ++++
 arch/arm/boot/dts/tegra20-ventana.dts         | 4 ++++
 arch/arm/boot/dts/tegra20-whistler.dts        | 4 ++++
 arch/arm/boot/dts/tegra30-apalis-eval.dts     | 4 ++++
 arch/arm/boot/dts/tegra30-beaver.dts          | 4 ++++
 arch/arm/boot/dts/tegra30-cardhu.dtsi         | 4 ++++
 arch/arm/boot/dts/tegra30-colibri-eval-v3.dts | 4 ++++
 17 files changed, 68 insertions(+)
arch/arm/boot/dts/tegra114-dalmore.dts +4 -0
index 8b7aa0dcdc6e..b5748eeed473 100644
@@ -18,6 +18,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x80000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra124-jetson-tk1.dts +4 -0
index 4ee2e63e11d0..a7264a15080a 100644
@@ -19,6 +19,10 @@
 		serial2 = &uartb;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x0 0x80000000 0x0 0x80000000>;
 	};
arch/arm/boot/dts/tegra124-nyan.dtsi +4 -0
index ec1aa64ded68..e2cd39e3c95e 100644
@@ -8,6 +8,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x0 0x80000000 0x0 0x80000000>;
 	};
arch/arm/boot/dts/tegra124-venice2.dts +4 -0
index cfbdf429b45d..604f4b7c2685 100644
@@ -13,6 +13,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x0 0x80000000 0x0 0x80000000>;
 	};
arch/arm/boot/dts/tegra20-harmony.dts +4 -0
index b926a07b9443..4b73c76f981a 100644
@@ -13,6 +13,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-iris-512.dts +4 -0
index 1dd7d7bfdfcc..bb56dfe9e10c 100644
@@ -11,6 +11,10 @@
 		serial1 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	host1x@50000000 {
 		hdmi@54280000 {
 			status = "okay";
arch/arm/boot/dts/tegra20-medcom-wide.dts +4 -0
index 9b87526ab0b7..34c6588e92ef 100644
@@ -10,6 +10,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	pwm@7000a000 {
 		status = "okay";
 	};
arch/arm/boot/dts/tegra20-paz00.dts +4 -0
index ed7e1009326c..81a10a9df814 100644
@@ -14,6 +14,10 @@
 		serial1 = &uartc;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x20000000>;
 	};
arch/arm/boot/dts/tegra20-seaboard.dts +4 -0
index aea8994b35f2..0aed748567aa 100644
@@ -13,6 +13,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-tamonten.dtsi +4 -0
index 13d4e6185275..025e9e8037da 100644
@@ -10,6 +10,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x20000000>;
 	};
arch/arm/boot/dts/tegra20-trimslice.dts +4 -0
index d99af4ef9c64..69d25ca47e04 100644
@@ -13,6 +13,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-ventana.dts +4 -0
index 04c58e9ca490..c61533a9bf0b 100644
@@ -13,6 +13,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-whistler.dts +4 -0
index 340d81108df1..bd7658572239 100644
@@ -13,6 +13,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x20000000>;
 	};
arch/arm/boot/dts/tegra30-apalis-eval.dts +4 -0
index f2879cfcca62..b914bcb381d7 100644
@@ -17,6 +17,10 @@
 		serial3 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	pcie-controller@00003000 {
 		status = "okay";
 
arch/arm/boot/dts/tegra30-beaver.dts +4 -0
index 3dede3934446..1eca3b28ac64 100644
@@ -12,6 +12,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x80000000 0x7ff00000>;
 	};
arch/arm/boot/dts/tegra30-cardhu.dtsi +4 -0
index bb1ca158273c..de9d6ccace14 100644
@@ -35,6 +35,10 @@
 		serial1 = &uartc;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x80000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra30-colibri-eval-v3.dts +4 -0
index 3ff019f47d00..93e1ffd95bfa 100644
@@ -15,6 +15,10 @@
 		serial2 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	host1x@50000000 {
 		dc@54200000 {
 			rgb {
Signature · 1 line
2.1.4

A message that is not in the archive (sent off-list or not yet received): 1455025920-21875-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

author
#2 lore raw

PATCH 2/2 ARM64: tegra: Add stdout-path for various boards

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

For tegra132-norrin the alias serial0 is not defined and so add this.

This has been tested on tegra132-norrin and tegra210-p2371-0000.

---
 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 5 ++++-
 arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 4 ++++
 2 files changed, 8 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra132-norrin.dts +4 -1
index 62f33fc84e3e..3c0b4d7bfa6f 100644
@@ -10,9 +10,12 @@
 	aliases {
 		rtc0 = "/i2c@0,7000d000/as3722@40";
 		rtc1 = "/rtc@0,7000e000";
+		serial0 = &uarta;
 	};
 
-	chosen { };
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 
 	memory {
 		device_type = "memory";
arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi +4 -0
index ece0dec61fae..73ba58260817 100644
@@ -9,6 +9,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x0 0xc0000000>;
Signature · 1 line
2.1.4

A message that is not in the archive (sent off-list or not yet received): 1455025920-21875-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#4 lore raw

Re: [PATCH 2/2] ARM64: tegra: Add stdout-path for various boards

Quoted 6 lines · Jon Hunter

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

For tegra132-norrin the alias serial0 is not defined and so add this.

Quoted 7 lines

This has been tested on tegra132-norrin and tegra210-p2371-0000.

---
 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 5 ++++-
 arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 4 ++++
 2 files changed, 8 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry

Acked-by
#5 lore raw
In reply to a message not in the archive
Quoted 19 lines · Jon Hunter

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

This has been tested on boards, tegra20-trimslice, tegra30-beaver, tegra114-dalmore and tegra124-jetson-tk1.

---

The only boards that I have not modified are tegra114-roth and tegra114-tn7 because these boards have two entries for console in the *.dts file. AFAICT we cannot suppport multiple consoles via the stdout-path and if a console is specified by the kernel boot parameters then this sets the kernel variable "console_set_on_cmdline" and prevents the stdout-path console being registered. If there is a better way to handle these boards via device-tree let me know.

Quoted 16 lines
 arch/arm/boot/dts/tegra114-dalmore.dts        | 4 ++++
 arch/arm/boot/dts/tegra124-jetson-tk1.dts     | 4 ++++
 arch/arm/boot/dts/tegra124-nyan.dtsi          | 4 ++++
 arch/arm/boot/dts/tegra124-venice2.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-harmony.dts         | 4 ++++
 arch/arm/boot/dts/tegra20-iris-512.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-medcom-wide.dts     | 4 ++++
 arch/arm/boot/dts/tegra20-paz00.dts           | 4 ++++
 arch/arm/boot/dts/tegra20-seaboard.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-tamonten.dtsi       | 4 ++++
 arch/arm/boot/dts/tegra20-trimslice.dts       | 4 ++++
 arch/arm/boot/dts/tegra20-ventana.dts         | 4 ++++
 arch/arm/boot/dts/tegra20-whistler.dts        | 4 ++++
 arch/arm/boot/dts/tegra30-apalis-eval.dts     | 4 ++++
 arch/arm/boot/dts/tegra30-beaver.dts          | 4 ++++
 arch/arm/boot/dts/tegra30-cardhu.dtsi         | 4 ++++

For

Quoted 3 lines
 arch/arm/boot/dts/tegra30-apalis-eval.dts     | 4 ++++
 arch/arm/boot/dts/tegra30-colibri-eval-v3.dts | 4 ++++
 arch/arm/boot/dts/tegra20-iris-512.dts        | 4 ++++

--
Stefan

#6 lore raw
In reply to a message not in the archive
Quoted 10 lines · Jon Hunter

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

This has been tested on boards, tegra20-trimslice, tegra30-beaver, tegra114-dalmore and tegra124-jetson-tk1.

---

Quoted 8 lines

The only boards that I have not modified are tegra114-roth and tegra114-tn7 because these boards have two entries for console in the *.dts file. AFAICT we cannot suppport multiple consoles via the stdout-path and if a console is specified by the kernel boot parameters then this sets the kernel variable "console_set_on_cmdline" and prevents the stdout-path console being registered. If there is a better way to handle these boards via device-tree let me know.

These two boards require a hardcoded command-line in the DT anyway, since the bootloader's command-line cannot be overridden (due to bad bootloader design). So it seems ok to me to keep specifying the boot console there for them.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#7 lore raw
In reply to a message not in the archive

Hi Thierry,

I forgot about these patches. Not urgent, but may be we can queue them for v4.7.

Cheers
Jon

Quoted 294 lines · Jon Hunter

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

This has been tested on boards, tegra20-trimslice, tegra30-beaver, tegra114-dalmore and tegra124-jetson-tk1.

---

The only boards that I have not modified are tegra114-roth and tegra114-tn7 because these boards have two entries for console in the *.dts file. AFAICT we cannot suppport multiple consoles via the stdout-path and if a console is specified by the kernel boot parameters then this sets the kernel variable "console_set_on_cmdline" and prevents the stdout-path console being registered. If there is a better way to handle these boards via device-tree let me know.

 arch/arm/boot/dts/tegra114-dalmore.dts        | 4 ++++
 arch/arm/boot/dts/tegra124-jetson-tk1.dts     | 4 ++++
 arch/arm/boot/dts/tegra124-nyan.dtsi          | 4 ++++
 arch/arm/boot/dts/tegra124-venice2.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-harmony.dts         | 4 ++++
 arch/arm/boot/dts/tegra20-iris-512.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-medcom-wide.dts     | 4 ++++
 arch/arm/boot/dts/tegra20-paz00.dts           | 4 ++++
 arch/arm/boot/dts/tegra20-seaboard.dts        | 4 ++++
 arch/arm/boot/dts/tegra20-tamonten.dtsi       | 4 ++++
 arch/arm/boot/dts/tegra20-trimslice.dts       | 4 ++++
 arch/arm/boot/dts/tegra20-ventana.dts         | 4 ++++
 arch/arm/boot/dts/tegra20-whistler.dts        | 4 ++++
 arch/arm/boot/dts/tegra30-apalis-eval.dts     | 4 ++++
 arch/arm/boot/dts/tegra30-beaver.dts          | 4 ++++
 arch/arm/boot/dts/tegra30-cardhu.dtsi         | 4 ++++
 arch/arm/boot/dts/tegra30-colibri-eval-v3.dts | 4 ++++
 17 files changed, 68 insertions(+)
arch/arm/boot/dts/tegra114-dalmore.dts +4 -0
index 8b7aa0dcdc6e..b5748eeed473 100644
@@ -18,6 +18,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x80000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra124-jetson-tk1.dts +4 -0
index 4ee2e63e11d0..a7264a15080a 100644
@@ -19,6 +19,10 @@
 		serial2 = &uartb;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x0 0x80000000 0x0 0x80000000>;
 	};
arch/arm/boot/dts/tegra124-nyan.dtsi +4 -0
index ec1aa64ded68..e2cd39e3c95e 100644
@@ -8,6 +8,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x0 0x80000000 0x0 0x80000000>;
 	};
arch/arm/boot/dts/tegra124-venice2.dts +4 -0
index cfbdf429b45d..604f4b7c2685 100644
@@ -13,6 +13,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x0 0x80000000 0x0 0x80000000>;
 	};
arch/arm/boot/dts/tegra20-harmony.dts +4 -0
index b926a07b9443..4b73c76f981a 100644
@@ -13,6 +13,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-iris-512.dts +4 -0
index 1dd7d7bfdfcc..bb56dfe9e10c 100644
@@ -11,6 +11,10 @@
 		serial1 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	host1x@50000000 {
 		hdmi@54280000 {
 			status = "okay";
arch/arm/boot/dts/tegra20-medcom-wide.dts +4 -0
index 9b87526ab0b7..34c6588e92ef 100644
@@ -10,6 +10,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	pwm@7000a000 {
 		status = "okay";
 	};
arch/arm/boot/dts/tegra20-paz00.dts +4 -0
index ed7e1009326c..81a10a9df814 100644
@@ -14,6 +14,10 @@
 		serial1 = &uartc;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x20000000>;
 	};
arch/arm/boot/dts/tegra20-seaboard.dts +4 -0
index aea8994b35f2..0aed748567aa 100644
@@ -13,6 +13,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-tamonten.dtsi +4 -0
index 13d4e6185275..025e9e8037da 100644
@@ -10,6 +10,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x20000000>;
 	};
arch/arm/boot/dts/tegra20-trimslice.dts +4 -0
index d99af4ef9c64..69d25ca47e04 100644
@@ -13,6 +13,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-ventana.dts +4 -0
index 04c58e9ca490..c61533a9bf0b 100644
@@ -13,6 +13,10 @@
 		serial0 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra20-whistler.dts +4 -0
index 340d81108df1..bd7658572239 100644
@@ -13,6 +13,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x00000000 0x20000000>;
 	};
arch/arm/boot/dts/tegra30-apalis-eval.dts +4 -0
index f2879cfcca62..b914bcb381d7 100644
@@ -17,6 +17,10 @@
 		serial3 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	pcie-controller@00003000 {
 		status = "okay";
 
arch/arm/boot/dts/tegra30-beaver.dts +4 -0
index 3dede3934446..1eca3b28ac64 100644
@@ -12,6 +12,10 @@
 		serial0 = &uarta;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x80000000 0x7ff00000>;
 	};
arch/arm/boot/dts/tegra30-cardhu.dtsi +4 -0
index bb1ca158273c..de9d6ccace14 100644
@@ -35,6 +35,10 @@
 		serial1 = &uartc;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x80000000 0x40000000>;
 	};
arch/arm/boot/dts/tegra30-colibri-eval-v3.dts +4 -0
index 3ff019f47d00..93e1ffd95bfa 100644
@@ -15,6 +15,10 @@
 		serial2 = &uartd;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	host1x@50000000 {
 		dc@54200000 {
 			rgb {
#8 lore raw
In reply to a message not in the archive
Quoted 8 lines · Jon Hunter

For Tegra boards, the device-tree alias serial0 is used for the console and so add the stdout-path information so that the console no longer needs to be passed via the kernel boot parameters.

This has been tested on boards, tegra20-trimslice, tegra30-beaver, tegra114-dalmore and tegra124-jetson-tk1.

Applied, thanks.

Thierry