Skip to contentSkip to conversation

ASoC: dapm: Remove unneeded variable ret returning 0

PATCH In review Rajan Vaja 2 participants 2 messages Feb 11, 2016 – Mar 5, 2016

Subsystems (2)
lore
Share & tools
lore

Rajan Vaja

author
#0 lore raw

PATCH 1/1 ASoC: dapm: Remove unneeded variable ret returning 0

This patch fixes coccicheck report:
Unneeded variable: "ret". Return "0" on line 2817

Remove unneccesary variable ret created to return zero.

---
 sound/soc/soc-dapm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/soc-dapm.c +2 -2
index 5a2812f..8dc395f 100644
@@ -2805,7 +2805,7 @@ EXPORT_SYMBOL_GPL(snd_soc_dapm_add_routes);
 int snd_soc_dapm_del_routes(struct snd_soc_dapm_context *dapm,
 			    const struct snd_soc_dapm_route *route, int num)
 {
-	int i, ret = 0;
+	int i;
 
 	mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_INIT);
 	for (i = 0; i < num; i++) {
@@ -2814,7 +2814,7 @@ int snd_soc_dapm_del_routes(struct snd_soc_dapm_context *dapm,
 	}
 	mutex_unlock(&dapm->card->dapm_mutex);
 
-	return ret;
+	return 0;
 }
 EXPORT_SYMBOL_GPL(snd_soc_dapm_del_routes);
 
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw

Applied "ASoC: dapm: Remove unneeded variable ret returning 0" to the asoc tree

The patch

ASoC: dapm: Remove unneeded variable ret returning 0

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From e066ea2214f77e13e24344313243f9b3a182d3c4 Mon Sep 17 00:00:00 2001

From: Rajan Vaja <[email protected]>
Date: Thu, 11 Feb 2016 11:23:35 +0530
Subject: [PATCH] ASoC: dapm: Remove unneeded variable ret returning 0

This patch fixes coccicheck report:
Unneeded variable: "ret". Return "0" on line 2817

Remove unneccesary variable ret created to return zero.

---
 sound/soc/soc-dapm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/soc-dapm.c +2 -2
index 5a2812fa8946..8dc395f15049 100644
@@ -2805,7 +2805,7 @@ EXPORT_SYMBOL_GPL(snd_soc_dapm_add_routes);
 int snd_soc_dapm_del_routes(struct snd_soc_dapm_context *dapm,
 			    const struct snd_soc_dapm_route *route, int num)
 {
-	int i, ret = 0;
+	int i;
 
 	mutex_lock_nested(&dapm->card->dapm_mutex, SND_SOC_DAPM_CLASS_INIT);
 	for (i = 0; i < num; i++) {
@@ -2814,7 +2814,7 @@ int snd_soc_dapm_del_routes(struct snd_soc_dapm_context *dapm,
 	}
 	mutex_unlock(&dapm->card->dapm_mutex);
 
-	return ret;
+	return 0;
 }
 EXPORT_SYMBOL_GPL(snd_soc_dapm_del_routes);
 
Signature · 1 line
2.7.0