Skip to contentSkip to conversation

gpio: ts4800: Fixup flags argument for bgpio_init

PATCH In review Axel Lin 2 participants 2 messages Feb 12, 2016 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: ts4800: Fixup flags argument for bgpio_init

BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER is 0. Fixup the trivial typo.

Signed-off-by Axel Lin <[email protected]>

---
Hi Julien,
I don't have this h/w, can you review and test if this patch works. Thanks,
Axel

 drivers/gpio/gpio-ts4800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-ts4800.c +1 -1
index c4908a4..c244c31 100644
@@ -49,7 +49,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
 	retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
 			    base_addr + OUTPUT_REG_OFFSET, NULL,
 			    base_addr + DIRECTION_REG_OFFSET, NULL,
-			    BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+			    BGPIOF_BIG_ENDIAN | BGPIOF_BIG_ENDIAN_BYTE_ORDER);
 	if (retval) {
 		dev_err(&pdev->dev, "bgpio_init failed\n");
 		return retval;
Signature · 1 line
2.1.4
#1 lore raw

Hi Alex,

----- Original Message -----

Quoted 7 lines

From: "Axel Lin" <[email protected]>
To: "Linus Walleij" <[email protected]>
Cc: "Julien Grossholtz" <[email protected]>, "Alexandre Courbot" <[email protected]>, [email protected]
Sent: Thursday, February 11, 2016 11:16:30 PM
Subject: [PATCH RFT] gpio: ts4800: Fixup flags argument for bgpio_init

Quoted 7 lines

BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER is 0. Fixup the trivial typo.

Signed-off-by Axel Lin <[email protected]>

---
Hi Julien,
I don't have this h/w, can you review and test if this patch works.

No, this patch is not working. The big endian flags where a mistake. Therefore I submitted a patch to remove them:
[PATCH v2] gpio: TS-4800: remove useless bgpio_init flags.

There is no flag required at all for bgpio_init,
I ran my tests and it worked as expected.

Thank you for proposing a solution.

Quoted 21 lines

Thanks,
Axel

drivers/gpio/gpio-ts4800.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-ts4800.c +1 -2
index c4908a4..c244c31 100644
@@ -49,7 +49,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
 	retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
 			    base_addr + OUTPUT_REG_OFFSET, NULL,
 			    base_addr + DIRECTION_REG_OFFSET, NULL,
-			    BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+			    BGPIOF_BIG_ENDIAN | BGPIOF_BIG_ENDIAN_BYTE_ORDER);
 	if (retval) {
 		dev_err(&pdev->dev, "bgpio_init failed\n");
 		return retval;
--

2.1.4