autotools: Correct dependency search logic error

PATCH New Richard Purdie 1 participant 1 message Feb 12, 2016

Share & tools

Richard Purdie

author

2016-02-12 11:34 UTC #0 lore raw

PATCH 1/1 autotools: Correct dependency search logic error

We go to the effort of finding the value of start, we should then use it rather than relying on the value of dep being preserved from the previous loop. Took me far too long to notice this issue when changing the code.

Also drop an unused variable.

Signed-off-by Richard Purdie <[email protected]>

meta/classes/autotools.bbclass +2 -3

index abbc782..a5f2bff 100644
@@ -160,8 +160,8 @@ python autotools_copy_aclocals () {
     # We need to find configure tasks which are either from <target> -> <target>
     # or <native> -> <native> but not <target> -> <native> unless they're direct
     # dependencies. This mirrors what would get restored from sstate.
-    done = [dep]
-    next = [dep]
+    done = [start]
+    next = [start]
     while next:
         new = []
         for dep in next:

@@ -188,7 +188,6 @@ python autotools_copy_aclocals () {
     #bb.warn(str(configuredeps2))
 
     cp = []
-    siteconf = []    
     for c in configuredeps:
         if c.endswith("-native"):
             manifest = d.expand("${SSTATE_MANIFESTS}/manifest-${BUILD_ARCH}-%s.populate_sysroot" % c)