irqchip/ts4800: Make ts4800_ic_ops static const

PATCH Applied Axel Lin 3 participants 3 messages Feb 14, 2016 – Feb 18, 2016 irqchip drivers

Share & tools

Axel Lin

author

2016-02-14 13:50 UTC #0 lore raw

PATCH 1/1 irqchip/ts4800: Make ts4800_ic_ops static const

ts4800_ic_ops is only referenced in this driver, so make it static. In additional, it's never get modified thus also make it const.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/irqchip/irq-ts4800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/irqchip/irq-ts4800.c +1 -1

index 4192bdc..2325fb3 100644
@@ -59,7 +59,7 @@ static int ts4800_irqdomain_map(struct irq_domain *d, unsigned int irq,
 	return 0;
 }
 
-struct irq_domain_ops ts4800_ic_ops = {
+static const struct irq_domain_ops ts4800_ic_ops = {
 	.map = ts4800_irqdomain_map,
 	.xlate = irq_domain_xlate_onecell,
 };

Signature · 1 line

2.1.4

Damien Riegel

Reviewed-by on v1 1/1

2016-02-15 19:23 UTC #1 lore raw

Quoted 4 lines · Axel Lin

ts4800_ic_ops is only referenced in this driver, so make it static. In additional, it's never get modified thus also make it const.
Signed-off-by Axel Lin <[email protected]>

Reviewed-by Damien Riegel <[email protected]>

Thanks for catching this.

Jason Cooper

Applied

2016-02-18 02:12 UTC #2 lore raw

In reply to Axel Lin

Quoted 7 lines · Axel Lin

ts4800_ic_ops is only referenced in this driver, so make it static. In additional, it's never get modified thus also make it const.
Signed-off-by Axel Lin <[email protected]>
---
 drivers/irqchip/irq-ts4800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to irqchip/core with Damien's Reviewed-by.

thx,

Jason.