Skip to contentSkip to conversation

Patch "USB: visor: fix null-deref at probe" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Feb 14, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: visor: fix null-deref at probe

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-visor-fix-null-deref-at-probe.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cac9b50b0d75a1d50d6c056ff65c005f3224c8e0 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Tue, 12 Jan 2016 12:05:20 +0100
Subject: USB: visor: fix null-deref at probe

From: Johan Hovold <[email protected]>

commit cac9b50b0d75a1d50d6c056ff65c005f3224c8e0 upstream.

Fix null-pointer dereference at probe should a (malicious) Treo device lack the expected endpoints.

Specifically, the Treo port-setup hack was dereferencing the bulk-in and interrupt-in urbs without first making sure they had been allocated by core.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/usb/serial/visor.c |    5 +++++
 1 file changed, 5 insertions(+)
drivers/usb/serial/visor.c +5 -0
@@ -551,6 +551,11 @@ static int treo_attach(struct usb_serial
 		(serial->num_interrupt_in == 0))
 		return 0;
 
+	if (serial->num_bulk_in < 2 || serial->num_interrupt_in < 2) {
+		dev_err(&serial->interface->dev, "missing endpoints\n");
+		return -ENODEV;
+	}
+
 	/*
 	* It appears that Treos and Kyoceras want to use the
 	* 1st bulk in endpoint to communicate with the 2nd bulk out endpoint,

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/spi-fix-parent-device-reference-leak.patch queue-3.10/usb-visor-fix-null-deref-at-probe.patch queue-3.10/usb-serial-visor-fix-crash-on-detecting-device-without-write_urbs.patch