ed_0.5: Handle --disable-static option
PATCH 1/1 ed_0.5: Handle --disable-static option
Also clean up use of immediate expansion as there are cleaner mechanisms now.
meta/recipes-extended/ed/ed_0.5.bb +3 -4
@@ -15,7 +15,6 @@ inherit autotools texinfo EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}' 'CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'" -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--disable-dependency-tracking', ' ')}" -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--disable-silent-rules', ' ')}" - - +CONFIGUREOPTS_remove = "--disable-dependency-tracking" +CONFIGUREOPTS_remove = "--disable-silent-rules" +EXTRA_OECONF_remove = "--disable-static"
Quoted 20 lines · Richard Purdie
Also clean up use of immediate expansion as there are cleaner mechanisms now.
Signed-off-by Richard Purdie <[email protected]>meta/recipes-extended/ed/ed_0.5.bb +0
-0@@ -15,7 +15,6 @@ inherit autotools texinfo EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}''CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
-CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--disable-dependency-tracking', ' ')}" -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--disable-silent-rules', ' ')}"
meta/recipes-extended/ed/ed_0.5.bb inherit autotools texinfo · line 20
Quoted 5 lines
meta/recipes-extended/ed/ed_0.5.bb +3
-2- - +CONFIGUREOPTS_remove = "--disable-dependency-tracking" +CONFIGUREOPTS_remove = "--disable-silent-rules" +EXTRA_OECONF_remove = "--disable-static"
This will be impossible to undo in a bbappend..
Quoted 19 lines · Christopher Larson
Quoted 15 lines · Richard Purdie
Also clean up use of immediate expansion as there are cleaner mechanisms now.
Signed-off-by Richard Purdie <[email protected]>meta/recipes renamed from meta/recipes-extended/ed/ed_0.5.bb +0
-1-extended/ed/ed_0.5.bbindex 143e636..e2df13f 100644
meta/recipes-extended/ed/ed_0.5.bb +0
-0@@ -15,7 +15,6 @@ inherit autotools texinfo EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}''CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
Quoted 10 lines
meta/recipes-extended/ed/ed_0.5.bb inherit autotools texinfo · line 20
Quoted 9 lines
meta/recipes-extended/ed/ed_0.5.bb +3
-6-CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('- -disable-dependency-tracking', ' ')}" -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('- -disable-silent-rules', ' ')}" - - +CONFIGUREOPTS_remove = "--disable-dependency-tracking" +CONFIGUREOPTS_remove = "--disable-silent-rules" +EXTRA_OECONF_remove = "--disable-static"This will be impossible to undo in a bbappend..
I appreciate that and we've talked about ways we likely need to extend the API for that.
In this case, I would ask why would anyone want/need to add in a configure option which configure doesn't support?
I guess someone could patch it, however if they do that, the could also pick a different option name.
Cheers,
Richard
Quoted 31 lines · Richard Purdie
Quoted 19 lines · Christopher Larson
Quoted 15 lines · Richard Purdie
Also clean up use of immediate expansion as there are cleaner mechanisms now.
Signed-off-by Richard Purdie <[email protected]>meta/recipes renamed from meta/recipes-extended/ed/ed_0.5.bb +0
-1-extended/ed/ed_0.5.bbindex 143e636..e2df13f 100644
meta/recipes-extended/ed/ed_0.5.bb +0
-0@@ -15,7 +15,6 @@ inherit autotools texinfo EXTRA_OECONF = "'CC=${CC}' 'CXX=${CXX}' 'CFLAGS=${CFLAGS}''CXXFLAGS=${CXXFLAGS}' 'CPPFLAGS=${CPPFLAGS}' 'LDFLAGS=${LDFLAGS}'"
Quoted 10 lines
meta/recipes-extended/ed/ed_0.5.bb inherit autotools texinfo · line 20
Quoted 9 lines
meta/recipes-extended/ed/ed_0.5.bb +3
-6-CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('- -disable-dependency-tracking', ' ')}" -CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('- -disable-silent-rules', ' ')}" - - +CONFIGUREOPTS_remove = "--disable-dependency-tracking" +CONFIGUREOPTS_remove = "--disable-silent-rules" +EXTRA_OECONF_remove = "--disable-static"This will be impossible to undo in a bbappend..
Quoted 6 lines
I appreciate that and we've talked about ways we likely need to extend the API for that.
In this case, I would ask why would anyone want/need to add in a configure option which configure doesn't support?
Right, fair enough, I didn't read the patch carefully enough. Sorry for the distraction.