Skip to contentSkip to conversation

ARM64: Don't set the default console to ttyAMA0

PATCH New Jon Hunter 3 participants 4 messages Feb 17, 2016 – Feb 29, 2016

lore
Share & tools
lore

Jon Hunter

author
#0 lore raw

PATCH 1/1 ARM64: Don't set the default console to ttyAMA0

When booting Tegra210 with a minimal rootfs it may not be necessary to specify any boot parameters via the kernel command line as information for console is described via the "stdout-path" node the device-tree blob. However, when there are no boot parameter specified, no output is seen on the console in the case of Tegra210 and this is because the default command line in the ARM64 defconfig specifies the console as ttyAMA0 which takes precedence over the "stdout-path" node from device-tree.

ttyAMAx is used for AMBA PL011 serial ports, but not all ARM64 platforms use this serial driver. Therefore, remove the default command line entry from the ARM64 defconfig to ensure that ttyAMA0 does not get set as the default console if no kernel command line is specified.

---
 arch/arm64/configs/defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/configs/defconfig +0 -1
index d21631760ec7..caecb66188be 100644
@@ -64,7 +64,6 @@ CONFIG_KSM=y
 CONFIG_TRANSPARENT_HUGEPAGE=y
 CONFIG_CMA=y
 CONFIG_XEN=y
-CONFIG_CMDLINE="console=ttyAMA0"
 # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
 CONFIG_COMPAT=y
 CONFIG_CPU_IDLE=y
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 ARM64: Don't set the default console to ttyAMA0

Dear Jon,

Quoted 9 lines · On Wed, 17 Feb 2016 16:43:42 +0000 Jon Hunter wrote:

When booting Tegra210 with a minimal rootfs it may not be necessary to specify any boot parameters via the kernel command line as information for console is described via the "stdout-path" node the device-tree blob. However, when there are no boot parameter specified, no output is seen on the console in the case of Tegra210 and this is because the default command line in the ARM64 defconfig specifies the console as ttyAMA0 which takes precedence over the "stdout-path" node from device-tree.

Quoted 6 lines

ttyAMAx is used for AMBA PL011 serial ports, but not all ARM64 platforms use this serial driver. Therefore, remove the default command line entry from the ARM64 defconfig to ensure that ttyAMA0 does not get set as the default console if no kernel command line is specified.

We need this patch as well. Thanks

Quoted 16 lines
---
 arch/arm64/configs/defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/configs/defconfig +0 -1
index d21631760ec7..caecb66188be 100644
@@ -64,7 +64,6 @@ CONFIG_KSM=y
 CONFIG_TRANSPARENT_HUGEPAGE=y
 CONFIG_CMA=y
 CONFIG_XEN=y
-CONFIG_CMDLINE="console=ttyAMA0"
 # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
 CONFIG_COMPAT=y
 CONFIG_CPU_IDLE=y
author
#2 lore raw

PATCH 1/1 ARM64: Don't set the default console to ttyAMA0

In reply to Jon Hunter

Hi Will, Catalin,

Any feedback on this?

Cheers
Jon

Quoted 32 lines · Jon Hunter

When booting Tegra210 with a minimal rootfs it may not be necessary to specify any boot parameters via the kernel command line as information for console is described via the "stdout-path" node the device-tree blob. However, when there are no boot parameter specified, no output is seen on the console in the case of Tegra210 and this is because the default command line in the ARM64 defconfig specifies the console as ttyAMA0 which takes precedence over the "stdout-path" node from device-tree.

ttyAMAx is used for AMBA PL011 serial ports, but not all ARM64 platforms use this serial driver. Therefore, remove the default command line entry from the ARM64 defconfig to ensure that ttyAMA0 does not get set as the default console if no kernel command line is specified.

---
 arch/arm64/configs/defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/configs/defconfig +0 -1
index d21631760ec7..caecb66188be 100644
@@ -64,7 +64,6 @@ CONFIG_KSM=y
 CONFIG_TRANSPARENT_HUGEPAGE=y
 CONFIG_CMA=y
 CONFIG_XEN=y
-CONFIG_CMDLINE="console=ttyAMA0"
 # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
 CONFIG_COMPAT=y
 CONFIG_CPU_IDLE=y
#3 lore raw

PATCH 1/1 ARM64: Don't set the default console to ttyAMA0

Quoted 1 line · Jon Hunter

Any feedback on this?

I plan to mop up the defconfig updates at -rc1, since there are a few of them and merging them in dribs and drabs is a bit of a pain.

Will