ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
Subsystems (3)
PATCH 1/1 ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
All pinctrl nodes for the Atmel pinctrl controller need to have their bias configuration explicitly defined. Otherwise, the pinctrl mapping is not valid.
It works for now as the pinctrl driver proceeds even with invalid mappings, but this can become an issue, if the pinctrl driver starts to require valid mappings. Additionally, the pin is not protected from being remapped later by an other driver.
There is an external 1k? pull-up to 3.3V, so no bias is required on the Ethernet PHY's interrupt line.
--- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/at91-sama5d2_xplained.dts +1 -0
@@ -308,6 +308,7 @@ pinctrl_macb0_phy_irq: macb0_phy_irq { pinmux = <PIN_PC9__GPIO>; + bias-disable; }; pinctrl_pdmic_default: pdmic_default {
Signature · 1 line
2.5.0
Quoted 9 lines · Romain Izard
All pinctrl nodes for the Atmel pinctrl controller need to have their bias configuration explicitly defined. Otherwise, the pinctrl mapping is not valid.
It works for now as the pinctrl driver proceeds even with invalid mappings, but this can become an issue, if the pinctrl driver starts to require valid mappings. Additionally, the pin is not protected from being remapped later by an other driver.
Quoted 4 lines
There is an external 1kΩ pull-up to 3.3V, so no bias is required on the Ethernet PHY's interrupt line.
Signed-off-by Romain Izard <[email protected]>
Thanks
Quoted 23 lines
--- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/at91-sama5d2_xplained.dts +1
-0@@ -308,6 +308,7 @@ pinctrl_macb0_phy_irq: macb0_phy_irq { pinmux = <PIN_PC9__GPIO>; + bias-disable; }; pinctrl_pdmic_default: pdmic_default {Signature · 6 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Romain Izard
All pinctrl nodes for the Atmel pinctrl controller need to have their bias configuration explicitly defined. Otherwise, the pinctrl mapping is not valid.
It works for now as the pinctrl driver proceeds even with invalid mappings, but this can become an issue, if the pinctrl driver starts to require valid mappings. Additionally, the pin is not protected from being remapped later by an other driver.
Quoted 4 lines
There is an external 1kΩ pull-up to 3.3V, so no bias is required on the Ethernet PHY's interrupt line.
Signed-off-by Romain Izard <[email protected]>
And queued on at91-4.5-dt.
Thanks! Bye,
Quoted 17 lines
--- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/at91-sama5d2_xplained.dts +1
-0@@ -308,6 +308,7 @@ pinctrl_macb0_phy_irq: macb0_phy_irq { pinmux = <PIN_PC9__GPIO>; + bias-disable; }; pinctrl_pdmic_default: pdmic_default {
Signature · 5 lines
Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html