batman-adv: Throughput meter
Subsystems (2)
cover batman-adv: Throughput meter
Hi,
do you still remember GSOC 2012? Yes, it is really long ago. It was a time when winters were still cold, summers still hot and it was still politically correct to say "bandwidth meter" when you actually meant "throughput meter".
Three students tried their best to implement some of the ideas floating around in the B.A.T.M.A.N. advanced community. And after some more work, most of the features reached the finishing line. TVLV [1] and the fragmentation v2 [2] were both integrated as part of the COMPAT 15 bump. But the "bandwidth meter" [3] was never ready to being merged.
Nevertheless, the lessons learned in the first implementation [4] inspired different people to continue working on it. Especially Antonio Quartulli worked on his own version to increase its usefulness. And this feature makes even more sense since we reached the new "throughput based metric" time epoch with the introduction of B.A.T.M.A.N. V.
I hope we can reignite interest in this feature with a rebased and refurbished version of this patchset. Both the batman-adv and batctl patches are based on the newest revision in their respective master branches. Also a branch called "tp_meter" was created in the batctl.git and batman-adv.git repository with these patches already applied.
batman-adv
==========
Antonio Quartulli (2):
batman-adv: return netdev status in the TX path
batman-adv: use another ICMP packet when sending command from userspace
batman-adv: throughput meter implementation
Sven Eckelmann (1):
batman-adv: Add compatibility code for to_delayed_work
compat-include/linux/netdevice.h | 17 + compat-include/linux/workqueue.h | 46 ++ net/batman-adv/Makefile | 1 + net/batman-adv/fragmentation.c | 41 +- net/batman-adv/fragmentation.h | 6 +- net/batman-adv/icmp_socket.c | 225 +++--- net/batman-adv/icmp_socket.h | 5 +- net/batman-adv/main.c | 6 +- net/batman-adv/main.h | 24 +- net/batman-adv/packet.h | 120 ++++ net/batman-adv/routing.c | 33 +- net/batman-adv/send.c | 25 +- net/batman-adv/soft-interface.c | 2 + net/batman-adv/tp_meter.c | 1451 ++++++++++++++++++++++++++++++++++++++ net/batman-adv/tp_meter.h | 34 + net/batman-adv/types.h | 113 +++ 16 files changed, 2005 insertions(+), 144 deletions(-)
batctl
======
Antonio Quartulli (1):
batctl: introduce throughput meter support
Makefile | 2 +- main.c | 6 ++ man/batctl.8 | 24 ++++++- packet.h | 120 +++++++++++++++++++++++++++++++ tcpdump.c | 14 +++- tp_meter.c | 227 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tp_meter.h | 22 ++++++ 7 files changed, 411 insertions(+), 4 deletions(-)
Kind regards,
Sven
[1] https://www.open-mesh.org/projects/open-mesh/wiki/2012-10-01-GSoC-2012-Spyros-Gasteros-Final-Report
[2] https://www.open-mesh.org/projects/open-mesh/wiki/2012-09-24-GSoC-2012-Martin-Hundebolls-Final-Report
[3] https://www.open-mesh.org/projects/open-mesh/wiki/2012-10-06-GSoC-2012-Edo-Monticellis-Final-Report
[4] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2012-August/007924.html
RFC 1/5 batman-adv: return netdev status in the TX path
From: Antonio Quartulli <[email protected]>
Return the proper netdev TX status along the TX path so that the tp_meter can understand when the queue is full and should stop sending packets.
--- compat-include/linux/netdevice.h | 17 +++++++++++++++++ net/batman-adv/fragmentation.c | 41 ++++++++++++++++++++++++---------------- net/batman-adv/fragmentation.h | 6 +++--- net/batman-adv/main.c | 4 +++- net/batman-adv/routing.c | 24 +++++++++++++---------- net/batman-adv/send.c | 25 ++++++++++++------------ 6 files changed, 75 insertions(+), 42 deletions(-)
compat-include/linux/netdevice.h +17 -0
@@ -32,6 +32,23 @@#if LINUX_VERSION_CODE <KERNEL_VERSION (2 ,6 ,33 ) +static inline bool dev_xmit_complete (int rc) +{ +/* successful transmission */ +if (rc ==NETDEV_TX_OK ) +return true; + +/* error while transmitting, driver consumed skb */ +if (rc <0 ) +return true; + +/* error while queueing to a different device, driver consumed skb */ +if (rc &NET_XMIT_MASK ) +return true; + +return false; +} +#define unregister_netdevice_queue (dev, head) unregister_netdevice(dev)#endif /* < KERNEL_VERSION(2, 6, 33) */
net/batman-adv/fragmentation.c +25 -16
89 lines not on this page · raw message
net/batman-adv/fragmentation.h +3 -3
@@ -34,9 +34,9 @@ bool batadv_frag_skb_fwd(struct sk_buff *skb, struct batadv_orig_node *orig_node_src);bool batadv_frag_skb_buffer (struct sk_buff **skb,struct batadv_orig_node *orig_node); -bool batadv_frag_send_packet (struct sk_buff *skb, -struct batadv_orig_node *orig_node, -struct batadv_neigh_node *neigh_node); +int batadv_frag_send_packet (struct sk_buff *skb, +struct batadv_orig_node *orig_node, +struct batadv_neigh_node *neigh_node);/** * batadv_frag_check_entry - check if a list of fragments has timed out
net/batman-adv/main.c +3 -1
@@ -1183,6 +1183,7 @@ void batadv_tvlv_unicast_send(struct batadv_priv *bat_priv, u8 *src,unsigned char *tvlv_buff;unsigned int tvlv_len;ssize_t hdr_len =sizeof (*unicast_tvlv_packet); +int res; orig_node =batadv_orig_hash_find (bat_priv, dst);if (!orig_node)
@@ -1215,7 +1216,8 @@ void batadv_tvlv_unicast_send(struct batadv_priv *bat_priv, u8 *src, tvlv_buff +=sizeof (*tvlv_hdr);memcpy (tvlv_buff, tvlv_value, tvlv_value_len); -if (batadv_send_skb_to_orig (skb, orig_node,NULL ) ==NET_XMIT_DROP ) + res =batadv_send_skb_to_orig (skb, orig_node,NULL ); +if (!(res !=-1 &&dev_xmit_complete (res)))kfree_skb (skb); out:batadv_orig_node_put (orig_node);
net/batman-adv/routing.c +14 -10
@@ -259,7 +259,10 @@ static int batadv_recv_my_icmp_packet(struct batadv_priv *bat_priv, icmph->ttl =BATADV_TTL ; res =batadv_send_skb_to_orig (skb, orig_node,NULL ); -if (res !=NET_XMIT_DROP ) +if (res ==-1 ) + goto out; + +if (dev_xmit_complete (res)) ret =NET_RX_SUCCESS ;break ;
@@ -281,7 +284,7 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv,struct batadv_hard_iface *primary_if =NULL ;struct batadv_orig_node *orig_node =NULL ;struct batadv_icmp_packet *icmp_packet; -int ret =NET_RX_DROP ; +int res, ret =NET_RX_DROP ; icmp_packet = (struct batadv_icmp_packet *)skb->data;
@@ -312,7 +315,8 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv, icmp_packet->msg_type =BATADV_TTL_EXCEEDED ; icmp_packet->ttl =BATADV_TTL ; -if (batadv_send_skb_to_orig (skb, orig_node,NULL ) !=NET_XMIT_DROP ) + res =batadv_send_skb_to_orig (skb, orig_node,NULL ); +if (res !=-1 &&dev_xmit_complete (res)) ret =NET_RX_SUCCESS ; out:
@@ -332,7 +336,7 @@ int batadv_recv_icmp_packet(struct sk_buff *skb,struct ethhdr *ethhdr;struct batadv_orig_node *orig_node =NULL ;int hdr_size =sizeof (struct batadv_icmp_header ); -int ret =NET_RX_DROP ; +int res, ret =NET_RX_DROP ;/* drop packet if it has not necessary minimum size */ if (unlikely (!pskb_may_pull (skb, hdr_size)))
@@ -398,7 +402,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb, icmph->ttl--;/* route it */ -if (batadv_send_skb_to_orig (skb, orig_node, recv_if) !=NET_XMIT_DROP ) + res =batadv_send_skb_to_orig (skb, orig_node, recv_if); +if (res !=-1 &&dev_xmit_complete (res)) ret =NET_RX_SUCCESS ; out:
@@ -633,6 +638,8 @@ static int batadv_route_unicast_packet(struct sk_buff *skb,batadv_skb_set_priority (skb, hdr_len); res =batadv_send_skb_to_orig (skb, orig_node, recv_if); +if (res ==-1 ) + goto out;/* translate transmit result into receive result */ if (res ==NET_XMIT_SUCCESS ) {
@@ -640,12 +647,9 @@ static int batadv_route_unicast_packet(struct sk_buff *skb,batadv_inc_counter (bat_priv,BATADV_CNT_FORWARD );batadv_add_counter (bat_priv,BATADV_CNT_FORWARD_BYTES , skb->len +ETH_HLEN ); - - ret =NET_RX_SUCCESS ; - }else if (res ==NET_XMIT_POLICED ) { -/* skb was buffered and consumed */ - ret =NET_RX_SUCCESS ; } +if (dev_xmit_complete (res)) + ret =NET_RX_SUCCESS ; out:if (orig_node)
net/batman-adv/send.c +13 -12
@@ -154,8 +154,11 @@ int batadv_send_unicast_skb(struct sk_buff *skb,* host, NULL can be passed as recv_if and no interface alternating is * attempted. * -* Return: NET_XMIT_SUCCESS on success, NET_XMIT_DROP on failure, or -* NET_XMIT_POLICED if the skb is buffered for later transmit. +* Return: -1 on failure (and the skb is not consumed), NET_XMIT_POLICED if the +* skb is buffered for later transmit or the NET_XMIT status returned by the +* lower routine if the packet has been passed down. +* +* If the returning value is not -1 the skb has been consumed. */ int batadv_send_skb_to_orig(struct sk_buff *skb, struct batadv_orig_node *orig_node,
@@ -163,7 +166,7 @@ int batadv_send_skb_to_orig(struct sk_buff *skb, {struct batadv_priv *bat_priv = orig_node->bat_priv;struct batadv_neigh_node *neigh_node; -int ret =NET_XMIT_DROP ; +int ret =-1 ;/* batadv_find_router() increases neigh_nodes refcount if found. */ neigh_node =batadv_find_router (bat_priv, orig_node, recv_if);
@@ -176,8 +179,7 @@ int batadv_send_skb_to_orig(struct sk_buff *skb,if (atomic_read (&bat_priv->fragmentation) && skb->len > neigh_node->if_incoming->net_dev->mtu) {/* Fragment and send packet. */ -if (batadv_frag_send_packet (skb, orig_node, neigh_node)) - ret =NET_XMIT_SUCCESS ; + ret =batadv_frag_send_packet (skb, orig_node, neigh_node); goto out; }
@@ -186,12 +188,10 @@ int batadv_send_skb_to_orig(struct sk_buff *skb,* (i.e. being forwarded). If the packet originates from this node or if * network coding fails, then send the packet as usual. */ -if (recv_if &&batadv_nc_skb_forward (skb, neigh_node)) { +if (recv_if &&batadv_nc_skb_forward (skb, neigh_node)) ret =NET_XMIT_POLICED ; - }else { -batadv_send_unicast_skb (skb, neigh_node); - ret =NET_XMIT_SUCCESS ; - } +else + ret =batadv_send_unicast_skb (skb, neigh_node); out:if (neigh_node)
@@ -317,7 +317,7 @@ int batadv_send_skb_unicast(struct batadv_priv *bat_priv, {struct batadv_unicast_packet *unicast_packet;struct ethhdr *ethhdr; -int ret =NET_XMIT_DROP ; +int res, ret =NET_XMIT_DROP ;if (!orig_node) goto out;
@@ -354,7 +354,8 @@ int batadv_send_skb_unicast(struct batadv_priv *bat_priv,if (batadv_tt_global_client_is_roaming (bat_priv, ethhdr->h_dest, vid)) unicast_packet->ttvn = unicast_packet->ttvn -1 ; -if (batadv_send_skb_to_orig (skb, orig_node,NULL ) !=NET_XMIT_DROP ) + res =batadv_send_skb_to_orig (skb, orig_node,NULL ); +if (res !=-1 &&dev_xmit_complete (res)) ret =NET_XMIT_SUCCESS ; out:
Signature · 1 line
2.7.0
RFC 2/5 batman-adv: use another ICMP packet when sending command from userspace
From: Antonio Quartulli <[email protected]>
In the current code a real batadv ICMP packet is used to communicate from userspace to the module which ICMP operation should be start (the operation to start depends on the size of the received packet). This worked good so far because the same packet was used to perform the only two available ICMP operations and the very same packet received from userspace was also sent over the wire to perform the operation itself.
As soon as we add new and different ICMP operations this model will not work well anymore. To improve this feature make the userspace use a proper packet type to tell the kernel module which operation to start.
The module will then arrange the rest by itself.
--- net/batman-adv/icmp_socket.c | 212 +++++++++++++++++++++++++------------------ net/batman-adv/icmp_socket.h | 5 +- net/batman-adv/packet.h | 15 +++ net/batman-adv/types.h | 2 + 4 files changed, 140 insertions(+), 94 deletions(-)
net/batman-adv/icmp_socket.c +122 -90
@@ -52,8 +52,7 @@static struct batadv_socket_client *batadv_socket_client_hash[256 ];static void batadv_socket_add_packet (struct batadv_socket_client *socket_client, -struct batadv_icmp_header *icmph, -size_t icmp_len); +void *icmp_buffer,size_t icmp_len);void batadv_socket_init (void ) {
@@ -161,7 +160,7 @@ static ssize_t batadv_socket_read(struct file *file, char __user *buf,spin_unlock_bh (&socket_client->lock); packet_len =min (count, socket_packet->icmp_len); - error =copy_to_user (buf, &socket_packet->icmp_packet, packet_len); + error =copy_to_user (buf, &socket_packet->packet, packet_len);kfree (socket_packet);
@@ -171,73 +170,90 @@ static ssize_t batadv_socket_read(struct file *file, char __user *buf,return packet_len; } -static ssize_t batadv_socket_write (struct file *file,const char __user *buff, -size_t len,loff_t *off) +/** +* batadv_socket_write_user - Parse batadv_icmp_user_packet +* @bat_priv: the bat priv with all the icmp socket information +* @socket_client: layer2 icmp socket client data +* @primary_if: the selected primary interface +* @buff: buffer of user data +* @len: length of the data in buff +* +* Return: Number of read bytes from buff or < 0 on errors +*/ +static ssize_t +batadv_socket_write_user (struct batadv_priv *bat_priv, +struct batadv_socket_client *socket_client, +struct batadv_hard_iface *primary_if, +const char __user *buff,size_t len) +{ +struct batadv_icmp_user_packet icmp_user_packet; + +if (copy_from_user (&icmp_user_packet, buff, len)) +return -EFAULT ; + +/* no command supported yet! */ + len = -EINVAL ; + +return len; +} + +/** +* batadv_socket_write_raw - Parse batadv_icmp_packet/batadv_icmp_packet_rr +* @bat_priv: the bat priv with all the icmp socket information +* @socket_client: layer2 icmp socket client data +* @primary_if: the selected primary interface +* @buff: buffer of user data +* @len: length of the data in buff +* +* Return: Number of read bytes from buff or < 0 on errors +*/ +static ssize_t +batadv_socket_write_raw (struct batadv_priv *bat_priv, +struct batadv_socket_client *socket_client, +struct batadv_hard_iface *primary_if, +const char __user *buff,size_t len) { -struct batadv_socket_client *socket_client = file->private_data; -struct batadv_priv *bat_priv = socket_client->bat_priv; -struct batadv_hard_iface *primary_if =NULL ;struct sk_buff *skb; -struct batadv_icmp_packet_rr *icmp_packet_rr; -struct batadv_icmp_header *icmp_header; +struct batadv_icmp_packet_rr icmp_packet, *icmp_buff;struct batadv_orig_node *orig_node =NULL ;struct batadv_neigh_node *neigh_node =NULL ; -size_t packet_len =sizeof (struct batadv_icmp_packet ); +size_t packet_len;u8 *addr; -if (len <sizeof (struct batadv_icmp_header )) { +if (len !=sizeof (struct batadv_icmp_packet_rr ) && + len !=sizeof (struct batadv_icmp_packet )) {batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"Error - can't send packet from char device: invalid packet size\n" );return -EINVAL ; } - primary_if =batadv_primary_if_get_selected (bat_priv); - -if (!primary_if) { - len = -EFAULT ; - goto out; - } - -if (len >=BATADV_ICMP_MAX_PACKET_SIZE ) - packet_len =BATADV_ICMP_MAX_PACKET_SIZE ; -else - packet_len = len; - - skb =netdev_alloc_skb_ip_align (NULL , packet_len +ETH_HLEN ); -if (!skb) { - len = -ENOMEM ; - goto out; - } + packet_len = len; +if (copy_from_user (&icmp_packet, buff, len)) +return -EFAULT ; - skb->priority =TC_PRIO_CONTROL ; -skb_reserve (skb,ETH_HLEN ); - icmp_header = (struct batadv_icmp_header *)skb_put (skb, packet_len); + icmp_packet.uid = socket_client->index; -if (copy_from_user (icmp_header, buff, packet_len)) { - len = -EFAULT ; - goto free_skb; +/* if the compat version does not match, return an error now */ +if (icmp_packet.version !=BATADV_COMPAT_VERSION ) { + icmp_packet.msg_type =BATADV_PARAMETER_PROBLEM ; + icmp_packet.version =BATADV_COMPAT_VERSION ; +batadv_socket_add_packet (socket_client, &icmp_packet, + packet_len); +return len; } -if (icmp_header->packet_type !=BATADV_ICMP ) { +if (icmp_packet.packet_type !=BATADV_ICMP ) {batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"Error - can't send packet from char device: got bogus packet type (expected: BAT_ICMP)\n" ); - len = -EINVAL ; - goto free_skb; +return -EINVAL ; } -switch (icmp_header->msg_type) { +switch (icmp_packet.msg_type) {case BATADV_ECHO_REQUEST : -if (len <sizeof (struct batadv_icmp_packet )) { -batadv_dbg (BATADV_DBG_BATMAN , bat_priv, -"Error - can't send packet from char device: invalid packet size\n" ); - len = -EINVAL ; - goto free_skb; - } -if (atomic_read (&bat_priv->mesh_state) !=BATADV_MESH_ACTIVE ) goto dst_unreach; - orig_node =batadv_orig_hash_find (bat_priv, icmp_header->dst); + orig_node =batadv_orig_hash_find (bat_priv, icmp_packet.dst);if (!orig_node) goto dst_unreach;
@@ -252,47 +268,68 @@ static ssize_t batadv_socket_write(struct file *file, const char __user *buff,if (neigh_node->if_incoming->if_status !=BATADV_IF_ACTIVE ) goto dst_unreach; - icmp_packet_rr = (struct batadv_icmp_packet_rr *)icmp_header; -if (packet_len ==sizeof (*icmp_packet_rr)) { - addr = neigh_node->if_incoming->net_dev->dev_addr; -ether_addr_copy (icmp_packet_rr->rr[0 ], addr); - } -break ;default :batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"Error - can't send packet from char device: got unknown message type\n" ); - len = -EINVAL ; - goto free_skb; +return -EINVAL ; } - icmp_header->uid = socket_client->index; + skb =netdev_alloc_skb_ip_align (NULL , packet_len +ETH_HLEN ); +if (!skb) +return -ENOMEM ; -if (icmp_header->version !=BATADV_COMPAT_VERSION ) { - icmp_header->msg_type =BATADV_PARAMETER_PROBLEM ; - icmp_header->version =BATADV_COMPAT_VERSION ; -batadv_socket_add_packet (socket_client, icmp_header, - packet_len); - goto free_skb; - } + skb->priority =TC_PRIO_CONTROL ; +skb_reserve (skb,ETH_HLEN ); + icmp_buff = (struct batadv_icmp_packet_rr *)skb_put (skb, packet_len); +memcpy (icmp_buff, &icmp_packet, packet_len); -ether_addr_copy (icmp_header->orig, primary_if->net_dev->dev_addr); +ether_addr_copy (icmp_buff->orig, primary_if->net_dev->dev_addr); + +switch (icmp_packet.msg_type) { +case BATADV_ECHO_REQUEST : +if (len ==sizeof (struct batadv_icmp_packet_rr )) { + addr = neigh_node->if_incoming->net_dev->dev_addr; +ether_addr_copy (icmp_packet.rr[0 ], addr); + } +break ; + }batadv_send_unicast_skb (skb, neigh_node); goto out; dst_unreach: - icmp_header->msg_type =BATADV_DESTINATION_UNREACHABLE ; -batadv_socket_add_packet (socket_client, icmp_header, packet_len); -free_skb: -kfree_skb (skb); + icmp_packet.msg_type =BATADV_DESTINATION_UNREACHABLE ; +batadv_socket_add_packet (socket_client, &icmp_packet, packet_len); out: -if (primary_if) -batadv_hardif_put (primary_if);if (neigh_node)batadv_neigh_node_put (neigh_node);if (orig_node)batadv_orig_node_put (orig_node); + +return len; +} + +static ssize_t batadv_socket_write (struct file *file,const char __user *buff, +size_t len,loff_t *off) +{ +struct batadv_socket_client *socket_client = file->private_data; +struct batadv_priv *bat_priv = socket_client->bat_priv; +struct batadv_hard_iface *primary_if; + + primary_if =batadv_primary_if_get_selected (bat_priv); +if (!primary_if) +return -EFAULT ; + +if (len ==sizeof (struct batadv_icmp_user_packet )) + len =batadv_socket_write_user (bat_priv, socket_client, + primary_if, buff, len); +else + len =batadv_socket_write_raw (bat_priv, socket_client, + primary_if, buff, len); + +batadv_hardif_put (primary_if); +return len; }
@@ -340,36 +377,29 @@ err:* batadv_socket_receive_packet - schedule an icmp packet to be sent to * userspace on an icmp socket. * @socket_client: the socket this packet belongs to -* @icmph: pointer to the header of the icmp packet +* @icmp_buffer: pointer to the icmp packet * @icmp_len: total length of the icmp packet */ static void batadv_socket_add_packet (struct batadv_socket_client *socket_client, -struct batadv_icmp_header *icmph, -size_t icmp_len) +void *icmp_buffer,size_t icmp_len) {struct batadv_socket_packet *socket_packet; -size_t len; - - socket_packet =kmalloc (sizeof (*socket_packet),GFP_ATOMIC ); +struct batadv_icmp_packet *icmp_packet; + icmp_packet = (struct batadv_icmp_packet *)icmp_buffer; + socket_packet =kmalloc (sizeof (*socket_packet) + icmp_len,GFP_ATOMIC );if (!socket_packet)return ; - len = icmp_len; -/* check the maximum length before filling the buffer */ -if (len >sizeof (socket_packet->icmp_packet)) - len =sizeof (socket_packet->icmp_packet); - -INIT_LIST_HEAD (&socket_packet->list); -memcpy (&socket_packet->icmp_packet, icmph, len); - socket_packet->icmp_len = len; +memcpy (socket_packet->packet, icmp_packet, icmp_len); + socket_packet->icmp_len = icmp_len;spin_lock_bh (&socket_client->lock);/* while waiting for the lock the socket_client could have been * deleted */ -if (!batadv_socket_client_hash[icmph->uid]) { +if (!batadv_socket_client_hash[icmp_packet->uid]) {spin_unlock_bh (&socket_client->lock);kfree (socket_packet);return ;
@@ -396,15 +426,17 @@ static void batadv_socket_add_packet(struct batadv_socket_client *socket_client,/** * batadv_socket_receive_packet - schedule an icmp packet to be received * locally and sent to userspace. -* @icmph: pointer to the header of the icmp packet +* @icmp_buffer: pointer to the the icmp packet * @icmp_len: total length of the icmp packet */ -void batadv_socket_receive_packet (struct batadv_icmp_header *icmph, -size_t icmp_len) +void batadv_socket_receive_packet (void *icmp_buffer,size_t icmp_len) {struct batadv_socket_client *hash; +struct batadv_icmp_packet *icmp; + + icmp = (struct batadv_icmp_packet *)icmp_buffer; - hash = batadv_socket_client_hash[icmph->uid]; + hash = batadv_socket_client_hash[icmp->uid];if (hash) -batadv_socket_add_packet (hash, icmph, icmp_len); +batadv_socket_add_packet (hash, icmp_buffer, icmp_len); }
net/batman-adv/icmp_socket.h +1 -4
@@ -22,13 +22,10 @@#include <linux/types.h> -struct batadv_icmp_header ; -#define BATADV_ICMP_SOCKET "socket"void batadv_socket_init (void );int batadv_socket_setup (struct batadv_priv *bat_priv); -void batadv_socket_receive_packet (struct batadv_icmp_header *icmph, -size_t icmp_len); +void batadv_socket_receive_packet (void *icmp_buffer,size_t icmp_len);#endif /* _NET_BATMAN_ADV_ICMP_SOCKET_H_ */
net/batman-adv/packet.h +15 -0
@@ -284,6 +284,21 @@ struct batadv_elp_packet {#define BATADV_ELP_HLEN sizeof(struct batadv_elp_packet)/** +* struct batadv_icmp_user_packet - used to start an ICMP operation from +* userspace +* @dst: destination node +* @version: compat version used by userspace +* @cmd_type: the command to start +* @arg1: possible argument for the command +*/ +struct batadv_icmp_user_packet { +u8 dst[ETH_ALEN ]; +u8 version; +u8 cmd_type; +u32 arg1; +}; + +/** * struct batadv_icmp_header - common members among all the ICMP packets * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header
net/batman-adv/types.h +2 -0
@@ -987,11 +987,13 @@ struct batadv_socket_client {* @list: list node for batadv_socket_client::queue_list * @icmp_len: size of the layer2 icmp packet * @icmp_packet: layer2 icmp packet +* @packet: payload of layer2 icmp packet */ struct batadv_socket_packet {struct list_head list;size_t icmp_len;u8 icmp_packet[BATADV_ICMP_MAX_PACKET_SIZE ]; +u8 packet[0 ]; };#ifdef CONFIG_BATMAN_ADV_BLA
Signature · 1 line
2.7.0
RFC 3/5 batman-adv: Add compatibility code for to_delayed_work
In reply to Sven EckelmannFrom: Sven Eckelmann <[email protected]>
--- compat-include/linux/workqueue.h | 46 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 compat-include/linux/workqueue.h
compat-include/linux/workqueue.h new file +46 -0
@@ -0,0 +1,46 @@ +/* Copyright (C) 2007-2016 B.A.T.M.A.N. contributors: +* +* Marek Lindner, Simon Wunderlich +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of version 2 of the GNU General Public +* License as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, see <http://www.gnu.org/licenses/>. +* +* This file contains macros for maintaining compatibility with older versions +* of the Linux kernel. +*/ + +#ifndef _NET_BATMAN_ADV_COMPAT_LINUX_WORKQUEUE_H_ +#define _NET_BATMAN_ADV_COMPAT_LINUX_WORKQUEUE_H_ + +#include <linux/version.h> +#include_next <linux/workqueue.h> + +#include <linux/kernel.h> + +#if LINUX_VERSION_CODE <KERNEL_VERSION (2 ,6 ,30 ) + +/* some stable versions like Linux 3.2.44 also introduced this function +* and would therefore break the build because they trigger a redefinition +* of this function. Instead rename this function to be in the batadv_* +* namespace +*/ +#define to_delayed_work (__work) batadv_to_delayed_work(__work) + +static inline struct delayed_work * +batadv_to_delayed_work (struct work_struct *work) +{ + return container_of(work, struct delayed_work, work); +} + +#endif /* < KERNEL_VERSION(2, 6, 30) */ + +#endif /* _NET_BATMAN_ADV_COMPAT_LINUX_WORKQUEUE_H_ */
Signature · 1 line
2.7.0
RFC 4/5 batman-adv: throughput meter implementation
In reply to Sven EckelmannFrom: Antonio Quartulli <[email protected]>
The throughput meter module is a simple, kernel-space replacement for throughtput measurements tool like iperf and netperf. It is intended to approximate TCP behaviour.
It is invoked through batctl: the protocol is connection oriented, with cumulative acknowledgment and a dynamic-size sliding window.
The test *can* be interrupted by batctl. A receiver side timeout avoids unlimited waitings for sender packets: after one second of inactivity, the receiver abort the ongoing test.
Based on a prototype from Edo Monticelli <[email protected]>
--- net/batman-adv/Makefile | 1 + net/batman-adv/icmp_socket.c | 17 +- net/batman-adv/main.c | 2 + net/batman-adv/main.h | 24 +- net/batman-adv/packet.h | 105 +++ net/batman-adv/routing.c | 9 +- net/batman-adv/soft-interface.c | 2 + net/batman-adv/tp_meter.c | 1451 +++++++++++++++++++++++++++++++++++++++ net/batman-adv/tp_meter.h | 34 + net/batman-adv/types.h | 111 +++ 10 files changed, 1746 insertions(+), 10 deletions(-) create mode 100644 net/batman-adv/tp_meter.c create mode 100644 net/batman-adv/tp_meter.h
net/batman-adv/Makefile +1 -0
@@ -39,4 +39,5 @@ batman-adv-y += routing.o batman-adv-y += send.o batman-adv-y += soft-interface.o batman-adv-y += sysfs.o +batman-adv-y += tp_meter.o batman-adv-y += translation-table.o
net/batman-adv/icmp_socket.c +15 -2
@@ -48,6 +48,7 @@#include "originator.h" #include "packet.h" #include "send.h" +#include "tp_meter.h" static struct batadv_socket_client *batadv_socket_client_hash[256 ];
@@ -57,6 +58,7 @@ static void batadv_socket_add_packet(struct batadv_socket_client *socket_client,void batadv_socket_init (void ) {memset (batadv_socket_client_hash,0 ,sizeof (batadv_socket_client_hash)); +batadv_tp_meter_init (); }static int batadv_socket_open (struct inode *inode,struct file *file)
@@ -191,8 +193,19 @@ batadv_socket_write_user(struct batadv_priv *bat_priv,if (copy_from_user (&icmp_user_packet, buff, len))return -EFAULT ; -/* no command supported yet! */ - len = -EINVAL ; +switch (icmp_user_packet.cmd_type) { +case BATADV_TP_START : +batadv_tp_start (socket_client, icmp_user_packet.dst, + icmp_user_packet.arg1); +break ; +case BATADV_TP_STOP : +batadv_tp_stop (bat_priv, icmp_user_packet.dst, +BATADV_TP_SIGINT ); +break ; +default : + len = -EINVAL ; +break ; + }return len; }
net/batman-adv/main.c +2 -0
@@ -141,6 +141,7 @@ int batadv_mesh_init(struct net_device *soft_iface)spin_lock_init (&bat_priv->tvlv.container_list_lock);spin_lock_init (&bat_priv->tvlv.handler_list_lock);spin_lock_init (&bat_priv->softif_vlan_list_lock); +spin_lock_init (&bat_priv->tp_list_lock);INIT_HLIST_HEAD (&bat_priv->forw_bat_list);INIT_HLIST_HEAD (&bat_priv->forw_bcast_list);
@@ -159,6 +160,7 @@ int batadv_mesh_init(struct net_device *soft_iface)INIT_HLIST_HEAD (&bat_priv->tvlv.container_list);INIT_HLIST_HEAD (&bat_priv->tvlv.handler_list);INIT_HLIST_HEAD (&bat_priv->softif_vlan_list); +INIT_HLIST_HEAD (&bat_priv->tp_list); ret =batadv_v_mesh_init (bat_priv);if (ret <0 )
net/batman-adv/main.h +17 -7
@@ -100,6 +100,9 @@#define BATADV_NUM_BCASTS_WIRELESS 3#define BATADV_NUM_BCASTS_MAX 3 +/* length of the single packet used by the TP meter */ +#define BATADV_TP_PACKET_LEN ETH_DATA_LEN +/* msecs after which an ARP_REQUEST is sent in broadcast as fallback */ #define ARP_REQ_DELAY 250/* numbers of originator to contact for any PUT/GET DHT operation */
@@ -129,6 +132,11 @@#define BATADV_NC_NODE_TIMEOUT 10000/* Milliseconds */ +/** +* BATADV_TP_MAX_NUM - maximum number of simultaneously active tp sessions +*/ +#define BATADV_TP_MAX_NUM 5 +enum batadv_mesh_state {BATADV_MESH_INACTIVE ,BATADV_MESH_ACTIVE ,
@@ -227,16 +235,18 @@ __be32 batadv_skb_crc32(struct sk_buff *skb, u8 *payload_ptr);* @BATADV_DBG_BLA: bridge loop avoidance messages * @BATADV_DBG_DAT: ARP snooping and DAT related messages * @BATADV_DBG_NC: network coding related messages +* @BATADV_DBG_TP_METER: throughput meter messages * @BATADV_DBG_ALL: the union of all the above log levels */ enum batadv_dbg_level { -BATADV_DBG_BATMAN =BIT (0 ), -BATADV_DBG_ROUTES =BIT (1 ), -BATADV_DBG_TT =BIT (2 ), -BATADV_DBG_BLA =BIT (3 ), -BATADV_DBG_DAT =BIT (4 ), -BATADV_DBG_NC =BIT (5 ), -BATADV_DBG_ALL =63 , +BATADV_DBG_BATMAN =BIT (0 ), +BATADV_DBG_ROUTES =BIT (1 ), +BATADV_DBG_TT =BIT (2 ), +BATADV_DBG_BLA =BIT (3 ), +BATADV_DBG_DAT =BIT (4 ), +BATADV_DBG_NC =BIT (5 ), +BATADV_DBG_TP_METER =BIT (6 ), +BATADV_DBG_ALL =127 , };#ifdef CONFIG_BATMAN_ADV_DEBUG
net/batman-adv/packet.h +105 -0
129 lines not on this page · raw message
net/batman-adv/routing.c +8 -1
@@ -45,6 +45,7 @@#include "packet.h" #include "send.h" #include "soft-interface.h" +#include "tp_meter.h" #include "translation-table.h" static int batadv_route_unicast_packet(struct sk_buff *skb,
@@ -233,7 +234,6 @@ static int batadv_recv_my_icmp_packet(struct batadv_priv *bat_priv,/* receive the packet */ if (skb_linearize (skb) <0 )break ; -batadv_socket_receive_packet (icmph, skb->len);break ;case BATADV_ECHO_REQUEST :
@@ -266,6 +266,13 @@ static int batadv_recv_my_icmp_packet(struct batadv_priv *bat_priv, ret =NET_RX_SUCCESS ;break ; +case BATADV_TP : +if (!pskb_may_pull (skb,sizeof (struct batadv_icmp_tp_packet ))) + goto out; + +batadv_tp_meter_recv (bat_priv, skb); + ret =NET_RX_SUCCESS ; + goto out;default :/* drop unknown type */ goto out;
net/batman-adv/soft-interface.c +2 -0
@@ -820,6 +820,8 @@ static int batadv_softif_init_late(struct net_device *dev)#ifdef CONFIG_BATMAN_ADV_BLA atomic_set (&bat_priv->bla.num_requests,0 );#endif +atomic_set (&bat_priv->tp_num,0 ); + bat_priv->tt.last_changeset =NULL ; bat_priv->tt.last_changeset_len =0 ; bat_priv->isolation_mark =0 ;
net/batman-adv/tp_meter.c new file +1451 -0
1,451 lines not on this page · raw message
net/batman-adv/tp_meter.h new file +34 -0
@@ -0,0 +1,34 @@ +/* Copyright (C) 2012-2016 B.A.T.M.A.N. contributors: +* +* Edo Monticelli, Antonio Quartulli +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of version 2 of the GNU General Public +* License as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#ifndef _NET_BATMAN_ADV_TP_METER_H_ +#define _NET_BATMAN_ADV_TP_METER_H_ + +#include "main.h" + +struct sk_buff ; + +#include <linux/types.h> + +void batadv_tp_meter_init (void ); +void batadv_tp_start (struct batadv_socket_client *socket_client,const u8 *dst, +u32 test_length); +void batadv_tp_stop (struct batadv_priv *bat_priv,const u8 *dst, +u8 return_value); +void batadv_tp_meter_recv (struct batadv_priv *bat_priv,struct sk_buff *skb); + +#endif /* _NET_BATMAN_ADV_TP_METER_H_ */
net/batman-adv/types.h +111 -0
135 lines not on this page · raw message
Signature · 1 line
2.7.0
RFC 5/5 batctl: introduce throughput meter support
In reply to Sven EckelmannFrom: Antonio Quartulli <[email protected]>
Add command to launch the throughput meter test. The throughput meter is a batman kernelspace tool for throughput measurements. The syntax is:
batctl tp <MAC>
The test is interruptible with SIGINT or SIGTERM; if the test succeeds with no error the throughput and the elapsed time are printed to stdout, otherwise occurred an error message is displayed (on stdout) accordingly.
Based on a prototype from Edo Monticelli <[email protected]>
--- Makefile | 2 +- main.c | 6 ++ man/batctl.8 | 24 ++++++- packet.h | 120 +++++++++++++++++++++++++++++++ tcpdump.c | 14 +++- tp_meter.c | 227 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tp_meter.h | 22 ++++++ 7 files changed, 411 insertions(+), 4 deletions(-) create mode 100644 tp_meter.c create mode 100644 tp_meter.h
Makefile +1 -1
@@ -24,7 +24,7 @@ export CONFIG_BATCTL_BISECT=n # batctl build BINARY_NAME = batctl -OBJ = main.o bat-hosts.o functions.o sys.o debug.o ping.o traceroute.o tcpdump.o hash.o debugfs.o ioctl.o list-batman.o translate.o +OBJ = main.o bat-hosts.o functions.o sys.o debug.o ping.o traceroute.o tcpdump.o hash.o debugfs.o ioctl.o list-batman.o translate.o tp_meter.o OBJ_BISECT = bisect_iv.o MANPAGE = man/batctl.8
main.c +6 -0
@@ -33,6 +33,7 @@#include "translate.h" #include "traceroute.h" #include "tcpdump.h" +#include "tp_meter.h" #include "bisect_iv.h" #include "ioctl.h" #include "functions.h"
@@ -82,6 +83,7 @@ static void print_usage(void)fprintf (stderr," \tping|p <destination> \tping another batman adv host via layer 2\n" );fprintf (stderr," \ttraceroute|tr <destination> \ttraceroute another batman adv host via layer 2\n" );fprintf (stderr," \ttcpdump|td <interface> \ttcpdump layer 2 traffic on the given interface\n" ); +printf (" \tthroughputmeter|tp <destination> \tstart a throughput measurement\n" );fprintf (stderr," \ttranslate|t <destination> \ttranslate a destination to the originator responsible for it\n" );#ifdef BATCTL_BISECT fprintf (stderr," \tbisect_iv <file1> .. <fileN>\tanalyze given batman iv log files for routing stability\n" );
@@ -162,6 +164,10 @@ int main(int argc, char **argv) ret =ping (mesh_iface, argc -1 , argv +1 ); + }else if ((strcmp (argv[1 ],"throughputmeter" ) ==0 ) || (strcmp (argv[1 ],"tp" ) ==0 )) { + + ret =tp_meter (mesh_iface, argc -1 , argv +1 ); + }else if ((strcmp (argv[1 ],"traceroute" ) ==0 ) || (strcmp (argv[1 ],"tr" ) ==0 )) { ret =traceroute (mesh_iface, argc -1 , argv +1 );
man/batctl.8 +22 -2
@@ -36,9 +36,11 @@ B.A.T.M.A.N. advanced operates on layer 2. Thus all hosts participating in the v connected together for all protocols above layer 2. Therefore the common diagnosis tools do not work as expected. To overcome these problems batctl contains the commands \fBping\fP, \fBtraceroute\fP, \fBtcpdump\fP which provide similar functionality to the normal \fBping\fP(1), \fBtraceroute\fP(1), \fBtcpdump\fP(1) commands, but modified to layer 2 -behaviour or using the B.A.T.M.A.N. advanced protocol. -.PP +behaviour or using the B.A.T.M.A.N. advanced protocol. For similar reasons, \fBthroughputmeter\fP, a command to test network +performances, is also included. + .PP +.Pp .SH OPTIONS .TP .I \fBoptions:
@@ -319,6 +321,24 @@ for routing loops. Use "\-t" to trace OGMs of a host throughout the network. Use nodes. The option "\-s" can be used to limit the output to a range of sequence numbers, between min and max, or to one specific sequence number, min. Furthermore using "\-o" you can filter the output to a specified originator. If "\-n" is given batctl will not replace the MAC addresses with bat\-host names in the output. +.RE +.br +.IP "\fBthroughputmeter\fP|\fBtp\fP \fBMAC\fP" +This command starts a throughput test entirely controlled by batman module in +kernel space: the computational resources needed to align memory and copy data +between user and kernel space that are required by other user space tools may +represent a bootleneck on some low profile device. + +The test consist of the transfer of 14 MB of data between the two nodes. The +protocol used to transfer the data is somehow similar to TCP, but simpler: some +TCP features are still missing, thus protocol performances could be worst. Since +a fixed amount of data is transferred the experiment duration depends on the +network conditions. The experiment can be interrupted with CTRL + C. At the end +of a succesful experiment the throughput in KBytes per second is returned, +togheter with the experiment duration in millisecond and the amount of bytes +transferred. If too many packets are lost or the specified MAC address is not +reachable, a message notifing the error is returned instead of the result. +.RE .br .SH FILES .TP
packet.h +120 -0
144 lines not on this page · raw message
tcpdump.c +13 -1
@@ -741,11 +741,14 @@ static void dump_batman_iv_ogm(unsigned char *packet_buff, ssize_t buff_len, intstatic void dump_batman_icmp (unsigned char *packet_buff,ssize_t buff_len,int read_opt,int time_printed) {struct batadv_icmp_packet *icmp_packet; +struct batadv_icmp_tp_packet *tp; +char *name;LEN_CHECK ((size_t )buff_len -sizeof (struct ether_header ),sizeof (struct batadv_icmp_packet ),"BAT ICMP" ); icmp_packet = (struct batadv_icmp_packet *)(packet_buff +sizeof (struct ether_header )); + tp = (struct batadv_icmp_tp_packet *)icmp_packet;if (!time_printed)print_time ();
@@ -753,7 +756,8 @@ static void dump_batman_icmp(unsigned char *packet_buff, ssize_t buff_len, int rprintf ("BAT %s > " ,get_name_by_macaddr ((struct ether_addr *)icmp_packet->orig, read_opt)); - name =get_name_by_macaddr ((struct ether_addr *)icmp_packet->dst, read_opt); + name =get_name_by_macaddr ((struct ether_addr *)icmp_packet->dst, + read_opt);switch (icmp_packet->msg_type) {case BATADV_ECHO_REPLY :
@@ -774,6 +778,14 @@ static void dump_batman_icmp(unsigned char *packet_buff, ssize_t buff_len, int r icmp_packet->ttl, icmp_packet->version, (size_t)buff_len - sizeof(struct ether_header));break ; +case BATADV_TP : +printf ("%s: ICMP TP type %s (%hhu), id %hhu, seq %u, ttl %2d, v %d, length %zu\n" , + name, tp->subtype ==BATADV_TP_MSG ?"MSG" : + tp->subtype ==BATADV_TP_ACK ?"ACK" :"N/A" , + tp->subtype, tp->uid,ntohl (tp->seqno), tp->ttl, + tp->version, + (size_t )buff_len -sizeof (struct ether_header )); +break ;default : printf("%s: ICMP type %hhu, length %zu\n", name, icmp_packet->msg_type,
tp_meter.c new file +227 -0
227 lines not on this page · raw message
tp_meter.h new file +22 -0
@@ -0,0 +1,22 @@ +/* +* Copyright (C) 2013-2016 B.A.T.M.A.N. contributors: +* +* Antonio Quartulli <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of version 2 of the GNU General Public +* License as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +* 02110-1301, USA +* +*/ + +int tp_meter (char *mesh_iface,int argc,char **argv);
Signature · 1 line
2.7.0
Hi Sven,
thanks for your email and sorry for the late reply.
I shifted my interests and I am currently working as front-end developer, I am afraid that my C skills could be a bit rusty :) In addition so much is going on both on the professional and personal life that I am afraid at least for the time being I hardly could inject a new project.
best,
Edo
Quoted 81 lines · Sven Eckelmann
Hi,
do you still remember GSOC 2012? Yes, it is really long ago. It was a time when winters were still cold, summers still hot and it was still politically correct to say "bandwidth meter" when you actually meant "throughput meter".
Three students tried their best to implement some of the ideas floating around in the B.A.T.M.A.N. advanced community. And after some more work, most of the features reached the finishing line. TVLV [1] and the fragmentation v2 [2] were both integrated as part of the COMPAT 15 bump. But the "bandwidth meter" [3] was never ready to being merged.
Nevertheless, the lessons learned in the first implementation [4] inspired different people to continue working on it. Especially Antonio Quartulli worked on his own version to increase its usefulness. And this feature makes even more sense since we reached the new "throughput based metric" time epoch with the introduction of B.A.T.M.A.N. V.
I hope we can reignite interest in this feature with a rebased and refurbished version of this patchset. Both the batman-adv and batctl patches are based on the newest revision in their respective master branches. Also a branch called "
tp_meter" was created in the batctl.git and batman-adv.git repository with these patches already applied.batman-adv
==========Antonio Quartulli (2):
batman-adv: return netdev status in the TX path
batman-adv: use another ICMP packet when sending command from userspace
batman-adv: throughput meter implementationSven Eckelmann (1):
batman-adv: Add compatibility code forto_delayed_workcompat-include/linux/netdevice.h | 17 + compat-include/linux/workqueue.h | 46 ++ net/batman-adv/Makefile | 1 + net/batman-adv/fragmentation.c | 41 +- net/batman-adv/fragmentation.h | 6 +- net/batman-adv/icmp_socket.c | 225 +++--- net/batman-adv/icmp_socket.h | 5 +- net/batman-adv/main.c | 6 +- net/batman-adv/main.h | 24 +- net/batman-adv/packet.h | 120 ++++ net/batman-adv/routing.c | 33 +- net/batman-adv/send.c | 25 +- net/batman-adv/soft-interface.c | 2 + net/batman-adv/tp_meter.c | 1451 ++++++++++++++++++++++++++++++++++++++ net/batman-adv/tp_meter.h | 34 + net/batman-adv/types.h | 113 +++ 16 files changed, 2005 insertions(+), 144 deletions(-)batctl
======Antonio Quartulli (1):
batctl: introduce throughput meter supportMakefile | 2 +- main.c | 6 ++ man/batctl.8 | 24 ++++++- packet.h | 120 +++++++++++++++++++++++++++++++ tcpdump.c | 14 +++- tp_meter.c | 227 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tp_meter.h | 22 ++++++ 7 files changed, 411 insertions(+), 4 deletions(-)Kind regards,
Sven[1] https://www.open-mesh.org/projects/open-mesh/wiki/2012-10-01-GSoC-2012-Spyros-Gasteros-Final-Report
[2] https://www.open-mesh.org/projects/open-mesh/wiki/2012-09-24-GSoC-2012-Martin-Hundebolls-Final-Report
[3] https://www.open-mesh.org/projects/open-mesh/wiki/2012-10-06-GSoC-2012-Edo-Monticellis-Final-Report
[4] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2012-August/007924.html