Skip to contentSkip to conversation

ARM: dts: imx25.dtsi: change the clock information for usb

PATCH New Peter Chen 2 participants 3 messages Feb 19, 2016 – Feb 28, 2016

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH 1/2 ARM: dts: imx25.dtsi: change the clock information for usb

From: Peter Chen <[email protected]>

For imx25, it needs three clocks to let the controller work, the old code is wrong, and usbmisc has not included clock handling code any more.

Acked-by Shawn Guo <[email protected]>
Tested-by Fabio Estevam <[email protected]>
Signed-off-by Peter Chen <[email protected]>

---
Shawn, the related changes for i.mx27 has already been in mainline. Unlike the changes for i.mx27, it is not a bug fix for i.mx25 and i.mx35.

 arch/arm/boot/dts/imx25.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx25.dtsi +4 -4
index cde329e..d82e8d8 100644
@@ -497,7 +497,8 @@
 				compatible = "fsl,imx25-usb", "fsl,imx27-usb";
 				reg = <0x53ff4000 0x0200>;
 				interrupts = <37>;
-				clocks = <&clks 70>;
+				clocks = <&clks 9>, <&clks 70>, <&clks 8>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 0>;
 				fsl,usbphy = <&usbphy0>;
 				status = "disabled";

@@ -507,7 +508,8 @@
 				compatible = "fsl,imx25-usb", "fsl,imx27-usb";
 				reg = <0x53ff4400 0x0200>;
 				interrupts = <35>;
-				clocks = <&clks 70>;
+				clocks = <&clks 9>, <&clks 70>, <&clks 8>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 1>;
 				fsl,usbphy = <&usbphy1>;
 				status = "disabled";

@@ -516,8 +518,6 @@
 			usbmisc: usbmisc at 53ff4600 {
 				#index-cells = <1>;
 				compatible = "fsl,imx25-usbmisc";
-				clocks = <&clks 9>, <&clks 70>, <&clks 8>;
-				clock-names = "ipg", "ahb", "per";
 				reg = <0x53ff4600 0x00f>;
 			};
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 ARM: dts: imx35.dtsi: change the clock information for usb

From: Peter Chen <[email protected]>

For imx35, it needs three clocks to let the controller work, the old code is wrong, and the usbmisc does not include clock handling code any more.

Signed-off-by Peter Chen <[email protected]>
Acked-by Shawn Guo <[email protected]>
---
 arch/arm/boot/dts/imx35.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx35.dtsi +4 -4
index ed3dc33..14e1320 100644
@@ -305,7 +305,8 @@
 				compatible = "fsl,imx35-usb", "fsl,imx27-usb";
 				reg = <0x53ff4000 0x0200>;
 				interrupts = <37>;
-				clocks = <&clks 73>;
+				clocks = <&clks 9>, <&clks 73>, <&clks 28>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 0>;
 				fsl,usbphy = <&usbphy0>;
 				status = "disabled";

@@ -315,7 +316,8 @@
 				compatible = "fsl,imx35-usb", "fsl,imx27-usb";
 				reg = <0x53ff4400 0x0200>;
 				interrupts = <35>;
-				clocks = <&clks 73>;
+				clocks = <&clks 9>, <&clks 73>, <&clks 28>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 1>;
 				fsl,usbphy = <&usbphy1>;
 				dr_mode = "host";

@@ -325,8 +327,6 @@
 			usbmisc: usbmisc at 53ff4600 {
 				#index-cells = <1>;
 				compatible = "fsl,imx35-usbmisc";
-				clocks = <&clks 9>, <&clks 73>, <&clks 28>;
-				clock-names = "ipg", "ahb", "per";
 				reg = <0x53ff4600 0x00f>;
 			};
 		};
Signature · 1 line
1.9.1
Applied
#2 lore raw

PATCH 1/2 ARM: dts: imx25.dtsi: change the clock information for usb

In reply to Peter Chen
Quoted 9 lines · Peter Chen

From: Peter Chen <[email protected]>

For imx25, it needs three clocks to let the controller work, the old code is wrong, and usbmisc has not included clock handling code any more.

Acked-by Shawn Guo <[email protected]>
Tested-by Fabio Estevam <[email protected]>
Signed-off-by Peter Chen <[email protected]>

Applied both, thanks.