Skip to contentSkip to conversation

gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields

PATCH In review Axel Lin 3 participants 3 messages Feb 20, 2016 – Feb 25, 2016 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields

Both chip->base and chip->label are correctly set by bgpio_init().

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-ts4800.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-ts4800.c +0 -2
index 9da79e4..1478245 100644
@@ -54,8 +54,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
 		return retval;
 	}
 
-	chip->base = -1;
-	chip->label = dev_name(&pdev->dev);
 	chip->ngpio = ngpios;
 
 	platform_set_drvdata(pdev, chip);
Signature · 1 line
2.1.4
Tested-by on v1 1/1
#1 lore raw

Hello,

Thank you for this patch. I checked and it still works as expected.

----- Original Message -----

Quoted 10 lines

From: "Axel Lin" <[email protected]>
To: "Linus Walleij" <[email protected]>
Cc: "Julien Grossholtz" <[email protected]>, "Alexandre Courbot" <[email protected]>, [email protected]
Sent: Saturday, February 20, 2016 1:22:46 AM
Subject: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields

Both chip->base and chip->label are correctly set by bgpio_init().

Signed-off-by Axel Lin <[email protected]>
Tested-by Julien Grossholtz <[email protected]>
Quoted 19 lines

---
drivers/gpio/gpio-ts4800.c | 2 --

1 file changed, 2 deletions(-)
drivers/gpio/gpio-ts4800.c +0 -3
index 9da79e4..1478245 100644
@@ -54,8 +54,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
 		return retval;
 	}
 
-	chip->base = -1;
-	chip->label = dev_name(&pdev->dev);
 	chip->ngpio = ngpios;
 
 	platform_set_drvdata(pdev, chip);
--

2.1.4