Skip to contentSkip to conversation

x86/xsaves: Keep init_fpstate.xsave.header.xfeatures as zero for init optimization

PATCH Superseded Yu-cheng Yu 1 participant 1 message Feb 22, 2016 x86

v1 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH 3/10 x86/xsaves: Keep init_fpstate.xsave.header.xfeatures as zero for init optimization

Keep init_fpstate.xsave.header.xfeatures as zero for init optimization. This is important for init optimization that is implemented in processor. If a bit corresponding to an xstate in xstate_bv is 0, it means the xstate is in init status and will not be read from memory to the processor during XRSTOR/XRSTORS instruction. This largely impacts context switch performance.

---
 arch/x86/kernel/fpu/xstate.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/kernel/fpu/xstate.c +1 -3
index b8d6d98..daff143 100644
@@ -311,10 +311,8 @@ static void __init setup_init_fpu_buf(void)
 	setup_xstate_features();
 	print_xstate_features();
 
-	if (cpu_has_xsaves) {
+	if (cpu_has_xsaves)
 		init_fpstate.xsave.header.xcomp_bv = (u64)1 << 63 | xfeatures_mask;
-		init_fpstate.xsave.header.xfeatures = xfeatures_mask;
-	}
 
 	/*
 	 * Init all the features state with header_bv being 0x0
Signature · 1 line
1.9.1