FAILED: patch "[PATCH] KVM: s390: fix guest fprs memory leak" failed to apply to 4.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
9c7ebb613bffea2feef4ec562ba1dbcaa810942bMon Sep 17 00:00:00 2001
From: David Hildenbrand <[email protected]>
Date: Fri, 22 Jan 2016 14:55:56 +0100
Subject: [PATCH] KVM: s390: fix guest fprs memory leak
fprs is never freed, therefore resulting in a memory leak if kvm_vcpu_init() fails or the vcpu is destroyed.
Fixes 9977e886cbbc ("s390/kernel: lazy restore fpu registers")
Cc [email protected] # v4.3+
Reported-by Eric Farman <[email protected]>
Signed-off-by David Hildenbrand <[email protected]>
Reviewed-by Eric Farman <[email protected]>
Signed-off-by Christian Borntraeger <[email protected]>
arch/s390/kvm/kvm-s390.c +4 -1
@@ -1244,6 +1244,7 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)if (vcpu->kvm->arch.use_cmma)kvm_s390_vcpu_unsetup_cmma (vcpu); +kfree (vcpu->arch.guest_fpregs.fprs);free_page ((unsigned long )(vcpu->arch.sie_block));kvm_vcpu_uninit (vcpu);
@@ -1661,12 +1662,14 @@ struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, rc =kvm_vcpu_init (vcpu, kvm, id);if (rc) - goto out_free_sie_block; + goto out_free_fprs;VM_EVENT (kvm,3 ,"create cpu %d at 0x%pK, sie block at 0x%pK" , id, vcpu, vcpu->arch.sie_block);trace_kvm_s390_create_vcpu (id, vcpu, vcpu->arch.sie_block);return vcpu; +out_free_fprs: +kfree (vcpu->arch.guest_fpregs.fprs); out_free_sie_block:free_page ((unsigned long )(vcpu->arch.sie_block)); out_free_cpu: