Patch "Btrfs: fix page reading in extent_same ioctl leading to csum errors" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
Btrfs: fix page reading in extent_same ioctl leading to csum errors
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
btrfs-fix-page-reading-in-extent_same-ioctl-leading-to-csum-errors.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
313140023026ae542ad76e7e268c56a1eaa2c28eMon Sep 17 00:00:00 2001
From: Filipe Manana <[email protected]>
Date: Wed, 27 Jan 2016 18:37:47 +0000
Subject: Btrfs: fix page reading in extent_same ioctl leading to csum errors
From: Filipe Manana <[email protected]>
commit 313140023026ae542ad76e7e268c56a1eaa2c28e upstream.
In the extent_same ioctl, we were grabbing the pages (locked) and attempting to read them without bothering about any concurrent IO against them. That is, we were not checking for any ongoing ordered extents nor waiting for them to complete, which leads to a race where the extent_same() code gets a checksum verification error when it reads the pages, producing a message like the following in dmesg and making the operation fail to user space with -ENOMEM:
[18990.161265] BTRFS warning (device sdc): csum failed ino 259 off 495616 csum 685204116 expected csum 1515870868
Fix this by using btrfs_readpage() for reading the pages instead of extent_read_full_page_nolock(), which waits for any concurrent ordered extents to complete and locks the io range. Also do better error handling and don't treat all failures as -ENOMEM, as that's clearly misleasing, becoming identical to the checks and operation of prepare_uptodate_page().
The use of extent_read_full_page_nolock() was required before commit f441460202cb ("btrfs: fix deadlock with extent-same and readpage"), as we had the range locked in an inode's io tree before attempting to read the pages.
--- fs/btrfs/ioctl.c | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-)
fs/btrfs/ioctl.c +21 -8
@@ -2782,21 +2782,27 @@ out:static struct page *extent_same_get_page (struct inode *inode,pgoff_t index) {struct page *page; -struct extent_io_tree *tree = &BTRFS_I (inode)->io_tree; page =grab_cache_page (inode->i_mapping, index);if (!page) -return NULL ; +return ERR_PTR (-ENOMEM );if (!PageUptodate (page)) { -if (extent_read_full_page_nolock (tree, page, btrfs_get_extent, -0 )) -return NULL ; +int ret; + + ret =btrfs_readpage (NULL , page); +if (ret) +return ERR_PTR (ret);lock_page (page);if (!PageUptodate (page)) {unlock_page (page);page_cache_release (page); -return NULL ; +return ERR_PTR (-EIO ); + } +if (page->mapping != inode->i_mapping) { +unlock_page (page); +page_cache_release (page); +return ERR_PTR (-EAGAIN ); } }
@@ -2810,9 +2816,16 @@ static int gather_extent_pages(struct inpgoff_t index = off >>PAGE_CACHE_SHIFT ;for (i =0 ; i < num_pages; i++) { +again: pages[i] =extent_same_get_page (inode, index + i); -if (!pages[i]) -return -ENOMEM ; +if (IS_ERR (pages[i])) { +int err =PTR_ERR (pages[i]); + +if (err == -EAGAIN ) + goto again; + pages[i] =NULL ; +return err; + } }return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/btrfs-fix-page-reading-in-extent_same-ioctl-leading-to-csum-errors.patch queue-4.4/btrfs-fix-fitrim-discarding-device-area-reserved-for-boot-loader-s-use.patch queue-4.4/btrfs-fix-hang-on-extent-buffer-lock-caused-by-the-inode_paths-ioctl.patch queue-4.4/btrfs-fix-invalid-page-accesses-in-extent_same-dedup-ioctl.patch queue-4.4/btrfs-fix-direct-io-requests-not-reporting-io-error-to-user-space.patch